Search Unity

Question My charecter suddenly stops moving

Discussion in 'Scripting' started by LazyGhost15, Mar 16, 2023.

  1. LazyGhost15

    LazyGhost15

    Joined:
    Feb 12, 2022
    Posts:
    120
    I used AddForce in my movement script for the player movement but when I play the game at first my player is moving but then He stops. I noticed that when this happens the Rigidbody velocity at X is decreased to 0.
    I'll paste the whole script here because I'm not sure what makes this happen but the movement itself happens in lines 91-99(The left movement doesn't work yet so ignore it):
    Code (CSharp):
    1. using System.Collections;
    2. using System.Collections.Generic;
    3. using UnityEngine;
    4.  
    5. public class PlayerScript : MonoBehaviour
    6. {
    7.    public bool IsFacingRight = true;
    8.     public bool IsMoving;
    9.     public bool IsOnGround;
    10.     public bool IsCurrentPlayer;
    11.     public bool DeafultKey = true;
    12.     public KeyCode KYBLeft;
    13.     public KeyCode KYBRight;
    14.     public KeyCode KYBJump;
    15.     public KeyCode KYBFireBall;
    16.     Rigidbody2D rigidbody2;
    17.    
    18.     Animator Animator;
    19.     float MaxSpeed = 30;
    20.     float Speed;
    21.     float accelaration = 4f;
    22.     public float JumpForce = 10;
    23.     public int serialNumber;
    24.     string AnimIsRight = "IsFacingRight";
    25.     string AnimIsMoving = "IsMoving";
    26.     string AnimIsOnGround = "IsOnGround";
    27.     public GameObject LinkedFlame;
    28.     public Vector2 _moveInput;
    29.  
    30.  
    31.     private void Awake()
    32.     {
    33.         serialNumber = Random.Range(0, 999999999);
    34.     }
    35.  
    36.     // Start is called before the first frame update
    37.     void Start()
    38.     {
    39.         Animator = GetComponent<Animator>();
    40.         if (DeafultKey)
    41.         {
    42.             KYBLeft = KeyCode.A;
    43.             KYBRight = KeyCode.D;
    44.             KYBJump = KeyCode.Space;
    45.             KYBFireBall = KeyCode.F;
    46.         }
    47.         rigidbody2 = GetComponent<Rigidbody2D>();
    48.        
    49.  
    50.        
    51.     }
    52.  
    53.     // Update is called once per frame
    54.     void Update()
    55.     {
    56.         if (Input.GetKeyDown(KeyCode.Space) && IsOnGround && IsCurrentPlayer)
    57.         {
    58.             IsOnGround = false;
    59.             rigidbody2.AddForce(Vector2.up * JumpForce, ForceMode2D.Impulse);
    60.         }
    61.  
    62.         _moveInput.x = Input.GetAxisRaw("Horizontal");
    63.  
    64.  
    65.     }
    66.  
    67.     private void FixedUpdate()
    68.     {
    69.         if (IsCurrentPlayer)
    70.         {
    71.             Controls();
    72.         }
    73.         else
    74.         {
    75.             PlayerAnimation(IsMoving, IsFacingRight, IsOnGround);
    76.         }
    77.  
    78.         if (!IsCurrentPlayer)
    79.         {
    80.            
    81.         }
    82.         rigidbody2.constraints = RigidbodyConstraints2D.FreezePositionX;
    83.         rigidbody2.constraints = RigidbodyConstraints2D.FreezeRotation;
    84.     }
    85.  
    86.     void Controls()
    87.     {
    88.  
    89.         Speed = _moveInput.x * MaxSpeed;
    90.  
    91.         if (Input.GetKey(KYBRight))
    92.         {
    93.             IsFacingRight = true;
    94.             IsMoving = true;
    95.             float SpeedDif = Speed - rigidbody2.velocity.x;
    96.             float movement = SpeedDif * accelaration;
    97.            
    98.             rigidbody2.AddForce(movement * Vector2.right);
    99.             print(movement);
    100.            
    101.         }
    102.         else if (Input.GetKey(KYBLeft))
    103.         {
    104.             IsFacingRight= false;
    105.             IsMoving = true;
    106.             //transform.Translate(Vector2.left * speed);
    107.            
    108.         }
    109.         else
    110.         {
    111.             IsMoving = false;
    112.            
    113.         }
    114.  
    115.        
    116.         PlayerAnimation(IsMoving, IsFacingRight, IsOnGround);
    117.     }
    118.  
    119.     void PlayerAnimation(bool Move, bool FRight, bool OGround)
    120.     {
    121.         Animator.SetBool(AnimIsMoving, Move);
    122.         Animator.SetBool(AnimIsRight, FRight);
    123.         Animator.SetBool(AnimIsOnGround, OGround);
    124.     }
    125.  
    126.  
    127.     private void OnTriggerStay2D(Collider2D collision)
    128.     {
    129.         IsOnGround = true;
    130.     }
    131.  
    132.  
    133.  
    134.  
    135.  
    136.  
    137.  
    138.  
    139. }
    140.  
     
  2. Kurt-Dekker

    Kurt-Dekker

    Joined:
    Mar 16, 2013
    Posts:
    38,745
    Wow, if you're not sure, imagine how WE feel! :)

    Time to you to start debugging! Here is how you can begin your exciting new debugging adventures:

    You must find a way to get the information you need in order to reason about what the problem is.

    Once you understand what the problem is, you may begin to reason about a solution to the problem.

    What is often happening in these cases is one of the following:

    - the code you think is executing is not actually executing at all
    - the code is executing far EARLIER or LATER than you think
    - the code is executing far LESS OFTEN than you think
    - the code is executing far MORE OFTEN than you think
    - the code is executing on another GameObject than you think it is
    - you're getting an error or warning and you haven't noticed it in the console window

    To help gain more insight into your problem, I recommend liberally sprinkling
    Debug.Log()
    statements through your code to display information in realtime.

    Doing this should help you answer these types of questions:

    - is this code even running? which parts are running? how often does it run? what order does it run in?
    - what are the values of the variables involved? Are they initialized? Are the values reasonable?
    - are you meeting ALL the requirements to receive callbacks such as triggers / colliders (review the documentation)

    Knowing this information will help you reason about the behavior you are seeing.

    You can also supply a second argument to Debug.Log() and when you click the message, it will highlight the object in scene, such as
    Debug.Log("Problem!",this);


    If your problem would benefit from in-scene or in-game visualization, Debug.DrawRay() or Debug.DrawLine() can help you visualize things like rays (used in raycasting) or distances.

    You can also call Debug.Break() to pause the Editor when certain interesting pieces of code run, and then study the scene manually, looking for all the parts, where they are, what scripts are on them, etc.

    You can also call GameObject.CreatePrimitive() to emplace debug-marker-ish objects in the scene at runtime.

    You could also just display various important quantities in UI Text elements to watch them change as you play the game.

    If you are running a mobile device you can also view the console output. Google for how on your particular mobile target, such as this answer or iOS: https://forum.unity.com/threads/how-to-capturing-device-logs-on-ios.529920/ or this answer for Android: https://forum.unity.com/threads/how-to-capturing-device-logs-on-android.528680/

    If you are working in VR, it might be useful to make your on onscreen log output, or integrate one from the asset store, so you can see what is happening as you operate your software.

    Another useful approach is to temporarily strip out everything besides what is necessary to prove your issue. This can simplify and isolate compounding effects of other items in your scene or prefab.

    Here's an example of putting in a laser-focused Debug.Log() and how that can save you a TON of time wallowing around speculating what might be going wrong:

    https://forum.unity.com/threads/coroutine-missing-hint-and-error.1103197/#post-7100494

    When in doubt, print it out!(tm)

    Note: the
    print()
    function is an alias for Debug.Log() provided by the MonoBehaviour class.
     
  3. LazyGhost15

    LazyGhost15

    Joined:
    Feb 12, 2022
    Posts:
    120


    I actually thought at first that my movement variable (which I multiply by Vector.right) changes to zero but when I checked that it showed that the movement never turns zero but the opposite it increases to its full potential. so when the velocity decreases the overall movement which I multiply by speed the sprite moves, but when the velocity is zero and the speed * acceleration maxes its potential (the acceleration is 4 and the max speed is 30) it isn't moving. even though the AddForce has bigger numbers than what he had before
     
  4. kdgalla

    kdgalla

    Joined:
    Mar 15, 2013
    Posts:
    4,639
    Don't poll for input in FixedUpdate. Check in Update instead. Not sure if that's your problem here specifically, but that could cause problems with input responsiveness.
     
  5. Kurt-Dekker

    Kurt-Dekker

    Joined:
    Mar 16, 2013
    Posts:
    38,745
    Line 82 constrains X movement.

    Line 83 REPLACES that constraint with a rotational constraint.

    If you want to add those two constraints you must use a logical OR to bring them together.

    Ideally just set that stuff in the inspector window.

    I'm guessing at least part of your problem may be related to the transient setting of X movement constraint.
     
  6. LazyGhost15

    LazyGhost15

    Joined:
    Feb 12, 2022
    Posts:
    120

    I put the input checks at fixed update because when they were in update if they collided with another object the collision and movement made them act buggy, and when I searched about that in google the forum said to put the if checks at FixedUpdate to make it smooth. but it was with the old movement system so idk if it would still act like that
     
  7. LazyGhost15

    LazyGhost15

    Joined:
    Feb 12, 2022
    Posts:
    120

    I tried to lock the characters X location when they switched between them (there were several characters and the player could switch between them) but then they started rotating so I locked the rotation through the script, I didn't know that the constraints replaced each other instead of piling up.
    after that didn't work I just scrapped the idea