Search Unity

  1. Welcome to the Unity Forums! Please take the time to read our Code of Conduct to familiarize yourself with the forum rules and how to post constructively.
  2. We have updated the language to the Editor Terms based on feedback from our employees and community. Learn more.
    Dismiss Notice

Question movement not not getting triggered but debug.log is

Discussion in 'Scripting' started by NintendoAsh12, Mar 6, 2023.

  1. NintendoAsh12


    Feb 15, 2021
    so I am redoing my input with the new input system but when you press a key it only triggers the debug.log, not the movement code does anyone know why
    Code (CSharp):
    1. using System.Collections;
    2. using System.Collections.Generic;
    3. using UnityEngine;
    4. using UnityEngine.InputSystem;
    6. public class PlayerMovment : MonoBehaviour
    7. {
    9.     public CharacterController2D controller;
    11.     public float runSpeed = 40f;
    13.     float horizontalMove = 0f;
    15.     bool jump = false;
    16.     bool chouch = false;
    17.     public Input _Input;
    18. public void Awake()
    19.     {
    21.         _Input = new Input();
    22.     }
    30.     void Update()
    31.     {
    32.         Keyboard kb = InputSystem.GetDevice<Keyboard>();
    33.         //horizontalMove = Input.GetAxisRaw("Horizontal") * runSpeed;
    34.         horizontalMove = 0;
    36.         _Input._Player.Jump.performed += ctx => Jump();
    37.         _Input._Player.Right.performed += ctx => Right();
    38.         _Input._Player.Left.performed += ctx => Left();
    39.          _Input._Player.Duck.performed += ctx => Duck();
    40.           _Input._Player.Duck.canceled += ctx => DuckStop();
    41.     }
    45.     void FixedUpdate()
    46.     {
    47.         controller.Move(horizontalMove * Time.fixedDeltaTime, chouch, jump);
    48.         jump = false;
    49.     }
    50. // redoing input it is all down here now
    51.     void Left()
    52.     {
    53.         horizontalMove = 1 * runSpeed;
    54.         Debug.Log("left");
    55.     }
    57.     void Right()
    58.         {
    59.           horizontalMove = -1 * runSpeed;
    60.           Debug.Log("notleft");
    61.         }
    63.     void Jump()
    64.     {
    65.       jump = true;
    66.       Debug.Log("Ah, might as well jump");
    68.     }
    70.     void Duck()
    71.     {
    72.         chouch = true;
    73.         Debug.Log("Down");
    74.     }
    76.     void DuckStop()
    77.     {
    78.         chouch = false;
    79.         Debug.Log("Up");
    80.     }
    81.     private void OnEnable()
    82.     {
    83.         _Input.Enable();
    84.     }
    86.     private void OnDisable()
    87.     {
    88.         _Input.Disable();
    89.     }
    90. }
  2. Kurt-Dekker


    Mar 16, 2013
    Slow down and go back to the tutorial. Somehow you have put your directional delegate subscription lines in Update(), which means you are connecting potentially HUNDREDS of delegates to each input every second. Eventually something will crash on you.

    Traditionally one connects delegates once..

    Once that is unraveled, start debugging, and I don't mean sprinkling Debug.Log() in like so much salt on a steak, but rather an intentional methodic application of Debug.Log() about quantities that actually MATTER, quantities you are actively investigating.

    In the above, you should be printing horizontalMove every frame. That is what you are investigating!

    You must find a way to get the information you need in order to reason about what the problem is.

    Once you understand what the problem is, you may begin to reason about a solution to the problem.

    What is often happening in these cases is one of the following:

    - the code you think is executing is not actually executing at all
    - the code is executing far EARLIER or LATER than you think
    - the code is executing far LESS OFTEN than you think
    - the code is executing far MORE OFTEN than you think
    - the code is executing on another GameObject than you think it is
    - you're getting an error or warning and you haven't noticed it in the console window

    To help gain more insight into your problem, I recommend liberally sprinkling
    statements through your code to display information in realtime.

    Doing this should help you answer these types of questions:

    - is this code even running? which parts are running? how often does it run? what order does it run in?
    - what are the values of the variables involved? Are they initialized? Are the values reasonable?
    - are you meeting ALL the requirements to receive callbacks such as triggers / colliders (review the documentation)

    Knowing this information will help you reason about the behavior you are seeing.

    You can also supply a second argument to Debug.Log() and when you click the message, it will highlight the object in scene, such as

    If your problem would benefit from in-scene or in-game visualization, Debug.DrawRay() or Debug.DrawLine() can help you visualize things like rays (used in raycasting) or distances.

    You can also call Debug.Break() to pause the Editor when certain interesting pieces of code run, and then study the scene manually, looking for all the parts, where they are, what scripts are on them, etc.

    You can also call GameObject.CreatePrimitive() to emplace debug-marker-ish objects in the scene at runtime.

    You could also just display various important quantities in UI Text elements to watch them change as you play the game.

    If you are running a mobile device you can also view the console output. Google for how on your particular mobile target, such as this answer or iOS: or this answer for Android:

    If you are working in VR, it might be useful to make your on onscreen log output, or integrate one from the asset store, so you can see what is happening as you operate your software.

    Another useful approach is to temporarily strip out everything besides what is necessary to prove your issue. This can simplify and isolate compounding effects of other items in your scene or prefab.

    Here's an example of putting in a laser-focused Debug.Log() and how that can save you a TON of time wallowing around speculating what might be going wrong:

    When in doubt, print it out!(tm)

    Note: the
    function is an alias for Debug.Log() provided by the MonoBehaviour class.
    Homicide likes this.