Feature Request More performant Tracked Pose Driver (solution included)

The current TrackedPoseDriver sets the local position and rotation in 1 external call each, with both having to recalculate all children etc. This can definitely add overhead over time when adding animation to the hands etc.
Recent unity versions have SetLocalPositionAndRotation. Using this in SetLocalTransform will be beneficial for performance. No changes are made in behavior, with TrackingType.RotationAndPosition performance improved (1 less branch and combined call), and rotation/position only modes just have 1 extra branch when used.


Starts at line 584 for those who want to use the improved version.
Old code:

Code (CSharp):

1. protected virtual void SetLocalTransform(Vector3 newPosition, Quaternion newRotation)
2.         {
3.             var positionValid = m_IgnoreTrackingState || (m_CurrentTrackingState & TrackingStates.Position) != 0;
4.             var rotationValid = m_IgnoreTrackingState || (m_CurrentTrackingState & TrackingStates.Rotation) != 0;
5.  
6.             if (rotationValid &&
7.                 (m_TrackingType == TrackingType.RotationAndPosition ||
8.                  m_TrackingType == TrackingType.RotationOnly))
9.             {
10.                 transform.localRotation = newRotation;
11.             }
12.  
13.             if (positionValid &&
14.                 (m_TrackingType == TrackingType.RotationAndPosition ||
15.                  m_TrackingType == TrackingType.PositionOnly))
16.             {
17.                 transform.localPosition = newPosition;
18.             }
19.         }

New improved code:

Code (CSharp):

1. protected virtual void SetLocalTransform(Vector3 newPosition, Quaternion newRotation)
2.         {
3.             var positionValid = m_IgnoreTrackingState || (m_CurrentTrackingState & TrackingStates.Position) != 0;
4.             var rotationValid = m_IgnoreTrackingState || (m_CurrentTrackingState & TrackingStates.Rotation) != 0;
5.  
6.             if(m_TrackingType == TrackingType.RotationAndPosition && rotationValid && positionValid)
7.             {
8.                 transform.SetLocalPositionAndRotation(newPosition, newRotation);
9.             }
10.             else
11.             {
12.                 if (rotationValid &&
13.                 m_TrackingType == TrackingType.RotationOnly)
14.                 {
15.                     transform.localRotation = newRotation;
16.                 }
17.  
18.                 if (positionValid &&
19.                      m_TrackingType == TrackingType.PositionOnly)
20.                 {
21.                     transform.localPosition = newPosition;
22.                 }
23.             }
24.         }

 

This might help: https://github.com/Unity-Technologies/InputSystem/pull/1715

It has all the info on an implementation

 

Fixed in Input System 1.7

 

Good to hear