Search Unity

Question Member modifier 'public' must precede the member type and name

Discussion in 'Scripting' started by Sovereignsmacker, Sep 7, 2022.

  1. Sovereignsmacker

    Sovereignsmacker

    Joined:
    Aug 31, 2022
    Posts:
    1
    (6,1): error CS1585: Member modifier 'public' must precede the member type and name is happening and Im not sure why but I am a beginner here is the code:

    using System.Collections;
    using System.Collections.Generic;
    using UnityEngine;

    public class playermovement{monoBehaviour
    public float speed = 5f;

    public float jumpSpeed = 3f;
    private float direction = 0f;
    private Rigidbody2D player;

    public Transform groundCheck;
    public float groundCheckRadius;
    public LayerMask groundLayer;
    private bool isTouchingGround;
    // Start is called before the first frame update
    void Start()
    {
    player = GetComponent<Rigidbody2D>();
    }

    // Update is called once per frame
    void Update()
    {
    isTouchingGround = Physics2D.OverlapCircle(groundCheck.position, groundCheckRadius, groundLayer);
    direction = Input.GetAxis("Horizontal");

    if (direction > 0f)
    {
    player.velocity = new Vector2(direction * speed, player.velocity.y);
    }
    else if (direction < 0f)
    {
    player.velocity = new Vector2(direction * speed, player.velocity.y);
    }
    else
    {
    player.velocity = new Vector2(0, player.velocity.y);
    }

    if (Input.GetButtonDown("Jump") && isTouchingGround)
    {
    player.velocity = new Vector2(player.velocity.x, jumpSpeed);
    }
    } }
     
  2. CodeSmile

    CodeSmile

    Joined:
    Apr 10, 2014
    Posts:
    6,005
    I think you accidentally removed the colon in here:

    Code (CSharp):
    1. public class playermovement{monoBehaviour
    Should probably be more like this (note the uppercase: MonoBehaviour):

    Code (CSharp):
    1. public class playermovement : MonoBehaviour
    2. {
    3.   // rest of the code here
    4.  
     
    MelvMay and Bunny83 like this.
  3. MelvMay

    MelvMay

    Unity Technologies

    Joined:
    May 24, 2013
    Posts:
    11,500
    Please edit your post to use code-tags. Plain-text isn't useful as it doesn't contain line numbers which errors refer to.

    I've moved your post to the scripting forum. The code-editors forum is about the IDEs, not scripting.

    Thanks.
     
    Bunny83 likes this.
  4. Kurt-Dekker

    Kurt-Dekker

    Joined:
    Mar 16, 2013
    Posts:
    38,751
    Great! Welcome.

    All the problems I see above are just typing mistakes on your part.

    Now is the time you need to increase your typing accuracy to 100%, no exceptions.

    Tutorials and example code are great, but keep this in mind to maximize your success and minimize your frustration:

    How to do tutorials properly, two (2) simple steps to success:

    Step 1. Follow the tutorial and do every single step of the tutorial 100% precisely the way it is shown. Even the slightest deviation (even a single character!) generally ends in disaster. That's how software engineering works. Every step must be taken, every single letter must be spelled, capitalized, punctuated and spaced (or not spaced) properly, literally NOTHING can be omitted or skipped.

    Fortunately this is the easiest part to get right: Be a robot. Don't make any mistakes.
    BE PERFECT IN EVERYTHING YOU DO HERE!!


    If you get any errors, learn how to read the error code and fix your error. Google is your friend here. Do NOT continue until you fix your error. Your error will probably be somewhere near the parenthesis numbers (line and character position) in the file. It is almost CERTAINLY your typo causing the error, so look again and fix it.

    Step 2. Go back and work through every part of the tutorial again, and this time explain it to your doggie. See how I am doing that in my avatar picture? If you have no dog, explain it to your house plant. If you are unable to explain any part of it, STOP. DO NOT PROCEED. Now go learn how that part works. Read the documentation on the functions involved. Go back to the tutorial and try to figure out WHY they did that. This is the part that takes a LOT of time when you are new. It might take days or weeks to work through a single 5-minute tutorial. Stick with it. You will learn.

    Step 2 is the part everybody seems to miss. Without Step 2 you are simply a code-typing monkey and outside of the specific tutorial you did, you will be completely lost. If you want to learn, you MUST do Step 2.

    Of course, all this presupposes no errors in the tutorial. For certain tutorial makers (like Unity, Brackeys, Imphenzia, Sebastian Lague) this is usually the case. For some other less-well-known content creators, this is less true. Read the comments on the video: did anyone have issues like you did? If there's an error, you will NEVER be the first guy to find it.

    Beyond that, Step 3, 4, 5 and 6 become easy because you already understand!

    Finally, when you have errors...

    Remember: NOBODY here memorizes error codes. That's not a thing. The error code is absolutely the least useful part of the error. It serves no purpose at all. Forget the error code. Put it out of your mind.

    The complete error message contains everything you need to know to fix the error yourself.

    The important parts of the error message are:

    - the description of the error itself (google this; you are NEVER the first one!)
    - the file it occurred in (critical!)
    - the line number and character position (the two numbers in parentheses)
    - also possibly useful is the stack trace (all the lines of text in the lower console window)

    Always start with the FIRST error in the console window, as sometimes that error causes or compounds some or all of the subsequent errors. Often the error will be immediately prior to the indicated line, so make sure to check there as well.

    All of that information is in the actual error message and you must pay attention to it. Learn how to identify it instantly so you don't have to stop your progress and fiddle around with the forum.