Search Unity

  1. Welcome to the Unity Forums! Please take the time to read our Code of Conduct to familiarize yourself with the forum rules and how to post constructively.
  2. Dismiss Notice

Member modifier 'public' must precede the member. Error please help

Discussion in 'Scripting' started by OsRaMoSaO, Jan 21, 2022.

  1. OsRaMoSaO

    OsRaMoSaO

    Joined:
    May 15, 2020
    Posts:
    9
    So I've benn following a course for quite som time and have gotten this error now. I have sat an entire day troubbleshooting but to no help. Full error code:
    Assets\Scripts\GameManager.cs(16,5): error CS1585: Member modifier 'public' must precede the member type and name

    The issue is in the public game manager instance.


    Code (CSharp):
    1. using System.Collections;
    2. using System.Collections.Generic;
    3. using UnityEngine;
    4. using TMPro;
    5.  
    6. public class GameManager : MonoBehaviour
    7. {
    8.     public int gold;
    9.    
    10.     public TextMeshProUGUI GoldText;
    11.  
    12.     public Sprite[] backgrounds;
    13.     private int
    14.  
    15.    
    16.     public static GameManager instance;
    17.  
    18.     void Awake()
    19.     {
    20.         instance = this;
    21.     }
    22.  
    23.     public void AddGold(int amount)
    24.     {
    25.        
    26.  
    27.         gold += amount;
    28.         GoldText.text = "Gold: " + gold.ToString();
    29.     }
    30. }
    31.  
     
  2. exiguous

    exiguous

    Joined:
    Nov 21, 2010
    Posts:
    1,749
    private int
    public static GameManager instance;

    The compiler removes spaces, linebreakes, tabs and so on. So it "reads" private int public static GameManager instance; And this certainly makes no sense. If you sit a day on that "simple" syntactic problem you should learn proper C#.
     
    OsRaMoSaO, Bunny83 and Kurt-Dekker like this.
  3. Putcho

    Putcho

    Joined:
    Jun 1, 2013
    Posts:
    246


    did you see anything that different than other? like doesn't have a name or end with ";"
     
  4. OsRaMoSaO

    OsRaMoSaO

    Joined:
    May 15, 2020
    Posts:
    9
    I fixed the problem, it was the private int. Thanks for taking time to help!
     
    Last edited: Jan 21, 2022
  5. OsRaMoSaO

    OsRaMoSaO

    Joined:
    May 15, 2020
    Posts:
    9
    I'm just learning c#. Thanks alot tho. I dont know how i didnt notice that private int, sorry. Also thanks for the c# book it will for sure come in handy!
     
  6. Kurt-Dekker

    Kurt-Dekker

    Joined:
    Mar 16, 2013
    Posts:
    36,756
    This will save you some time if you're hammering in random code:

    Tutorials and example code are great, but keep this in mind to maximize your success and minimize your frustration:

    How to do tutorials properly, two (2) simple steps to success:

    Tutorials are a GREAT idea. Tutorials should be used this way:

    Step 1. Follow the tutorial and do every single step of the tutorial 100% precisely the way it is shown. Even the slightest deviation (even a single character!) generally ends in disaster. That's how software engineering works. Every step must be taken, every single letter must be spelled, capitalized, punctuated and spaced (or not spaced) properly, literally NOTHING can be omitted or skipped.

    Fortunately this is the easiest part to get right: Be a robot. Don't make any mistakes.
    BE PERFECT IN EVERYTHING YOU DO HERE!!


    If you get any errors, learn how to read the error code and fix your error. Google is your friend here. Do NOT continue until you fix your error. Your error will probably be somewhere near the parenthesis numbers (line and character position) in the file. It is almost CERTAINLY your typo causing the error, so look again and fix it.

    Step 2. Go back and work through every part of the tutorial again, and this time explain it to your doggie. See how I am doing that in my avatar picture? If you have no dog, explain it to your house plant. If you are unable to explain any part of it, STOP. DO NOT PROCEED. Now go learn how that part works. Read the documentation on the functions involved. Go back to the tutorial and try to figure out WHY they did that. This is the part that takes a LOT of time when you are new. It might take days or weeks to work through a single 5-minute tutorial. Stick with it. You will learn.

    Step 2 is the part everybody seems to miss. Without Step 2 you are simply a code-typing monkey and outside of the specific tutorial you did, you will be completely lost. If you want to learn, you MUST do Step 2.

    Of course, all this presupposes no errors in the tutorial. For certain tutorial makers (like Unity, Brackeys, Imphenzia, Sebastian Lague) this is usually the case. For some other less-well-known content creators, this is less true. Read the comments on the video: did anyone have issues like you did? If there's an error, you will NEVER be the first guy to find it.

    Beyond that, Step 3, 4, 5 and 6 become easy because you already understand!

    Finally, when you have errors...

    The complete error message contains everything you need to know to fix the error yourself.

    The important parts of the error message are:

    - the description of the error itself (google this; you are NEVER the first one!)
    - the file it occurred in (critical!)
    - the line number and character position (the two numbers in parentheses)
    - also possibly useful is the stack trace (all the lines of text in the lower console window)

    Always start with the FIRST error in the console window, as sometimes that error causes or compounds some or all of the subsequent errors. Often the error will be immediately prior to the indicated line, so make sure to check there as well.

    All of that information is in the actual error message and you must pay attention to it. Learn how to identify it instantly so you don't have to stop your progress and fiddle around with the forum.

    Remember: NOBODY here memorizes error codes. That's not a thing. The error code is absolutely the least useful part of the error. It serves no purpose at all. Forget the error code. Put it out of your mind.
     
    OsRaMoSaO likes this.