Mathf Clamp doesn't clamp!

Hi to all,
Someone can explain me why in this script, when the object go to -1 and 1 the object doesn't stops? It should be stop due to mathf.clamp! thank you!

Code (CSharp):

1. var move : float = 0.1;
2. var translation : float;
3. var pos = transform.position;
4.  
5.  
6. function Start () {
7. transform.position = pos;
8. }
9. function Update () {
10. if(Input.GetKey(KeyCode.A)) {
11. translation = Time.deltaTime * move;
12. transform.position += transform.up * translation;
13. pos.x =  Mathf.Clamp(transform.position.x, -1f, 1f);
14. }
15. }

 

Well... maybe if you were doing something with that pos variable...

By the way, Vector are not a class, but a struct. When you do "pos = transform.position", you create a copy of the original, so modifying "pos" won't affect "transform.position".

 

Ah.. and what can I associate with the "pos"?

 

The var translation?

translation.x = Mathf.Clamp(transform.position.x, -1f, 1f);

 

Code (csharp):

1. transform.position = pos

 

You said that i can't use "transform.position = pos" o.o

 

He said you can't use pos = transform.position.
In short words,

Code (CSharp):

1. pos = transform.position

pos in this case stores the coordinates of the gameobject.

Code (CSharp):

1. transform.position = pos

moves the gameobject to pos coordinates.

 

But if i don't declare the var pos, the unity editor says ther's an error.
in this case i put that line over the mathf function, but unity don't recognize the "pos".

Code (CSharp):

1. translation = Time.deltaTime * move;
2. transform.position += transform.up * translation;
3. transform.position = pos;
4. pos.x =  Mathf.Clamp(transform.position.x, -1f, 1f);

 

you have to clamp pos before you assign the gameobject position, that's why Unity is giving you an error and it doesn't work.

 

but how declare pos?

Oh finally works, i have declared the "var pos : Vector3" at the start, and works fine. the last problem is when i press play, the object change its position just a little, and then works well... why?

 

Need more info

 

Sure, when i press 'A' the object with the script, moves a little, and then works perfectly.
if you have not seen, this is the script:

Code (JavaScript):

1. var move : float = 0.1;
2. var translation : float;
3. var pos : Vector3;
4.  
5.  
6. function Start () {
7.  
8. }
9. function Update () {
10. if(Input.GetKey(KeyCode.A)) {
11. transform.position = pos;
12. pos.x =  Mathf.Clamp(transform.position.x, -1f, 1f);
13. translation = Time.deltaTime * move;
14. transform.position += transform.up * translation;
15.  
16. }
17. if(Input.GetKey(KeyCode.S)) {
18. transform.position = pos;
19. pos.x =  Mathf.Clamp(transform.position.x, -1f, 1f);
20. translation = Time.deltaTime * move;
21. transform.position -= transform.up * translation;
22.  
23. }
24. }

 

When you press A for the first time pos has no value but you are telling the object to move to pos.
It's like calling a friend and telling him to go to null, which doesn't exist.
You have to invert transform.position and pos.x, like this

Code (JavaScript):

1. var move : float = 0.1;
2. var translation : float;
3. var pos : Vector3;
4.  
5. function Start () {
6.  
7. }
8. function Update () {
9.     if(Input.GetKey(KeyCode.A)) {
10.         pos.x =  Mathf.Clamp(transform.position.x, -1f, 1f);
11.         transform.position = pos;
12.         translation = Time.deltaTime * move;
13.         transform.position += transform.up * translation;
14.     }
15.        
16.     if(Input.GetKey(KeyCode.S)) {
17.         pos.x =  Mathf.Clamp(transform.position.x, -1f, 1f);
18.         transform.position = pos;
19.         translation = Time.deltaTime * move;
20.         transform.position -= transform.up * translation;
21.     }
22. }

Also you should use tabs and blocks of code, it's way easier to read this way

 

Unfortunately as you said, is worse.. xD

 

I also tried to set the start position, but is the same problem

function Start () {
transform.position = new Vector3(0.2,-0.3,0.5);
}

 

The original position is:
x: 0.2870008 y: -0.3853648 z: 0.5806122

after i press A, the position becomes:
x: 0.06956992 y: 0.150347 z: 0

why?? o.o

 

You only use new in C#.