Search Unity

  1. Unity support for visionOS is now available. Learn more in our blog post.
    Dismiss Notice

Feedback Mark everything protected rather than private in source!

Discussion in 'UGUI & TextMesh Pro' started by andyz, Jun 25, 2019.

  1. andyz

    andyz

    Joined:
    Jan 5, 2010
    Posts:
    2,225
    This has been mentioned before I think, but also applies to TMP versions of Unity UI code.
    It is often difficult to extend UI classes with custom features due to the number of private variables and functions or non-virtual functions.
    Allowing almost everything to be visible (protected not private, virtual) by a class that inherits may break some code rules (?) but allows for full customisation when wanted.
    i.e. lets you customise drop down items - AddItem(...) is private in TMP_Dropdown - although CreateItem is virtual so half way ok
     
    trolling-char likes this.
  2. trolling-char

    trolling-char

    Joined:
    May 12, 2019
    Posts:
    6
    As a workaround, you can modify downloaded source code of the package. On linux, it's in ~/.config/unity3d/cache/packages/packages.unity.com/ I don't know where are they on other OS, but I think it can be found using search and typing "packages.unity.com".
     
    Last edited: Jun 27, 2019
  3. andyz

    andyz

    Joined:
    Jan 5, 2010
    Posts:
    2,225
    Yes this is true. Full source being provided is good
     
  4. Gladyon

    Gladyon

    Joined:
    Sep 10, 2015
    Posts:
    389
    I agree that would be cool not to have any 'private' keyword and to have every property and method 'virtual'.
    And the issue is even broader than that, in the games we create we should also avoid using private and make everything virtual when we intend the game to be moddable.

    Unfortunately, I guess that habits aren't that easy to lose (especially since these habits are usually very good ones).