Search Unity

  1. Welcome to the Unity Forums! Please take the time to read our Code of Conduct to familiarize yourself with the forum rules and how to post constructively.
  2. We have updated the language to the Editor Terms based on feedback from our employees and community. Learn more.
    Dismiss Notice
  3. Join us on November 16th, 2023, between 1 pm and 9 pm CET for Ask the Experts Online on Discord and on Unity Discussions.
    Dismiss Notice
  4. Unite 2023 Registrations are now LIVE! We are thrilled to announce that Unite 2023 Registration is now live and open for all!
    Dismiss Notice
New Forum User Notice Update to the Unity Editor Software Terms Unite 2023 - Ask the Experts Online Unite 2023 Registrations are now LIVE!

Bug LocalizeStringEvent.RegisterChangeHandler() always overwrites StringReference.Arguments on 0.11

Discussion in 'Localization Tools' started by tomtanak, Apr 16, 2021.

  1. tomtanak

    tomtanak

    Joined:
    Mar 24, 2020
    Posts:
    30
    When a LocalizedString is set to LocalizeStringEvent.StringReference, its Arguments are always overwritten by LocalizeStringEvent.RegisterChangeHandler() on Localization 0.11 (perhaps since 0.10).
    LocalizeStringEvent.m_FormatArguments is private so that it cannot be set by C# scripts and there seems to be no way to format LocalizeStringEvent.StringReference with arguments passed by scripts.
    Is this an intentional change?
     
    tomtanak, Apr 16, 2021
    #1

  2. karl_jones

    karl_jones

    Unity Technologies

    Joined:
    May 5, 2015
    Posts:
    7,846
    Hi,
    No this is a bug. We have already fixed it and it will be in the next release.
     
    karl_jones, Apr 16, 2021
    #2

  3. tomtanak

    tomtanak

    Joined:
    Mar 24, 2020
    Posts:
    30
    Thank you, it's nice to hear that.
    Any plan of a patch release including its fix?
     
    tomtanak, Apr 16, 2021
    #3

  4. karl_jones

    karl_jones

    Unity Technologies

    Joined:
    May 5, 2015
    Posts:
    7,846
    Yeah we have a few fixes we want to land and then will try and push out an earlier patch release.
     
    karl_jones, Apr 16, 2021
    #4

  5. tomtanak

    tomtanak

    Joined:
    Mar 24, 2020
    Posts:
    30
    It's nice to hear again!
    I'm looking forward it.
    Thank you.
     
    tomtanak, Apr 16, 2021
    #5
    karl_jones likes this.

  6. tomtanak

    tomtanak

    Joined:
    Mar 24, 2020
    Posts:
    30
    Hi.
    I updated the localization package to 0.11.1-preivew, but the code in question is still the same.
    Is 0.11.1 the patch release you mentioned above?
    Or are you planning any other patch?
     
    tomtanak, Apr 26, 2021
    #6

  7. karl_jones

    karl_jones

    Unity Technologies

    Joined:
    May 5, 2015
    Posts:
    7,846
    No that fix will be on 0.12.0. The patch 0.11.1 was for a single fix
     
    karl_jones, Apr 26, 2021
    #7

  8. tomtanak

    tomtanak

    Joined:
    Mar 24, 2020
    Posts:
    30
    I understand.
    I'll roll the package back to 0.10.0 to get around the problem.
    Thank you!
     
    tomtanak, Apr 27, 2021
    #8