Little modification in script

Hey, I want to make music player with more then 2 audio sources.
how this script line should be for more then 2 audio sources?

Code (CSharp):

1.     public void PlayMusic(AudioClip musicClip)
2.     {
3.         AudioSource activeSource = (FirstMusicSourceIsPlaying) ? musicSource : musicSource2;
4.         activeSource.clip = musicClip;
5.         activeSource.volume = 1;
6.         activeSource.Play();
7.     }
8.     public void PlayMusicWhiteFade(AudioClip newClip, float transitionTime = 1.0f)
9.     {
10.         AudioSource activeSource = (FirstMusicSourceIsPlaying) ? musicSource : musicSource2;
11.         StartCoroutine(UpdateMusicWithFade(activeSource, newClip, transitionTime));

 

You'd probably have to make an array to keep track of which audio sources are playing and find one that isn't? I'm not sure how you keep track of "FirstMusicSourceIsPlaying" in the existing script. I'm also not sure what the actual desired behavior is here.

 

That's probably not the best idea I would suggest that you use an array of Audio Clips and one AudioSource then whenever you need AudioClip[2] you can set the clip of your AudioSource to that AudioClip

 

I just donr know how to handle with this line:

AudioSource activeSource = (FirstMusicSourceIsPlaying) ? musicSource : musicSource2;

means if the first audio is playing, the second isn't and its working very well. but if I want to add third or fourth audio, how this line should looks like?

 

I'm not sure what advantage manually managing multiple sources is giving you over having a single source but something like the below should work. You'd first need to declare a list of audio sources, either populated in the editor or on Awake:

Code (CSharp):

1. [SerializeField] private List<AudioSource> audioSources;

Then in your PlayMusic method you could set your audio source as follows:

Code (CSharp):

1. AudioSource activeSource;
2.  
3. for (int i = 0; i < audioSources.Count; i++)
4. {
5.     if (audioSources[i].isPlaying)
6.     {
7.         activeSource = audioSources[i];
8.         break;
9.     }
10. }
11.  
12. // If no sources are playing default to first in list
13. if (activeSource == null)
14. {
15.     activeSource = audioSources[0];
16. }

 

I tried but there is still little problem and its not working. I made 2 scripts, one for the audio manager and one for the list of songs. I want to use the keyboard to switch between songs (like press "1" for song #1, "2" for song #2...) sill cant figure what is the problem.

The audio Manager:

Code (CSharp):

1. using System.Collections;
2. using System.Collections.Generic;
3. using UnityEngine;
4.  
5. public class AudioManager : MonoBehaviour
6. {
7.     #region Static Instance
8.     private static AudioManager instance;
9.     AudioSource activeSource;
10.     public static AudioManager Instance
11.     {
12.         get
13.         {
14.             if (instance == null)
15.             {
16.                 instance = FindObjectOfType<AudioManager>();
17.                 if (instance == null)
18.                 {
19.                     instance = new GameObject("Spawned AudioManager", typeof(AudioManager)).GetComponent<AudioManager>();
20.                 }
21.             }
22.  
23.             return instance;
24.         }
25.         private set
26.         {
27.             instance = value;
28.         }
29.     }
30.     #endregion
31.  
32.     #region Fields
33.  
34.     [SerializeField] private List<AudioSource> audioSources;
35.  
36.     private bool FirstMusicSourceIsPlaying;
37.     #endregion
38.  
39.     private void Awake()
40.     {
41.         DontDestroyOnLoad(this.gameObject);
42.  
43.     }
44.  
45.     public void PlayMusic(AudioClip musicClip)
46.     {
47.         for (int i = 0; i < audioSources.Count; i++)
48.         {
49.             if (audioSources[i].isPlaying)
50.             {
51.                 activeSource = audioSources[i];
52.                 break;
53.             }
54.         }
55.         if (activeSource == null)
56.         {
57.             activeSource = audioSources[0];
58.         }
59.     }
60.     public void PlayMusicWhiteFade(AudioClip newClip, float transitionTime = 1.0f)
61.     {
62.         for (int i = 0; i < audioSources.Count; i++)
63.         {
64.             if (audioSources[i].isPlaying)
65.             {
66.                 activeSource = audioSources[i];
67.                 break;
68.             }
69.         }
70.         if (activeSource == null)
71.         {
72.             activeSource = audioSources[0];
73.         }
74.  
75.     }
76.    
77.     private IEnumerator UpdateMusicWithFade(AudioSource activeSource, AudioClip newClip, float transitionTime)
78.     {
79.         if (!activeSource.isPlaying)
80.             activeSource.Play();
81.  
82.         float t = 0.0f;
83.  
84.         for (t = 0; t < transitionTime; t += Time.deltaTime)
85.         {
86.             activeSource.volume = (1 - (t / transitionTime));
87.             yield return null;
88.         }
89.  
90.         activeSource.Stop();
91.         activeSource.clip = newClip;
92.         activeSource.Play();
93.  
94.         for (t = 0; t < transitionTime; t += Time.deltaTime)
95.         {
96.             activeSource.volume = (t / transitionTime);
97.             yield return null;
98.         }
99.  
100.     }
101.  
102. }
103.  

The song list:

Code (CSharp):

1. using System.Collections;
2. using System.Collections.Generic;
3. using UnityEngine;
4.  
5. public class AudioManagerTest : MonoBehaviour
6. {
7.     [SerializeField] private List<AudioSource> activeSource;
8.  
9.     // Update is called once per frame
10.     void Update()
11.     {
12.         if (Input.GetKeyDown(KeyCode.Alpha1))
13.             AudioManager.Instance.PlayMusicWhiteFade(audioSources);
14.  
15.     }
16. }

its says: the name audioSource does not exist in the current context, and if there is no error, it still doesn't do nothing.

 

You need to declare the activeSource variable before the for loop, it's the first line in the code on my last post. The code handles getting the active source it doesn't play anything.

As it's being called in multiple places you'd be better off turning it into its own method so you only have to make changes in one place:

Code (CSharp):

1. private AudioSource GetActiveSource()
2. {
3.     AudioSource activeSource;
4.     for (int i = 0; i < audioSources.Count; i++)
5.     {
6.         if (audioSources[i].isPlaying)
7.         {
8.             activeSource = audioSources[i];
9.             break;
10.         }
11.     }
12.     // If no sources are playing default to first in list
13.     if (activeSource == null)
14.     {
15.         activeSource = audioSources[0];
16.     }
17.  
18.     return activeSource;
19. }

Combining this with the code in your original post your two play methods would then look like this:

Code (CSharp):

1.  public void PlayMusic(AudioClip musicClip)
2.     {
3.         AudioSource activeSource = GetActiveSource();
4.         activeSource.clip = musicClip;
5.         activeSource.volume = 1;
6.         activeSource.Play();
7.     }
8.     public void PlayMusicWhiteFade(AudioClip newClip, float transitionTime = 1.0f)
9.     {
10.         AudioSource activeSource = GetActiveSource();
11.         StartCoroutine(UpdateMusicWithFade(activeSource, newClip, transitionTime));

 

I've also just noticed in AudioManagerTest class you're trying to pass a list of audio sources to the PlayMusicWithFade method. This won't work as that method expects an audio clip. From the description of what you want this to do you'll need to change the AudioManagerTest class to something like the following:

Code (CSharp):

1. using System.Collections;
2. using System.Collections.Generic;
3. using UnityEngine;
4. public class AudioManagerTest : MonoBehaviour
5. {
6.     [SerializeField] private List<AudioClip> audioClips;
7.  
8.     // Update is called once per frame
9.     void Update()
10.     {
11.         if (Input.GetKeyDown(KeyCode.Alpha1))
12.         {
13.             AudioManager.Instance.PlayMusicWhiteFade(audioClips[0]);
14.         }
15.  
16.         if (Input.GetKeyDown(KeyCode.Alpha2))
17.         {
18.             AudioManager.Instance.PlayMusicWhiteFade(audioClips[1]);
19.         }
20.     }
21. }

 

Thanks for your help. there is still little problem with the 2 scripts:

the audio manager looks like this and there is no error:

Code (CSharp):

1. using System.Collections;
2. using System.Collections.Generic;
3. using UnityEngine;
4.  
5. public class AudioManager : MonoBehaviour
6. {
7.     #region Static Instance
8.     private static AudioManager instance;
9.     public static AudioManager Instance
10.     {
11.         get
12.         {
13.             if (instance == null)
14.             {
15.                 instance = FindObjectOfType<AudioManager>();
16.                 if (instance == null)
17.                 {
18.                     instance = new GameObject("Spawned AudioManager", typeof(AudioManager)).GetComponent<AudioManager>();
19.                 }
20.             }
21.  
22.             return instance;
23.         }
24.         private set
25.         {
26.             instance = value;
27.         }
28.     }
29.     #endregion
30.  
31.     #region Fields
32.     [SerializeField] private List<AudioSource> audioClips;
33.     private AudioSource musicSource;
34.  
35.     #endregion
36.  
37.     private void Awake()
38.     {
39.         DontDestroyOnLoad(this.gameObject);
40.         musicSource = this.gameObject.AddComponent<AudioSource>();
41.         musicSource.loop = true;
42.  
43.     }
44.  
45.     private AudioSource GetActiveSource()
46.     {
47.         AudioSource activeSource = (musicSource);
48.         for (int i = 0; i < audioClips.Count; i++)
49.         {
50.             if (audioClips[i].isPlaying)
51.             {
52.                 activeSource = audioClips[i];
53.                 break;
54.             }
55.         }
56.         if (activeSource == null)
57.         {
58.             activeSource = audioClips[0];
59.         }
60.         return activeSource;
61.     }
62.  
63.     public void PlayMusic(AudioClip musicClip)
64.     {
65.  
66.         AudioSource activeSource = GetActiveSource();
67.         activeSource.clip = musicClip;
68.         activeSource.volume = 1;
69.         activeSource.Play();
70.     }
71.  
72.     public void PlayMusicWhiteFade(AudioClip newClip, float transitionTime = 1.0f)
73.     {
74.         AudioSource activeSource = GetActiveSource();
75.         StartCoroutine(UpdateMusicWithFade(activeSource, newClip, transitionTime));
76.  
77.     }
78.     private IEnumerator UpdateMusicWithFade(AudioSource activeSource, AudioClip newClip, float transitionTime)
79.     {
80.         if (!activeSource.isPlaying)
81.             activeSource.Play();
82.  
83.         float t = 0.0f;
84.  
85.         for (t = 0; t < transitionTime; t += Time.deltaTime)
86.         {
87.             activeSource.volume = (1 - (t / transitionTime));
88.             yield return null;
89.         }
90.  
91.         activeSource.Stop();
92.         activeSource.clip = newClip;
93.         activeSource.Play();
94.  
95.         for (t = 0; t < transitionTime; t += Time.deltaTime)
96.         {
97.             activeSource.volume = (t / transitionTime);
98.             yield return null;
99.         }
100.  
101.     }
102.  
103. }

The audio manager test look like this and there are two problems
1. with the [ ]- its says "cannot apply indexing with [] to an expression of type 'audioclip'
2. it dosnt make any list in the game to put songs to it, there is only one box to put "Audio Clips" inside

Code (CSharp):

1. using System.Collections;
2. using System.Collections.Generic;
3. using UnityEngine;
4.  
5. public class AudioManagerTest : MonoBehaviour
6. {
7.     [SerializeField] private AudioClip audioClips;
8.    
9.  
10.     // Update is called once per frame
11.     void Update()
12.     {
13.         if (Input.GetKeyDown(KeyCode.Alpha1))
14.         {
15.             AudioManager.Instance.PlayMusicWhiteFade(audioClips[0]);
16.         }
17.         if (Input.GetKeyDown(KeyCode.Alpha2))
18.         {
19.             AudioManager.Instance.PlayMusicWhiteFade(audioClips[1]);
20.         }
21.     }
22.  
23.    
24. }

 

No problem! The 2 issues are caused by the same thing. You need to change:

Code (CSharp):

1. [SerializeField] private AudioClip audioClips;

to:

Code (CSharp):

1. [SerializeField] private List<AudioClip> audioClips;

You'll need to add a check to make sure the list is initialised and that there is a clip at that index in the list but I left that out for clarity.

 

Ok so my 2 scripts look like this:

the audio manager:

Code (CSharp):

1. using System.Collections;
2. using System.Collections.Generic;
3. using UnityEngine;
4.  
5. public class AudioManager : MonoBehaviour
6. {
7.     #region Static Instance
8.     private static AudioManager instance;
9.     public static AudioManager Instance
10.     {
11.         get
12.         {
13.             if (instance == null)
14.             {
15.                 instance = FindObjectOfType<AudioManager>();
16.                 if (instance == null)
17.                 {
18.                     instance = new GameObject("Spawned AudioManager", typeof(AudioManager)).GetComponent<AudioManager>();
19.                 }
20.             }
21.  
22.             return instance;
23.         }
24.         private set
25.         {
26.             instance = value;
27.         }
28.     }
29.     #endregion
30.  
31.     #region Fields
32.     [SerializeField] private List<AudioSource> audioClips;
33.     private AudioSource musicSource;
34.  
35.     #endregion
36.  
37.     private void Awake()
38.     {
39.         DontDestroyOnLoad(this.gameObject);
40.         musicSource = this.gameObject.AddComponent<AudioSource>();
41.         musicSource.loop = true;
42.  
43.     }
44.  
45.     private AudioSource GetActiveSource()
46.     {
47.         AudioSource activeSource = (musicSource);
48.         for (int i = 0; i < audioClips.Count; i++)
49.         {
50.             if (audioClips[i].isPlaying)
51.             {
52.                 activeSource = audioClips[i];
53.                 break;
54.             }
55.         }
56.         if (activeSource == null)
57.         {
58.             activeSource = audioClips[0];
59.         }
60.         return activeSource;
61.     }
62.  
63.     public void PlayMusic(AudioClip musicClip)
64.     {
65.  
66.         AudioSource activeSource = GetActiveSource();
67.         activeSource.clip = musicClip;
68.         activeSource.volume = 1;
69.         activeSource.Play();
70.     }
71.  
72.     public void PlayMusicWhiteFade(AudioClip newClip, float transitionTime = 1.0f)
73.     {
74.         AudioSource activeSource = GetActiveSource();
75.         StartCoroutine(UpdateMusicWithFade(activeSource, newClip, transitionTime));
76.  
77.     }
78.     private IEnumerator UpdateMusicWithFade(AudioSource activeSource, AudioClip newClip, float transitionTime)
79.     {
80.         if (!activeSource.isPlaying)
81.             activeSource.Play();
82.  
83.         float t = 0.0f;
84.  
85.         for (t = 0; t < transitionTime; t += Time.deltaTime)
86.         {
87.             activeSource.volume = (1 - (t / transitionTime));
88.             yield return null;
89.         }
90.  
91.         activeSource.Stop();
92.         activeSource.clip = newClip;
93.         activeSource.Play();
94.  
95.         for (t = 0; t < transitionTime; t += Time.deltaTime)
96.         {
97.             activeSource.volume = (t / transitionTime);
98.             yield return null;
99.         }
100.  
101.     }
102.  
103. and the audiomanagertest:
104.  
105. [code=CSharp]using System.Collections;
106. using System.Collections.Generic;
107. using UnityEngine;
108.  
109. public class AudioManagerTest : MonoBehaviour
110. {
111.  
112.     [SerializeField] private List<AudioClip> audioClips;
113.  
114.     // Update is called once per frame
115.     void Update()
116.     {
117.         if (Input.GetKeyDown(KeyCode.Alpha1))
118.         {
119.             AudioManager.Instance.PlayMusicWhiteFade(audioClips[0]);
120.         }
121.         if (Input.GetKeyDown(KeyCode.Alpha2))
122.         {
123.             AudioManager.Instance.PlayMusicWhiteFade(audioClips[1]);
124.         }
125.     }
126.  
127.    
128. }

}[/code]

I choose 2 elements to try but it doesn't respond..there is no error but also no music. it gives me this warning:


Assets\AudioManager.cs(32,48): warning CS0649: Field 'AudioManager.audioClips' is never assigned to, and will always have its default value null