light on/off script help

hi im new to scripting and im trying to make a script so that when mouse is down light is on and when mouse up light is off. i know this is not even close but it is my attempt as im new :

Code (JavaScript):

1. function Update() {
2. if (Input.GetKeyDown("Fire1")) {
3.     if (light.enabled == true)
4.        light.enabled = true;
5.     }
6.  
7. if (Input.GetKeyup("Fire1")) {
8.     if (light.enabled == true)
9.         light.enabled = false;
10.     }
11. }

any help would be great

thanks

 

Well, it looks correctly. But you should have public variable 'light' for assignment.
Add this line in the begining, and drag and drop your light gameobject to this field in the Inspector Panel of editor.

Code (csharp):

1. public var light : GameObject;

 

it came up with "can't add component "light" because it doesnt exist.check that the file name and class match" how do i solve this?

 

You don't need to check if the light object is enabled or not. Just test for the mouse button:

Code (JavaScript):

1.    
2. function Update() {
3.     if (Input.GetKeyDown("Fire1")) {
4.            light.enabled = false;
5.     }
6.    
7.     if (Input.GetKeyup("Fire1")) {
8.             light.enabled = true;
9.     }
10. }
11.  

 

this didnt work man but thanks anyway

 

This method is even better as you don't need to attach it to another gameobject. Attach it to light:

Code (JavaScript):

1. function Update() {
2.     if (Input.GetKeyDown("Fire1")) {
3.            this.GetComponent(Light).enabled = true;
4.     }
5.  
6.     if (Input.GetKeyUp("Fire1")) {
7.             this.GetComponent(Light).enabled = false;
8.     }
9. }

Edit: You also misspelled "GetKeyup" instead of "GetKeyUp". Capitalization is important!

 

GetKeyDown and GetKeyUp are used with specific key names, Fire1 is not a key.
If you want to use the inputs defined in the Input manager you should use GetButtonUp or GetButtonDown