Resolved Light glitching out when changing intensity

For some reason, when I try to change the intensity of the light of the Sun so that it is reduced when night comes, instead of following the script the light keeps rapidly turning on and off, apparently bouncing quickly from the correct value to 0. This is the script and I have no idea what causes this:

Code (CSharp):

1.  
2.                 if (Sun != null)
3.                 {
4.                     Quaternion LookRotation = Quaternion.Euler(new Vector3(InGameTime / SunSpeedDivisor, 0f, 0f));
5.                     //360f multiplied by SunSpeedDivisor is the number of seconds one in-game full day takes//
6.                
7.                     Sun.transform.rotation = Quaternion.Slerp(Sun.transform.rotation, LookRotation, Time.deltaTime * 5f);
8.                     SunLight.intensity = CurrentSunLightIntensity;
9.  
10.                     CurrentSunLightIntensity = SunLightIntensity * Mathf.Sin(InGameTime / SunSpeedDivisor);
11.                 }
12.  

 

This is probably because while Euler angles complete one full rotation in 360f degrees, the function Mathf.Sin completes one full rotation in tau (2 pi) radians, which is about 6.28f.

To solve this, you will want to convert the result of InGameTime / SunSpeedDivisor from degrees to radians first. Using Deg2Rad.

 

Isn't light a physical phenomenon? I study light in physics class not art class lol.

 

Yeah I thought about this but I was sure I read somewhere that Mathf.Sin returned in degrees... Until now that I just read the documentation of it (https://docs.unity3d.com/ScriptReference/Mathf.Sin.html) and realised it's not...

I guess I was just crazy, let me fix that and see if it gets better.

 

Yup, that fixed it! Works perfectly now, thanks for the help.