Search Unity

Feedback Let's stick to the Contribution Guidelines

Discussion in 'Open Projects' started by GhAyoub, Oct 8, 2020.

  1. GhAyoub

    GhAyoub

    Joined:
    Dec 7, 2018
    Posts:
    10
    Hey folks!
    First of all, I want to thank Unity for this awesome initiative and I'm looking forward to contribute as much as I can to this project.
    Since I didn't find any non-assigned task, I wanted to check the project's hiearchy and see if anything is wrong.
    I found that we have a folder called "Tests" which contains an InputTesting Scene and this obviously doesn't go along with the guidelines : Don’t add testing scenes, testing scripts, and in general assets that you should keep to yourself. Use them to test/prototype, and then exclude them when you push.

    I know it's not a big deal for now, but I just wanted to mention this as early as possible so we don't get more of these tests on the main project.

    Keep up the good work!
     
  2. Megatank58

    Megatank58

    Joined:
    Jul 20, 2020
    Posts:
    44
    I made a PR where i removed the test scene safely without any errors the scene as i think was probably for testing and had only a Input scene object with a script that was not there as well for some reason either way here is the PR.

    EDIT: It has been accepted!
     
    Last edited: Oct 8, 2020
    cirocontinisio and GhAyoub like this.
  3. cirocontinisio

    cirocontinisio

    Joined:
    Jun 20, 2016
    Posts:
    884
    Fair point! It was a leftover of the initial setup, and we should have removed it already. I approved the PR.
     
    GhAyoub likes this.
  4. Neonage

    Neonage

    Joined:
    May 22, 2020
    Posts:
    287
    But what about test scenes for more complex systems, like Inventory or StateMachine?
    They're necessary for other people to see how system is working, to test and develop upon them.
     
  5. Megatank58

    Megatank58

    Joined:
    Jul 20, 2020
    Posts:
    44
    They're allowed but test scenes that you've made for your personal testing aren't allowed (as per guidelines)