Search Unity

  1. Welcome to the Unity Forums! Please take the time to read our Code of Conduct to familiarize yourself with the forum rules and how to post constructively.

Resolved LensFlare (SRP) does not work properly in VR and URP

Discussion in 'VR' started by KuanMi, Mar 7, 2022.

  1. KuanMi

    KuanMi

    Joined:
    Feb 25, 2020
    Posts:
    41
    I find the position of the lens flare is wrong in VR and URP.
    In Scene Tab:
    upload_2022-3-7_11-16-22.png
    But in Game Tab or HTC Vive:
    upload_2022-3-7_11-16-39.png
    I tried Single Pass Instanced and Multi Pass but both have the same result
    Is this a bug, or am I setting it wrong?
     

    Attached Files:

    KuanMi, Mar 7, 2022
    #1

  2. mashixuan8

    mashixuan8

    Joined:
    Nov 4, 2014
    Posts:
    22
    it's just bugged and they don't really care about it. I reported this bug like three monthes ago and no one replied me. I guess it will never be fixed.
     
    mashixuan8, Mar 12, 2022
    #2

  3. JamieVRcade

    JamieVRcade

    Joined:
    Oct 21, 2012
    Posts:
    32
    Same. This has been a longstanding problem and I don't know if there is a fix ever coming.
     
    JamieVRcade, Jun 22, 2022
    #3

  4. KuanMi

    KuanMi

    Joined:
    Feb 25, 2020
    Posts:
    41
    I simply made some modifications to adapt to VR by referring to the code of URP, and I will submit the code to github when I finish sorting out the code. Here are some instructions in Chinese.
    https://kuanmi.top/2022/06/27/LensFlare-SRP-in-VR
     
    KuanMi, Jun 27, 2022
    #4
    hippocoder likes this.

  5. hippocoder

    hippocoder

    Digital Ape Moderator

    Joined:
    Apr 11, 2010
    Posts:
    29,723
    Can someone report a bug with case number # please? If you genuinely want it fixed, this is the only way it can be assigned actual developers.

    Looks like a drop in fix for Unity to do. Great work!
     
    hippocoder, Jul 12, 2022
    #5

  6. jukibom

    jukibom

    Joined:
    Aug 31, 2015
    Posts:
    52
    Have just submitted repro in a simple project with a link to this thread, will update with a case number when I get one.
     
    jukibom, Sep 1, 2022
    #6

  7. jukibom

    jukibom

    Joined:
    Aug 31, 2015
    Posts:
    52
    apparently Fixed in: 2022.2.0a17
     
    jukibom, Sep 12, 2022
    #7

  8. DanielSafs

    DanielSafs

    Joined:
    Nov 22, 2016
    Posts:
    11
    I tried 2022.2.0b10 and it does not work, I see duplicate flare, one for each eye. Maybe my camera config is wrong?
     
    DanielSafs, Oct 10, 2022
    #8
    Boodums likes this.

  9. VRLab

    VRLab

    Joined:
    Mar 8, 2015
    Posts:
    1
    Getting a 404 on this link which appears to be exactly what I need.....as I'm getting serious "double vision" flares on Unity 2021.3.1f1 with URP 12.1.6
     
    VRLab, Oct 22, 2022
    #9

  10. DevDunk

    DevDunk

    Joined:
    Feb 13, 2020
    Posts:
    4,552
    DevDunk, Oct 26, 2022
    #10

  11. KuanMi

    KuanMi

    Joined:
    Feb 25, 2020
    Posts:
    41
    @VRLab I don't think modifying the official code is a mature solution, maybe you should wait for the official modification. If you want to reference some code, this is the git repository. MaZhengKe/LensFlareVR (github.com)
     
    KuanMi, Oct 31, 2022
    #11

  12. Kevin-VFX

    Kevin-VFX

    Joined:
    Apr 17, 2016
    Posts:
    54
    Kevin-VFX, Dec 23, 2022
    #12

  13. SirEugen

    SirEugen

    Joined:
    Aug 4, 2020
    Posts:
    4
    Hi.
    As I understand - your fix doesn't work with Occlusion?
     
    SirEugen, Jun 27, 2023
    #13

  14. thep3000

    thep3000

    Unity Technologies

    Joined:
    Aug 9, 2013
    Posts:
    399
    Just seeing this now, going to try to get this fast tracked as you provided ample info showing it's a legit bug. Sorry for long delay.
     
    thep3000, Jun 27, 2023
    #14
    KuanMi and DevDunk like this.

  15. KuanMi

    KuanMi

    Joined:
    Feb 25, 2020
    Posts:
    41
    It's been too long and I've forgotten. But it looks like Unity is going to fix this.
     
    KuanMi, Jun 28, 2023
    #15
    Unifikation likes this.

  16. KuanMi

    KuanMi

    Joined:
    Feb 25, 2020
    Posts:
    41
    In URP, the problem lies in the LensFlareDataDriven function of PostProcessPass, where only the VP matrix of a camera is passed in, without considering that the VP matrix of the left and right eyes in VR should be different.
     
    KuanMi, Jun 28, 2023
    #16

  17. thep3000

    thep3000

    Unity Technologies

    Joined:
    Aug 9, 2013
    Posts:
    399
    There's a fix currently in the merge queue for this. It's been tested with occlusion. Looks like it's been tagged for backport to 2022.3. Not sure how long it will take to get in your hands, but it's on the way.
     
    thep3000, Jun 28, 2023
    #17
    SirEugen, KuanMi and DevDunk like this.

  18. Fe1234

    Fe1234

    Joined:
    Apr 7, 2021
    Posts:
    1
    The lens flares still don't work correctly in vr, im using 2022.3.4f1. how long do we need to wait ? I klnow its low priority because it makes no sense for realistic games but im making a stylized game and lens flares would be an amazing addition to bring over that cinematic feeling.
     
    Fe1234, Aug 28, 2023
    #18

  19. thep3000

    thep3000

    Unity Technologies

    Joined:
    Aug 9, 2013
    Posts:
    399
    It looks like this is still trying to land in 2023.3 .. we have a pretty large suite of rendering regression tests and this feature broke some of them. Looks like it's close to landing again.

    so will still be some time before it makes it to 2022.3.
     
    thep3000, Sep 1, 2023
    #19