Issues with outdated code

Hi! So im pretty new to unity and recently purchased a asset from the store named the "first person adventure" kit. Whenever i load this asset however i get the error stating that the unityengine.application does not contain a definition for "iswebplayer". After some research i learned that apparently this code was meant for games to be built on a older player that unity no longer supports. Can anyone help me figure out what to do?

 

Do you have the code of the asset? You should be able to edit it out and replace it with "#if UNITY_WEBGL" or similar (depending on if you want to keep that part of the code) - if you're not building for web, just remove it

 

You'd comment out any areas of code specific to the old web player, which was removed from Unity.

 

im really sorry guys im new to this. So basically i just put #if UNITY_WEBGL above the outdated code?

 

I've emailed him\her three times in the last three days with no response. I know i am probably annoying them but i DID pay 25 dollars. Am i stuck with the asset if i cant get it fixed and if he doesn't agree to a refund?

 

Last I checked the Asset Store doesn't have a refund system. It sounds like the asset was last updated a couple years ago, and uploaded with a version probably older than 5.4. In the future you should be looking at what version of Unity an asset was uploaded using, and make sure it is not much older than what you're using. This is especially true for code assets, since older model or texture assets normally will work just fine.

All you need to do is comment out any of the web player code in the asset to resolve this problem though. You'll need to understand C# so you don't break the logic of the script, but this is really a trivial task for anyone who codes in C#.

 

public void SaveGame()
{
if (Application.isWebPlayer) return;
CurrentRoom = FindObjectOfType<Room>();
if (CurrentRoom != null)
{
if (locationsStates.ContainsKey(Application.loadedLevelName))
locationsStates[Application.loadedLevelName] = CurrentRoom.SaveState();
else
locationsStates.Add(Application.loadedLevelName, CurrentRoom.SaveState());
}

SaveGameData data = new SaveGameData();
data.itemsId = InventoryController.Instance.items.Select(i => i.idItem).ToArray();
data.notesId = JournalController.Instance.notes.Select(n => n.idNote).ToArray();
data.tasksId = JournalController.Instance.tasks.Select(t => t.idTask).ToArray();
data.completeTasksId = JournalController.Instance.completeTasks.Select(t => t.idTask).ToArray();

data.locationsStates = locationsStates;

data.globalValues = Values;
data.locationName = Application.loadedLevelName;
data.playerPosition = new Vector4Serializer(PlayerController.Instance.transform.position);
data.playerRotation = new Vector4Serializer(PlayerController.Instance.transform.rotation);
data.playerHealth = PlayerController.Instance.Health;
data.equipedWearId = InventoryController.Instance.CurrentDress == null ? "" : InventoryController.Instance.CurrentDress.idItem;

SaveLoadController.SaveGame(data);
}

the red underlined bit is the issue. Im more than happy to go through all the files and correct what i need to correct, i just need assurance on HOW to do so. Thank you guys\girls so much for the help.

 

Change:

Code (csharp):

1. if (Application.isWebPlayer) return;

to:

Code (csharp):

1. //if (Application.isWebPlayer) return;

 

that's it?... I do that everywhere there's an error? Im so sorry i wasted your time if thats all i have to do

 

That is what "comment out" means.

You don't necessarily do that for every error though, because in other cases it can break the script's logic or cause compile errors. For example, if the code was actually written like this:

Code (csharp):

1. if (Application.isWebPlayer)
2. {
3.     CurrentRoom = FindObjectOfType<Room>();
4. }

Just commenting out the line with Application.isWebPlayer in it will cause a compile error because these brackets aren't expected without the "if" statement above them. In this example you'd need to comment out the entire "if" statement, including the brackets and every line within the brackets.

Code (csharp):

1. //if (Application.isWebPlayer)
2. //{
3. //    CurrentRoom = FindObjectOfType<Room>();
4. //}

But if it was like this you'd need to analyze it a bit more:

Code (csharp):

1. if (Application.isWebPlayer)
2. {
3.     CurrentRoom = FindObjectOfType<Room>();
4. }
5. else
6. {
7.     DifferentRoom= FindObjectOfType<Room>();
8. }

So you'd want to comment out everything that is supposed to run if Application.isWebPlayer was true, but leave everything uncommented if it was false, while also removing extra brackets. So you'd do it like this:

Code (csharp):

1. //if (Application.isWebPlayer)
2. //{
3. //    CurrentRoom = FindObjectOfType<Room>();
4. //}
5. //else
6. //{
7.     DifferentRoom= FindObjectOfType<Room>();  //You still want this line to run
8. //}

 

What if other code is dependent on that "if" statement? Should i comment that out too?

 

It really depends. You have to analyze what the code is trying to do and comment out anything that should only run if it were the webplayer, and don't comment out anything that should run if it were not the webplayer. The brackets, especially if the code has a lot of nested loops and if statements, is probably the trickiest part to sort out. I gave some simple examples above.

 

OH MY GOD ITS WORKING YOU SIR ARE ACTUALLY GOD BRINGING DEAD CODE BACK TO LIFE THANK YOU SO MUCH!!

 

Can I use this on my resume? j/k

 

For anybody late to the party, it should have been replaced by:

Code (CSharp):

1. if (Application.platform == RuntimePlatform.WebGLPlayer)
2.     return;