Resolved Issue getting Server to receive Client input when using IInputComponentData and GhostPrefabCreation

Hello,

I have a client ghost entity that "shakes" when it's trying to move but it returns back to the server's ghost entity position of (0,0,0). However, I can move the client ghost by manually changing the input of the server ghost in the inspector.
What could cause this?

I'm not using sub-scenes or baking because they are unsupported on WebGL.
I'm using the Ghost instantiation without Prefabs method provided by @timjohansson here: https://forum.unity.com/threads/creating-ghosts-without-prefabs.1370169/#post-8638827

I have a ghost instantiated on a client and server exactly the same.

• My inputs on the client ghost are being updated
• My inputs on the server ghost are not being updated.

This is my Input component for IInputComponentData

Code (CSharp):

1. [Serializable]
2. [GhostComponent(PrefabType = GhostPrefabType.AllPredicted)]
3. public struct ThirdPersonPlayerInputs : IInputComponentData {
4.     public float2 MoveInput;
5.     public float2 CameraLookInput;
6.     public float CameraZoomInput;
7. }

I am adding the AutoCommandTarget to my ghost(s) too

        em.AddComponentData(e, new AutoCommandTarget { Enabled = true });

My InputSystem runs in GhostInputSystemGroup

Spoiler: InputSystem

Code (CSharp):

1.  
2. [UpdateInGroup(typeof(GhostInputSystemGroup))]
3. public partial class SampleCubeInput : SystemBase {
4.     protected override void OnCreate() {
5.         RequireForUpdate<ThirdPersonPlayerInputs>();
6.         RequireForUpdate<NetworkStreamInGame>();
7.     }
8.  
9.     protected override void OnUpdate() {
10.         bool w = Input.GetKey(KeyCode.W);
11.         bool s = Input.GetKey(KeyCode.S);
12.         bool d = Input.GetKey(KeyCode.D);
13.         bool a = Input.GetKey(KeyCode.A);
14.         bool space = Input.GetKeyDown(KeyCode.Space);
15.         var CameraLookInput = new float2(Input.GetAxis("Mouse X"), Input.GetAxis("Mouse Y"));
16.         var mouseScrollDeltaY = -Input.mouseScrollDelta.y;
17.        
18.        Entities.WithAll<GhostOwnerIsLocal>().ForEach((ref ThirdPersonPlayerInputs inputs) => {
19.             inputs = default;
20.             inputs.MoveInput = new float2();
21.             inputs.MoveInput.y += w ? 1f : 0f;
22.             inputs.MoveInput.y += s ? -1f : 0f;
23.             inputs.MoveInput.x += d ? 1f : 0f;
24.             inputs.MoveInput.x += a ? -1f : 0f;
25.  
26.             inputs.CameraLookInput = CameraLookInput;
27.             inputs.CameraZoomInput = mouseScrollDeltaY;
28.         }).ScheduleParallel();
29.     }
30. }
31.  

My MoveSystem runs in PredictedSimulationSystemGroup

Spoiler: MoveSystem

Code (CSharp):

1. [UpdateInGroup(typeof(PredictedSimulationSystemGroup))]
2. public partial class CubeMovementSystem : SystemBase {
3.  
4.     protected override void OnCreate() {
5.         RequireForUpdate<ThirdPersonPlayerInputs>();
6.     }
7.  
8.     protected override void OnUpdate() {
9.         var movementSpeed = SystemAPI.Time.DeltaTime * 4;
10.         Entities.WithAll<Simulate>().ForEach((ref ThirdPersonPlayerInputs input, ref LocalTransform trans) => {
11.             var moveInput = new float2(input.MoveInput.x, input.MoveInput.y);
12.             moveInput = math.normalizesafe(moveInput) * movementSpeed;
13.             trans.Position += new float3(moveInput.x, 0, moveInput.y);
14.         }).ScheduleParallel();
15.     }
16. }

I have an image of the ghost components

Spoiler: Image of ghost components

using Unity 2022.2.5f1 - Entities/Netcode 1.0.0-pre.15

Is there something that I am missing? Thanks
@CMarastoni

 

Hi, I appreciate your response.

I read that documentation several times as its confusing to me, especially since it's geared towards using authoring components, sub-scenes and baking (can't use them with WebGL )

When I spawn my entity I
- add the AutoCommandTarget (enabled)
- add the GhostOwnerComponent and set it to the NetworkIdComponent.Value
- set the ghost as OwnerPredicted

Doesn't that mean I am using AutoCommandTarget or am I missing something?

The documentation refers to ICommandData for these parts, whereas the code examples and netcode projects don't use it, instead they use IInputComponentData...which means the command data usage is to be handled automatically via code generated systems, isn't it?

By the way, it would be great if the documentation could address, more clearly, how to wire things up when not using authoring components, preferably with code samples that are up to date. And there is no code example actually demonstrating the usage of CommantTargetComponent, it just says:

Again, no ICommandData is being used in any of the netcode entities sample projects.

Thanks

 

First of all I really appreciate your in-depth reply and for bearing with me, but I have to ask you to bear with me still

I am using the GhostPrefabCreation and it's essentially identical to your example code.
But I am confused about the whole PredictedGhostSpawnRequestComponent part.
I am not looking to instantiate anything on the client. I only want a character controller, 1 per player. no bullets or such.

I had my setup working with ICommandData. However we are looking to build a webgl framework, and packages such as the Rival DOTS character controller use IInputComponentData. I don't want to have to rewrite or maintain anything to make it work with ICommandData.

It seems I have "dropped" something that I need to get IInputComponentData to work with GhostPrefabCreation.
Below you will see how I use GhostPrefabCreation and how I create the entities. The method InitializeGhostPrefab() gets called on the client and the server.

Code (CSharp):

1.  
2.     public GameObject Prefab;
3.  
4.     public Entity InitializeGhostPrefab(EntityManager em, string ghostname) {
5.         var e = CreateGhostEntity(em);
6.         em.SetName(e, "MyGhost");
7.        
8.         if(GetViewPrefab() != null) {
9.             var goEntity = em.CreateEntity();
10.             em.AddComponentObject(goEntity, new GhostPresentationGameObjectPrefab { Client = GetViewPrefab() });
11.             em.SetName(goEntity, $"{goEntity}-GameObject");
12.             em.AddComponentData(e, new GhostPresentationGameObjectPrefabReference { Prefab = goEntity });
13.         }
14.  
15.         GhostPrefabCreation.ConvertToGhostPrefab(em, e, new GhostPrefabCreation.Config {
16.             Name = ghostname,
17.             Importance = 10,
18.             SupportedGhostModes = GhostModeMask.All,
19.             DefaultGhostMode = GhostMode.OwnerPredicted,
20.             OptimizationMode = GhostOptimizationMode.Dynamic,
21.             UsePreSerialization = false
22.         });
23.         return e;
24.     }
25.  
26.     public Entity CreateGhostEntity(EntityManager em) {
27.         var e = em.CreateEntity();
28.         em.AddComponent<GhostOwnerComponent>(e);
29.         em.AddComponent<GhostOwnerIsLocal>(e);
30.         em.AddComponentData(e, new AutoCommandTarget { Enabled = true });
31.         em.AddComponent<BasicTag>(e);
32.         em.AddComponentData(e, new LocalTransform {...});
33.         em.AddComponentData(e, new LocalToWorld());
34.         em.AddComponentData(e, new ThirdPersonPlayerInputs());
35.         return e;
36.     }
37.  
38.     public GameObject GetViewPrefab() {
39.         return Prefab;
40.     }

My EnterClientSystem and EnterServerSystem are essentially the same from the examples/netcode projects. I am not sure what else I need to do

 

Awesome, that did the trick!
I look forward to having that be part of the API, if that's the plan

Thank you