Resolved Invalid conditional expression in custom function

I am following https://blogs.unity3d.com/2019/07/31/custom-lighting-in-shader-graph-expanding-your-graphs-in-2019/.

I add the custom function and set it up as shown. With the first method using a string it gives me Invalid condition expression when I hover over the little red folder icon with an exclamation point on it and the console outputs this error:

MissingMethodException: UnityEngine.UIElements.StyleLength UnityEngine.UIElements.ComputedStyle.get_width()

UnityEditor.Experimental.GraphView.IconBadge.ComputeTextSize ()

If I switch it to the hlsl file method it gives the same error above but I get a second error that tells me where it is in the hlsl file. It points the the first { which is for the method declaration, there is no conditional expression defined at that point.

Did something change, or is this a bug?

Using 2020.2.0f1 and URP 10.2.2.

 

I was able to fix it using the solution provided here https://forum.unity.com/threads/sha...om-nodes-and-more-issue.1030321/#post-6687910.

Was a bit of a change, instead of:
#if SHADERGRAPH_PREVIEW
It has to be:
#if defined(SHADERGRAPH_PREVIEW)

 

Thank you for putting the fix here after fixing it. I couldn't figure out what I was doing wrong.

 

Thanks man, was exactly my problem

 

Thank you. I had the same problem and your solution worked on my end

 

awesome ! "PointLights_half" problem. I had some problem with a new shader wokring on old 2020 version, you are my life savior