Search Unity

  1. Welcome to the Unity Forums! Please take the time to read our Code of Conduct to familiarize yourself with the forum rules and how to post constructively.

Image Effects with Single Pass Stereo Rendering for VR

Discussion in '2017.2 Beta' started by Carpet_Head, Oct 11, 2017.

  1. Carpet_Head

    Carpet_Head

    Joined:
    Nov 27, 2014
    Posts:
    249
    There seems to be a long standing issue with image effects and SPSR for VR.

    Everything is working great in 2017.1.1f1

    However after trying out 2017.2.0f2, I am having a lot of issues with them again. SSAO Pro results in a completely black screen, and a Highlighting effect does not work correctly either.

    Were there any breaking changes I should know about that might help me adapt these full screen image effects to work with 2017.2.0f2?
     
    Carpet_Head, Oct 11, 2017
    #1

  2. jimmikaelkael

    jimmikaelkael

    Joined:
    Apr 27, 2015
    Posts:
    771
    I hope you can get an answer...

    Please look at my older post being unanswered: https://forum.unity.com/threads/sup...ndering-in-image-effects.419850/#post-3170818

    This issue still exists: the camera width and height is never consistent with render texture resolution used internally and using command buffers there's sadly no way to figure it out.
    One could force render texture resolution once it is known for each HMD device/SDK used, that's what I'm going to do.

    The worst thing with this issue is that the width of the render texture is severely downscaled, creating the illusion to users that they are getting a huge improvement with SPSR.
    This is non-sense... Single Pass doesn't means an image effect have less pixels to handle compared to Multi Pass.
     
    jimmikaelkael, Oct 11, 2017
    #2

  3. robs_unity

    robs_unity

    Unity Technologies

    Joined:
    Sep 26, 2016
    Posts:
    6
    Actually, in 2017.2 onward, you can fetch the RenderTextureDescriptor from the eye texture manager via XRSettings.eyeTextureDesc. You can then use the resultant descriptor in CommandBuffer.GetTemporaryRT.
     
    Last edited: Oct 12, 2017
    robs_unity, Oct 11, 2017
    #3
    Arkade and jimmikaelkael like this.

  4. robs_unity

    robs_unity

    Unity Technologies

    Joined:
    Sep 26, 2016
    Posts:
    6
    If you had a sample project I could look at, I'll try to get a few cycles to see what's going on. I've been working with the new Post Processing Stack v2 myself, and working on updates, but I haven't taken a look at effects from the Asset Store.

    To respond to your original point, there shouldn't be anything in there breaking bits between 2017.1 and 2017.2, but then, we aren't testing these effects from the Asset Store.
     
    Last edited: Oct 12, 2017
    robs_unity, Oct 11, 2017
    #4

  5. stevenwanhk

    stevenwanhk

    Joined:
    Jul 20, 2016
    Posts:
    113
    I can confirm that putting a post processing profile to a camera without turning on any image effect will still split the screen into two in 2017.1.2f1 with single pass. This does not happen in 2017.1.1p4 or before.
     
    stevenwanhk, Oct 12, 2017
    #5

  6. LeonhardP

    LeonhardP

    Unity Technologies

    Joined:
    Jul 4, 2016
    Posts:
    3,064
    Could you please file a bug report with a minimal reproduction case and reply in here with the case #?
     
    LeonhardP, Oct 12, 2017
    #6

  7. stevenwanhk

    stevenwanhk

    Joined:
    Jul 20, 2016
    Posts:
    113
    (Case #958473)
    When I created the test project, I found that the first time I created a post processing profile (no image effect ticked) and attach it to the camera, it works. But once I ticked any image effect, and even I unticked all of them, the screen split into two forever until I removed the post processing profile from the camera.
     
    stevenwanhk, Oct 12, 2017
    #7
    LeonhardP likes this.