Search Unity

  1. Welcome to the Unity Forums! Please take the time to read our Code of Conduct to familiarize yourself with the forum rules and how to post constructively.
  2. Dismiss Notice

Bug Im having this error: Assets/PipeSpawner.cs(35,109): error CS1003: Syntax error, "," expected

Discussion in 'Scripting' started by Kuinsy, May 21, 2023.

  1. Kuinsy

    Kuinsy

    Joined:
    May 21, 2023
    Posts:
    6
    Code (CSharp):
    1. using System.Collections;
    2. using System.Collections.Generic;
    3. using UnityEngine;
    4.  
    5. public class PipeSpawner : MonoBehaviour
    6. {
    7.     public GameObject pipe;
    8.     public float spawnRate = 4;
    9.     private float timer = 0;
    10.     public float heightOffset = 10;
    11.  
    12.     // Start is called before the first frame update
    13.     void Start()
    14.     {
    15.         spawnPipe();
    16.     }
    17.  
    18.     // Update is called once per frame
    19.     void Update()
    20.     {
    21.         if (timer < spawnRate)
    22.         {
    23.             timer = timer + Time.deltaTime;
    24.         }
    25.         else
    26.         {
    27.             spawnPipe();
    28.             timer = 0;
    29.         }
    30.     }
    31.     void spawnPipe()
    32.     {
    33.             float lowestPoint = transform.position.y - heightOffset;
    34.             float highestPoint = transform.position.y + heightOffset;
    35.             Instantiate(pipe, new Vector3(transform.position.x, Random.Range(lowestPoint, highestPoint), 0) transform.rotation);
    36.     }
    37.  
    38. }
     
  2. Lurking-Ninja

    Lurking-Ninja

    Joined:
    Jan 20, 2015
    Posts:
    9,900
    Well, put that comma in the 35th line. I'm not sure what's the difficulty with this?
     
  3. Kuinsy

    Kuinsy

    Joined:
    May 21, 2023
    Posts:
    6
    What comma? Where? Im sorry im new to programing and im so lost.
     
  4. Lurking-Ninja

    Lurking-Ninja

    Joined:
    Jan 20, 2015
    Posts:
    9,900
    Obviously before the
    transform.rotation
    . You must separate parameters with a coma when you have a function call.
     
  5. Kuinsy

    Kuinsy

    Joined:
    May 21, 2023
    Posts:
    6
    OMG you are right. How did i missed that? Thank you so much bro. I really aprecciate it.
     
  6. Kurt-Dekker

    Kurt-Dekker

    Joined:
    Mar 16, 2013
    Posts:
    36,563
    Slooooooow down and go back to where you are getting all this from. You MUST increase your typing accuracy to 100%.

    Tutorials and example code are great, but keep this in mind to maximize your success and minimize your frustration:

    How to do tutorials properly, two (2) simple steps to success:

    Step 1. Follow the tutorial and do every single step of the tutorial 100% precisely the way it is shown. Even the slightest deviation (even a single character!) generally ends in disaster. That's how software engineering works. Every step must be taken, every single letter must be spelled, capitalized, punctuated and spaced (or not spaced) properly, literally NOTHING can be omitted or skipped.

    Fortunately this is the easiest part to get right: Be a robot. Don't make any mistakes.
    BE PERFECT IN EVERYTHING YOU DO HERE!!


    If you get any errors, learn how to read the error code and fix your error. Google is your friend here. Do NOT continue until you fix your error. Your error will probably be somewhere near the parenthesis numbers (line and character position) in the file. It is almost CERTAINLY your typo causing the error, so look again and fix it.

    Step 2. Go back and work through every part of the tutorial again, and this time explain it to your doggie. See how I am doing that in my avatar picture? If you have no dog, explain it to your house plant. If you are unable to explain any part of it, STOP. DO NOT PROCEED. Now go learn how that part works. Read the documentation on the functions involved. Go back to the tutorial and try to figure out WHY they did that. This is the part that takes a LOT of time when you are new. It might take days or weeks to work through a single 5-minute tutorial. Stick with it. You will learn.

    Step 2 is the part everybody seems to miss. Without Step 2 you are simply a code-typing monkey and outside of the specific tutorial you did, you will be completely lost. If you want to learn, you MUST do Step 2.

    Of course, all this presupposes no errors in the tutorial. For certain tutorial makers (like Unity, Brackeys, Imphenzia, Sebastian Lague) this is usually the case. For some other less-well-known content creators, this is less true. Read the comments on the video: did anyone have issues like you did? If there's an error, you will NEVER be the first guy to find it.

    Beyond that, Step 3, 4, 5 and 6 become easy because you already understand!

    Finally, when you have errors, don't post here... just go fix your errors! Here's how:

    Remember: NOBODY here memorizes error codes. That's not a thing. The error code is absolutely the least useful part of the error. It serves no purpose at all. Forget the error code. Put it out of your mind.

    The complete error message contains everything you need to know to fix the error yourself.

    The important parts of the error message are:

    - the description of the error itself (google this; you are NEVER the first one!)
    - the file it occurred in (critical!)
    - the line number and character position (the two numbers in parentheses)
    - also possibly useful is the stack trace (all the lines of text in the lower console window)

    Always start with the FIRST error in the console window, as sometimes that error causes or compounds some or all of the subsequent errors. Often the error will be immediately prior to the indicated line, so make sure to check there as well.

    Look in the documentation. Every API you attempt to use is probably documented somewhere. Are you using it correctly? Are you spelling it correctly?

    All of that information is in the actual error message and you must pay attention to it. Learn how to identify it instantly so you don't have to stop your progress and fiddle around with the forum.
     
  7. Bunny83

    Bunny83

    Joined:
    Oct 18, 2010
    Posts:
    3,495
    Well, read the error:
    Code (CSharp):
    1. Assets/PipeSpawner.cs(35,109):
    2. //                   /|\ /|\
    3. //                    |   |
    4. //                    |   \__ Column index (x coordinate) in your code
    5. //                    |  
    6. //                    \______ Row index (y coordinate) in your code
    7.  
    So check row 35 and column 109. Note that that compiler don't always know what you did wrong since it can not predict what your intentions are. However a programming language has no room for interpretation. There is only one way to interpret code. The compiler will complain at the first position it detects an issue. The problem may not necessarily be exactly at that position, but whereever it is, the issue is usually in that line or before that line. The compiler reads your code from left to right, top to bottom. There are some errors or warnings that may refer to other code segments (like when you have duplicated a method or field), though such errors are usually rare. In most cases the compiler tells you exactly where the error is. The "where" is actually more important than the actual error message. Since you wrote that code, you are the only one who can make sense of it. If there is a syntactical error, the compiler will complain, however what the actual fix may be is up to you.