if statement question

hey,

I was wondering if "IF statement" had a short way of this doing:

Code (CSharp):

1. if ((playerCurrentPosisition >= 0 && 4 > playerCurrentPosisition) || (playerCurrentPosisition == 11) || (playerCurrentPosisition == 12))

Do if statement have a easy way to do this, for example writting

Code (CSharp):

1. if (playerCurrentPosisition == 0,1,2,4,11,12) {
2.  
3. }

- Thanks

 

Maybe easier to use a switch case

Code (csharp):

1.  
2. switch(playerCurrentPosisition)
3. {
4.    case 0:case 1:case 2:case 4:case 11:case 12:
5.     // Do Something
6.     break;
7.    default:
8.     // Do Something
9.     break;
10. }
11.  

You should probably be holding those numbers in a list though, then you can just ask the list if it contains the number

 

Refractor it into a helper method.

 

Not really. If you are just dealing with ints, you could so something like this (though I wouldn't recommend it):

Code (csharp):

1. if (new int[] {0, 1, 2, 3, 4, 11, 12}.Contains(playerCurrentPosisition))

Long if/switch statements are often a good target for the Strategy Pattern. Take a read through this and see if it applies to your situation.

http://blogs.microsoft.co.il/gilf/2...y-pattern-instead-of-using-switch-statements/

 

Cheers for decent replies

 

use a bitflag:

Code (CSharp):

1. int flags = ( 1 << 0 ) | ( 1 << 1 ) || ( 1 << 2 ) | ( 1 << 3 ) | ( 1 << 4 ) | ( 1 << 11 ) | ( 1 << 12 );
2.  
3. if( ( flags & ( 1 << position ) ) != 0 )
4. {
5.     ...
6. }

(only works if you have fewer than 32 positions)