Feedback IAP 4.6.0 -> Unnecessary usage of nullable operator on nullable types

Hello!

As per the title, can Unity please reconsider (what appears to be) a new trend of using the nullable operator (?) on nullable types.

I see this usage on the two breaking changes introduced in 4.6.0...

Code (CSharp):

1. void OnInitializeFailed(InitializationFailureReason error, string? message);
2. void RestoreTransactions(Action<bool, string?>? callback);

It's a non-standard thing to-do as strings & objects are already nullable types, so the operator is not required.

In-fact specifying the operator will likely cause confusion (and warnings if replicated in client code) for those less experienced with C#

No operators will work in exactly the same manner...

Code (CSharp):

1. void OnInitializeFailed(InitializationFailureReason error, string message);
2. void RestoreTransactions(Action<bool, string> callback);

Thank you.

 

Thanks @Yannick_D it's much appreciated.

Could you also please consider removing the old (obsolete) method as well?

Code (CSharp):

1. [Obsolete]
2. void OnInitializeFailed(InitializationFailureReason error);

The 4.6.0 update included breaking changes to the interface (contract) so required developer input\changes anyway.

There is now an obsolete method hanging around that is not being called\used (from what I can gather)

Thanks again for the update.