Search Unity

  1. Welcome to the Unity Forums! Please take the time to read our Code of Conduct to familiarize yourself with the forum rules and how to post constructively.
  2. Dismiss Notice

Bug I SWEAR I DID IT RIGHT

Discussion in 'Scripting' started by JellyFun, Jul 25, 2023.

  1. JellyFun

    JellyFun

    Joined:
    Jul 25, 2023
    Posts:
    2
    Code (CSharp):
    1. using UnityEngine;
    2.  
    3. public class PlayerMovement : MonoBehaviour
    4. {
    5.     public float moveSpeed = 5f;
    6.     public LayerMask groundLayer;
    7.     private Rigidbody2D rb;
    8.     private bool isGrounded = false;
    9.     private Transform groundCheck;
    10.     private float groundCheckRadius = 0.1f;
    11.  
    12.     void Start()
    13.     {
    14.         rb = GetComponent<Rigidbody2D>();
    15.         groundCheck = transform.Find("GroundCheck"); // Ensure the name matches the scene object
    16.     }
    17.  
    18.     private void OnCollisionEnter2D(Collision2D collision)
    19.     {
    20.         if (collision.gameObject.CompareTag("Ground"))
    21.         {
    22.             isGrounded = true;
    23.         }
    24.     }
    25.  
    26.     private void OnCollisionExit2D(Collision2D collision)
    27.     {
    28.         if (collision.gameObject.CompareTag("Ground"))
    29.         {
    30.             isGrounded = false;
    31.         }
    32.     }
    33.  
    34.     void Update()
    35.     {
    36.         float moveInput = Input.GetAxis("Horizontal"); // Get horizontal input (A/D keys or Left/Right arrow keys)
    37.  
    38.         // Apply movement only if the player is grounded
    39.         if (isGrounded)
    40.         {
    41.             rb.velocity = new Vector2(moveInput * moveSpeed, rb.velocity.y);
    42.         }
    43.     }
    44.  
    45.     private void FixedUpdate()
    46.     {
    47.         // Check if the player is grounded using a small circle at the player's feet
    48.         if (groundCheck != null)
    49.         {
    50.             isGrounded = Physics2D.OverlapCircle(groundCheck.position, groundCheckRadius, groundLayer);
    51.         }
    52.     }
    53. }
    54.  
    I know what you are thinking. Let me explain this. I'm working on a new game, assigned to the ground that it is Tag "Ground". What does unity have for me? "Tag "Ground" is not defined.
    UnityEngine.StackTraceUtility:ExtractStackTrace ()
    PlayerMovement:OnCollisionExit2D (UnityEngine.Collision2D) (at Assets/Scripts/Movement.cs:28)
    using UnityEngine;

    Proof on file.
     

    Attached Files:

  2. MelvMay

    MelvMay

    Unity Technologies

    Joined:
    May 24, 2013
    Posts:
    10,468
    Why do you need proof that you're getting a console message? Nobody would doubt you. ;)

    That said, the "proof" of the problem be showing that tag. :) Please show the tag in the tag manager. I presume you've checked that it's actually there?

    Are you sure you're not getting mixed up between a tag and a layer?

    https://docs.unity3d.com/Manual/Tags.html
     
  3. Kurt-Dekker

    Kurt-Dekker

    Joined:
    Mar 16, 2013
    Posts:
    36,563
    I'm sure you were about to show us proof of how you added the Tag that it says hasn't been added.

    Remember, you don't have to impress us with what you did.

    You have to do all the things required to use features of Unity.

    Those are very different things.

    Tutorials and example code are great, but keep this in mind to maximize your success and minimize your frustration:

    How to do tutorials properly, two (2) simple steps to success:

    Step 1. Follow the tutorial and do every single step of the tutorial 100% precisely the way it is shown. Even the slightest deviation (even a single character!) generally ends in disaster. That's how software engineering works. Every step must be taken, every single letter must be spelled, capitalized, punctuated and spaced (or not spaced) properly, literally NOTHING can be omitted or skipped.

    Fortunately this is the easiest part to get right: Be a robot. Don't make any mistakes.
    BE PERFECT IN EVERYTHING YOU DO HERE!!


    If you get any errors, learn how to read the error code and fix your error. Google is your friend here. Do NOT continue until you fix your error. Your error will probably be somewhere near the parenthesis numbers (line and character position) in the file. It is almost CERTAINLY your typo causing the error, so look again and fix it.

    Step 2. Go back and work through every part of the tutorial again, and this time explain it to your doggie. See how I am doing that in my avatar picture? If you have no dog, explain it to your house plant. If you are unable to explain any part of it, STOP. DO NOT PROCEED. Now go learn how that part works. Read the documentation on the functions involved. Go back to the tutorial and try to figure out WHY they did that. This is the part that takes a LOT of time when you are new. It might take days or weeks to work through a single 5-minute tutorial. Stick with it. You will learn.

    Step 2 is the part everybody seems to miss. Without Step 2 you are simply a code-typing monkey and outside of the specific tutorial you did, you will be completely lost. If you want to learn, you MUST do Step 2.

    Of course, all this presupposes no errors in the tutorial. For certain tutorial makers (like Unity, Brackeys, Imphenzia, Sebastian Lague) this is usually the case. For some other less-well-known content creators, this is less true. Read the comments on the video: did anyone have issues like you did? If there's an error, you will NEVER be the first guy to find it.

    Beyond that, Step 3, 4, 5 and 6 become easy because you already understand!

    Finally, when you have errors, don't post here... just go fix your errors! Here's how:

    Remember: NOBODY here memorizes error codes. That's not a thing. The error code is absolutely the least useful part of the error. It serves no purpose at all. Forget the error code. Put it out of your mind.

    The complete error message contains everything you need to know to fix the error yourself.

    The important parts of the error message are:

    - the description of the error itself (google this; you are NEVER the first one!)
    - the file it occurred in (critical!)
    - the line number and character position (the two numbers in parentheses)
    - also possibly useful is the stack trace (all the lines of text in the lower console window)

    Always start with the FIRST error in the console window, as sometimes that error causes or compounds some or all of the subsequent errors. Often the error will be immediately prior to the indicated line, so make sure to check there as well.

    Look in the documentation. Every API you attempt to use is probably documented somewhere. Are you using it correctly? Are you spelling it correctly?

    All of that information is in the actual error message and you must pay attention to it. Learn how to identify it instantly so you don't have to stop your progress and fiddle around with the forum.
     
  4. KillDashNine

    KillDashNine

    Joined:
    Apr 19, 2020
    Posts:
    449
    Select any gameobject, click on top of your Inspector on the drop-down called Tag. This shows a list of the tags in your project.

    If the tag you are searching for in your script is not on the list at all, then error. As the error says, your tag is not defined.
     
    Bunny83 likes this.
  5. Kurt-Dekker

    Kurt-Dekker

    Joined:
    Mar 16, 2013
    Posts:
    36,563
    Exactly what Jaakk says... but ALSO: make sure you didn't add a blank space before or after and that your capitalization is perfect.

    All of these things are different:

    "Ground"
    "Ground "
    "GROUND"


    etc.
     
    Bunny83, Ryiah and KillDashNine like this.