Search Unity

I need help with this movement script

Discussion in 'Scripting' started by splashcoder2090, Jun 22, 2022.

  1. splashcoder2090

    splashcoder2090

    Joined:
    Jul 5, 2021
    Posts:
    4
    IM new to coding and i found this movement script but it doesn't work i dont know why can anyone help?

    using System.Collections;
    using System.Collections.Generic;
    using UnityEngine;

    public class movement : MonoBehaviour
    {

    public float movementSpeed;
    public Rigidbody2D rb;
    public Animator anim;
    public float jumpForce = 20f;
    public bool isGrounded;
    public Transform feet;
    public LayerMask groundLayers;
    float mx;

    private void Update()
    {
    mx = Input.GetAxisRaw("Horizontal");
    if (Input.GetButtonDown("Jump") && IsGrounded()) { }
    jump();
    if (Mathf.Abs(mx) > 0.05f)
    {
    anim.SetBool("isRunning", true);
    }else
    {
    anim.SetBool("isRunnning", false);
    }
    }
    private void FixedUpdate()
    {
    Vector2 movement = new Vector2 (mx * movementSpeed, rb, velocity.y);
    rb.velocity = movement;
    }
    void Jump()
    {
    Vector2 movement = new Vector2(rb.velocity.x, jumpForce);
    rb.velocity = movement;
    public bool isGrounded()
    {
    Collider2D groundCheck = physics2D.OverlapCircle(feet.position, 0.5, groundLayers);
    // this could be wrong so careful maybe this is its own line(bottom)
    if (groundCheck != null)
    {
    return true;
    }
    return false;
    }
    }
    }
     
  2. Brathnann

    Brathnann

    Joined:
    Aug 12, 2014
    Posts:
    7,188
    First, use code tags. Nobody wants to read a wall of text without formatting.
    Second, just saying something doesn't work doesn't make it easy for others to help you. Tell us what errors you're getting or what part doesn't work. Otherwise, if you're copying a script or following a tutorial, make sure you follow it exactly.
     
  3. Kurt-Dekker

    Kurt-Dekker

    Joined:
    Mar 16, 2013
    Posts:
    38,745
    You are just making typos. We know nobody told you to type the above because it is useless do-nothing code.

    Also this is just pure wrong:

    Don't make typos. It's only going to waste YOUR time.

    Grab a fresh cup of coffee and go back and do this tutorial properly. This is how:

    Tutorials and example code are great, but keep this in mind to maximize your success and minimize your frustration:

    How to do tutorials properly, two (2) simple steps to success:

    Step 1. Follow the tutorial and do every single step of the tutorial 100% precisely the way it is shown. Even the slightest deviation (even a single character!) generally ends in disaster. That's how software engineering works. Every step must be taken, every single letter must be spelled, capitalized, punctuated and spaced (or not spaced) properly, literally NOTHING can be omitted or skipped.

    Fortunately this is the easiest part to get right: Be a robot. Don't make any mistakes.
    BE PERFECT IN EVERYTHING YOU DO HERE!!


    If you get any errors, learn how to read the error code and fix your error. Google is your friend here. Do NOT continue until you fix your error. Your error will probably be somewhere near the parenthesis numbers (line and character position) in the file. It is almost CERTAINLY your typo causing the error, so look again and fix it.

    Step 2. Go back and work through every part of the tutorial again, and this time explain it to your doggie. See how I am doing that in my avatar picture? If you have no dog, explain it to your house plant. If you are unable to explain any part of it, STOP. DO NOT PROCEED. Now go learn how that part works. Read the documentation on the functions involved. Go back to the tutorial and try to figure out WHY they did that. This is the part that takes a LOT of time when you are new. It might take days or weeks to work through a single 5-minute tutorial. Stick with it. You will learn.

    Step 2 is the part everybody seems to miss. Without Step 2 you are simply a code-typing monkey and outside of the specific tutorial you did, you will be completely lost. If you want to learn, you MUST do Step 2.

    Of course, all this presupposes no errors in the tutorial. For certain tutorial makers (like Unity, Brackeys, Imphenzia, Sebastian Lague) this is usually the case. For some other less-well-known content creators, this is less true. Read the comments on the video: did anyone have issues like you did? If there's an error, you will NEVER be the first guy to find it.

    Beyond that, Step 3, 4, 5 and 6 become easy because you already understand!
     
  4. Kurt-Dekker

    Kurt-Dekker

    Joined:
    Mar 16, 2013
    Posts:
    38,745