Search Unity

  1. Welcome to the Unity Forums! Please take the time to read our Code of Conduct to familiarize yourself with the forum rules and how to post constructively.
  2. We have updated the language to the Editor Terms based on feedback from our employees and community. Learn more.
    Dismiss Notice

i`m trying to make a inventory i`m trying to make it so i don`t need to drag the slots

Discussion in 'Scripting' started by Khabi12, Sep 8, 2022.

  1. Khabi12

    Khabi12

    Joined:
    Aug 9, 2022
    Posts:
    22
    Code (CSharp):
    1. using System.Collections;
    2. using System.Collections.Generic;
    3. using UnityEngine;
    4.  
    5. public class InventorySystem : MonoBehaviour
    6. {
    7.  
    8.    public static InventorySystem Instance { get; set; }
    9.     public GameObject inventoryScreenUI;
    10.  
    11.     public bool isOpen;
    12.  
    13.     public List<GameObject> slotList = new List<GameObject>();
    14.  
    15.     public List<string> itemList = new List<string>();
    16.  
    17.     private GameObject itemToAdd;
    18.  
    19.     private GameObject whatSlotToEquip;
    20.  
    21.     public bool isFull;
    22.     private void Awake()
    23.     {
    24.         if (Instance != null && Instance != this)
    25.         {
    26.             Destroy(gameObject);
    27.         }
    28.         else
    29.         {
    30.             Instance = this;
    31.         }
    32.     }
    33.  
    34.     void Start()
    35.     {
    36.  
    37.         PopulateSlotList();
    38.  
    39.  
    40.         isOpen = false;
    41.     }
    42.  
    43.        
    44.     private void PopulateSlotList()
    45.     {
    46.        foreach (Transform child in inventoryScreenUI.transform)
    47.        {
    48.           if (child.CompareTag("Slot"))
    49.           {
    50.              slotList.Add(child.gameObject);
    51.           }
    52.        }
    53.     }
    54.     void Update()
    55.     {
    56.         if (Input.GetKeyDown(KeyCode.E) && !isOpen)
    57.         {
    58.             Debug.Log("E is pressed");
    59.             inventoryScreenUI.SetActive(true);
    60.             isOpen = true;
    61.         }
    62.         else if (Input.GetKeyDown(KeyCode.E) && isOpen)
    63.         {
    64.             inventoryScreenUI.SetActive(false);
    65.             isOpen = false;
    66.         }
    67.     }
    68. }
    69.  
     
  2. Khabi12

    Khabi12

    Joined:
    Aug 9, 2022
    Posts:
    22
    the problem is the
    1. private void PopulateSlotList()
    2. {
    3. foreach (Transform child in inventoryScreenUI.transform)
    4. {
    5. if (child.CompareTag("Slot"))
    6. {
    7. slotList.Add(child.gameObject);
    8. }
    9. }
    10. }
    11. code is not working as intended
     
  3. Kurt-Dekker

    Kurt-Dekker

    Joined:
    Mar 16, 2013
    Posts:
    36,947
    That is not a useful assessment.

    If you are hammering this in from a tutorial, go back and look over your work.

    How to report your problem productively in the Unity3D forums:

    http://plbm.com/?p=220

    This is the bare minimum of information to report:

    - what you want
    - what you tried
    - what you expected to happen
    - what actually happened, especially any errors you see
    - links to documentation you used to cross-check your work (CRITICAL!!!)

    Tutorials and example code are great, but keep this in mind to maximize your success and minimize your frustration:

    How to do tutorials properly, two (2) simple steps to success:

    Step 1. Follow the tutorial and do every single step of the tutorial 100% precisely the way it is shown. Even the slightest deviation (even a single character!) generally ends in disaster. That's how software engineering works. Every step must be taken, every single letter must be spelled, capitalized, punctuated and spaced (or not spaced) properly, literally NOTHING can be omitted or skipped.

    Fortunately this is the easiest part to get right: Be a robot. Don't make any mistakes.
    BE PERFECT IN EVERYTHING YOU DO HERE!!

    If you get any errors, learn how to read the error code and fix your error. Google is your friend here. Do NOT continue until you fix your error. Your error will probably be somewhere near the parenthesis numbers (line and character position) in the file. It is almost CERTAINLY your typo causing the error, so look again and fix it.

    Step 2. Go back and work through every part of the tutorial again, and this time explain it to your doggie. See how I am doing that in my avatar picture? If you have no dog, explain it to your house plant. If you are unable to explain any part of it, STOP. DO NOT PROCEED. Now go learn how that part works. Read the documentation on the functions involved. Go back to the tutorial and try to figure out WHY they did that. This is the part that takes a LOT of time when you are new. It might take days or weeks to work through a single 5-minute tutorial. Stick with it. You will learn.

    Step 2 is the part everybody seems to miss. Without Step 2 you are simply a code-typing monkey and outside of the specific tutorial you did, you will be completely lost. If you want to learn, you MUST do Step 2.

    Of course, all this presupposes no errors in the tutorial. For certain tutorial makers (like Unity, Brackeys, Imphenzia, Sebastian Lague) this is usually the case. For some other less-well-known content creators, this is less true. Read the comments on the video: did anyone have issues like you did? If there's an error, you will NEVER be the first guy to find it.

    Beyond that, Step 3, 4, 5 and 6 become easy because you already understand!

    Finally, when you have errors...

    Remember: NOBODY here memorizes error codes. That's not a thing. The error code is absolutely the least useful part of the error. It serves no purpose at all. Forget the error code. Put it out of your mind.

    The complete error message contains everything you need to know to fix the error yourself.

    The important parts of the error message are:

    - the description of the error itself (google this; you are NEVER the first one!)
    - the file it occurred in (critical!)
    - the line number and character position (the two numbers in parentheses)
    - also possibly useful is the stack trace (all the lines of text in the lower console window)

    Always start with the FIRST error in the console window, as sometimes that error causes or compounds some or all of the subsequent errors. Often the error will be immediately prior to the indicated line, so make sure to check there as well.

    All of that information is in the actual error message and you must pay attention to it. Learn how to identify it instantly so you don't have to stop your progress and fiddle around with the forum.
     
  4. Khabi12

    Khabi12

    Joined:
    Aug 9, 2022
    Posts:
    22
    if you dont understand then i will say every slot has the tag Slot and its soposto add every gameobject that has the tag Slot to the slotlist
     
  5. Khabi12

    Khabi12

    Joined:
    Aug 9, 2022
    Posts:
    22
     
  6. Kurt-Dekker

    Kurt-Dekker

    Joined:
    Mar 16, 2013
    Posts:
    36,947
    Time to start debugging!

    You must find a way to get the information you need in order to reason about what the problem is.

    What is often happening in these cases is one of the following:

    - the code you think is executing is not actually executing at all
    - the code is executing far EARLIER or LATER than you think
    - the code is executing far LESS OFTEN than you think
    - the code is executing far MORE OFTEN than you think
    - the code is executing on another GameObject than you think it is
    - you're getting an error or warning and you haven't noticed it in the console window

    To help gain more insight into your problem, I recommend liberally sprinkling
    Debug.Log()
    statements through your code to display information in realtime.

    Doing this should help you answer these types of questions:

    - is this code even running? which parts are running? how often does it run? what order does it run in?
    - what are the values of the variables involved? Are they initialized? Are the values reasonable?
    - are you meeting ALL the requirements to receive callbacks such as triggers / colliders (review the documentation)

    Knowing this information will help you reason about the behavior you are seeing.

    You can also supply a second argument to Debug.Log() and when you click the message, it will highlight the object in scene, such as
    Debug.Log("Problem!",this);


    If your problem would benefit from in-scene or in-game visualization, Debug.DrawRay() or Debug.DrawLine() can help you visualize things like rays (used in raycasting) or distances.

    You can also call Debug.Break() to pause the Editor when certain interesting pieces of code run, and then study the scene manually, looking for all the parts, where they are, what scripts are on them, etc.

    You can also call GameObject.CreatePrimitive() to emplace debug-marker-ish objects in the scene at runtime.

    You could also just display various important quantities in UI Text elements to watch them change as you play the game.

    If you are running a mobile device you can also view the console output. Google for how on your particular mobile target, such as this answer or iOS: https://forum.unity.com/threads/how-to-capturing-device-logs-on-ios.529920/ or this answer for Android: https://forum.unity.com/threads/how-to-capturing-device-logs-on-android.528680/

    Another useful approach is to temporarily strip out everything besides what is necessary to prove your issue. This can simplify and isolate compounding effects of other items in your scene or prefab.

    Here's an example of putting in a laser-focused Debug.Log() and how that can save you a TON of time wallowing around speculating what might be going wrong:

    https://forum.unity.com/threads/coroutine-missing-hint-and-error.1103197/#post-7100494

    When in doubt, print it out!(tm)

    These things (character customization, inventories, shop systems) are fairly tricky hairy beasts, definitely deep in advanced coding territory. They contain elements of:


    - a database of items that you may possibly possess / equip
    - a database of the items that you actually possess / equip currently
    - perhaps another database of your "storage" area at home base?
    - persistence of this information to storage between game runs
    - presentation of the inventory to the user (may have to scale and grow, overlay parts, clothing, etc)
    - interaction with items in the inventory or on the character or in the home base storage area
    - interaction with the world to get items in and out
    - dependence on asset definition (images, etc.) for presentation

    Just the design choices of an inventory system can have a lot of complicating confounding issues, such as:

    - can you have multiple items? Is there a limit?
    - if there is an item limit, what is it? Total count? Weight? Size? Something else?
    - are those items shown individually or do they stack?
    - are coins / gems stacked but other stuff isn't stacked?
    - do items have detailed data shown (durability, rarity, damage, etc.)?
    - can users combine items to make new items? How? Limits? Results? Messages of success/failure?
    - can users substantially modify items with other things like spells, gems, sockets, etc.?
    - does a worn-out item (shovel) become something else (like a stick) when the item wears out fully?
    - etc.

    Your best bet is probably to write down exactly what you want feature-wise. It may be useful to get very familiar with an existing game so you have an actual example of each feature in action.

    Once you have decided a baseline design, fully work through two or three different inventory tutorials on Youtube, perhaps even for the game example you have chosen above.

    Or... do like I like to do: just jump in and make it up as you go. It is SOFT-ware after all... evolve it as you go! :)

    Breaking down a large problem such as inventory:

    https://forum.unity.com/threads/weapon-inventory-and-how-to-script-weapons.1046236/#post-6769558
     
  7. Khabi12

    Khabi12

    Joined:
    Aug 9, 2022
    Posts:
    22
    im a kid how im a suposto know what "Defined" means
     
  8. Kurt-Dekker

    Kurt-Dekker

    Joined:
    Mar 16, 2013
    Posts:
    36,947
    I recommend you tackle some vastly-simpler projects. Inventories are HARD.

    Imphenzia: How Did I Learn To Make Games:

     
  9. Khabi12

    Khabi12

    Joined:
    Aug 9, 2022
    Posts:
    22
    oh the debug.log ok ill tell if it works
     
  10. Khabi12

    Khabi12

    Joined:
    Aug 9, 2022
    Posts:
    22
    i made my first game from imphenzia
     
  11. Khabi12

    Khabi12

    Joined:
    Aug 9, 2022
    Posts:
    22
  12. Khabi12

    Khabi12

    Joined:
    Aug 9, 2022
    Posts:
    22
     
  13. Khabi12

    Khabi12

    Joined:
    Aug 9, 2022
    Posts:
    22
    i fixed it thanks