Official Hybrid Renderer V2 (0.4.0)

Since shader graph is listed as supported, wondering if this is a known issue, didn't find mention of it:
- Using V2 (define set, cloned hdrp v9.0.0-preview0 tag, Unity 2020.1.0b4)
- Given a minimal HDRP PBR Master shader graph: the Normal Vector (Object Space) plugged directly into the Normal output, nothing else in the graph
- Any object using a material with that shader will always render as though its transform were float4x4.identity
- LocalToWorld holds the correct transform value
- Culling still appears to operate on the correct transform value

 

That sounds like a bug i had with the SRP Batcher putting everything at 0/0/0, but that wasn't for V2

 

Ah! I didn't think of testing that (since it isn't an issue in v1 for me, hmm), but that's definitely related, if not the same thing: disabling the SRP Batcher does indeed fix it.

Nevermind... I think I mistook the ECS cube for the reference non-ECS cube in my test scene before because I just woke up. The ECS cube will just completely disappear when I disable the batcher. It shows up in the stats and the frame debugger shows the drawcall, it just never... shows. Will dig some more.


Update: all right, so, I've created a new project with the HDRP template, added Entities + Hybrid Renderer packages and copied the cloned 9.0.0-preview0 SRP/HDRP packages into Packages dir and... well. Regardless of the V2 define, as soon as I have the "Example Assets" group converted to ECS, things render completely broken and out of place. Disabling SRP Batcher only causes stuff to completely disappear in V2 and seems to make light probes have an effect again in V1 (only difference is in the lighting of the objects). So.. yeah. Will the 9.0.0 that'll go into the package manager do anything different or am I missing anything?

 

It looks like the scriptable render pipeline git repository has been removed/made private?

 

New repo is now at https://github.com/Unity-Technologies/Graphics
Old SRP repo will return as archive soon, it's currently offline while they take backups.

See more information about this here: https://forum.unity.com/threads/srp-repository-migration.861625/

 

Is there any known issue that would cause HDRP to have totally different lighting intensity once converted to ECS side and using Hybrid Rendering v2?

I only have convert to entity on the plane mesh here (same happens to all converted HD Lit materials in my testing):


It doesn't do this if I don't convert to entity or if I use Hybrid Renderer v1.
I've tested this on 2020.0b4 and on both latest HDRP/staging from Graphics repo and with HDRP 9.0.0-preview.

 

The current package has some bugs with the conversion, so the additional HDLightAdditionalData component is missing causing the unit conversion on the light intensity not to happen.

Until this is fixed you can manually adjust the intensity with the formula you can get from the normal HDLightAdditionalData monobehavior (look at the intensity set accessor and go from there).

 

This is in line what I see here, when I lowered the light intensity I got more like results I expected but then the sky exposure was off and would have needed to recalibrate it with false values. I hope they address this properly soon

 

Yea the lighting issue confused me for ages and until recently I thought it was an issue of HDRP.

 

FYI - If you are using the default Lumen value type, you can add this to your code to get the correct intensity when setting the value.

Code (CSharp):

1. var actualIntensity = intensity / (4.0f * Mathf.PI);

 

It might just be me, but it seems that LOD sampling Texture2DArrays aren't working well with Shader Graph and Hybrid Renderer v2 yet. I've got a shader that uses them, but I'm getting <15 frames per second. Performance without that shader is beyond wonderful though, so many thanks for that.

 

I've started this thread with exactly that problem: https://forum.unity.com/threads/need-read-only-access-to-dynamic-buffers.843934/
Got zero response

 

What defines a pair of "compatible meshes " and will this feature be available for runtime instantiated entities as well? I maintain SpeckleUnity which is an open source alternative to unity reflect and buildings are pretty much exclusively modelled with unique meshes.

 

That's an amazing idea! it's like taking the best from Dynamic and Static batching ^_^
i think this way the draw calls will be insanely optimized.

but how about the subscene size and Ram usage? this technique will increase them by alot.

 

Entities 0.9 is out!

 

Thank you very much for this detailed answer.

 

Anyone run into this with Untiy 2020.1.0b5.3485 with latest (burst, hybrid renderer, jobs, collections, entities preview packages)?

Library\PackageCache\com.unity.rendering.hybrid@0.4.1-preview.6\Unity.Rendering.Hybrid\CopySkinnedEntityDataToRenderEntity.cs(16,26): error CS0246: The type or namespace name 'RenderMeshSystemV2' could not be found (are you missing a using directive or an assembly reference?)

 

You can see in the original post that SRP 9.0.0-preview a requirement. It isn't available yet through the package manager and you have to download it from GitHub and install it manually. I have seen explanations in this forum about how to do it, but I haven't done it yet.

 

To get the preview package simply go to your project folder, go inside the package folder and open up manifest.json and add this line :

"com.unity.render-pipelines.universal": "9.0.0-preview.14"

Make sure you have the proper version of unity.

 

SRP 9.0.0-preview is now available through the Package Manager but only for Unity 2020.1.x +

 

I forgot you can do that in those files. That was spot on what I needed axxessdenied. Thank you.

 

So, the build is working now. hyper renderer V2 is showing enabled in Unity 2020.1 beta 5. No Play Mode errors. Packages are all update to date, no issues showing in the Console.

But, I don't see any entities in the Game window during Play Mode. I see the Entities.Debugger information for them.

I have a fly camera script on the camera. So I've "flown" rotated all over and still don't see them.



It sure seems like I'm missing something surely very simple here? Any ideas all?

 

Scroll down in the systems portion of the window in the entity debugger to see if the render system is active. then you can click it and see which components it requires to render an entity. if your entity only has a rendermesh component it doesn't meet the component requirement to be for the render system.
Are you creating the entities from a prefab or via code?

 

i enabled the hybrid renderer v2 via flag as described in the github repo, but now everything is pitch black...

removing the flag and using the "normal" new v3 renderer, it works fine, but everything is darker.

Any idea why its pitch black?

 

Code (CSharp):

1. using System.Collections;
2. using System.Collections.Generic;
3. using UnityEngine;
4. using Unity.Entities;
5. using Unity.Mathematics;
6. using Unity.Transforms;
7. using Unity.Rendering;
8. using Unity.Jobs;
9.  
10. public class CreateCapsuleSystem : JobComponentSystem
11. {
12.     protected override void OnCreate()
13.     {
14.         base.OnCreate();
15.  
16.         for (int i = 0; i < 1000000; i++)
17.         {
18.  
19.             var instance = EntityManager.CreateEntity(
20.                 ComponentType.ReadOnly<LocalToWorld>(),
21.                 ComponentType.ReadWrite<Translation>(),
22.                 ComponentType.ReadWrite<Rotation>(),
23.                 ComponentType.ReadWrite<NonUniformScale>(),
24.                 ComponentType.ReadOnly<RenderMesh>()
25.                 );
26.  
27.  
28.             float3 position = new float3(UnityEngine.Random.Range(-10, 10), 0, UnityEngine.Random.Range(-10, 10));
29.             float scale = UnityEngine.Random.Range(1, 10);
30.             EntityManager.SetComponentData(instance,
31.                 new LocalToWorld
32.                 {
33.                     Value = new float4x4(rotation: quaternion.identity, translation: position)
34.                 });
35.             EntityManager.SetComponentData(instance, new Translation { Value = position });
36.             EntityManager.SetComponentData(instance, new Rotation { Value = new quaternion(0, 0, 0, 0) });
37.             EntityManager.SetComponentData(instance, new NonUniformScale { Value = new float3(scale, scale, scale) });
38.             var rHolder = Resources.Load<GameObject>("ResourceHolder").GetComponent<ResourceHolder>();
39.  
40.             EntityManager.SetSharedComponentData(instance,
41.                 new RenderMesh
42.                 {
43.                     mesh = rHolder.theMesh,
44.                     material = rHolder.theMaterial
45.                 });
46.         }
47.     }
48.  
49.  
50.     protected override JobHandle OnUpdate(JobHandle inputDeps)
51.     {
52.         return inputDeps;
53.     }
54. }
55.  

Here's what I had before and it showed a bunch of sheep. Worked with V1 in 2019.3.

 

To add, I do not see RenderBounds, which I expected. This has to be something simple I'm overlooking. No one else is posting this issue that Iv'e seen.

 

I found it easier to just instantiate my entities by loading in a prefab that has a mesh instance and a mesh renderer component on it to automatically have all the necessary components added.
You can load in your prefabs using scriptable objects if you want using the addressables package : https://forum.unity.com/threads/architecture-with-scriptable-objects-and-ecs.559789/#post-4998674
works great if you don't want game objects in your scene.

 

Thanks for the follow-up, answer. It's got me perplexed. I did not change the code.

 

hopefully you get it sorted. i feel like I spend more time debugging and figuring out how to do things properly than writing actual code right now messing around with ecs but its fun

 

Have not found a solution yet.

 

I would start with the basics and create an object in the scene and have it be converted and injected when you load in. Make sure everything is working as it should. From there it would be a matter of debugging what the issue is. I tried generating entities from code and I couldn't get them to render properly so I just instantiate them instead and it ended up working just fine.
My process ended up being :
I created a PrefabLibrary entity that loads prefabs and converts them to entities that are stored in the library entity. I can then just bring up the prefab library entity as a singleton and instantiate entities from those template entities..
I manually create the prefab library system in my bootstrap file and queue which prefabs to load and then run the system only once and disable it. From there my init system will run instantiating the entities I want. Hope that helps.

 

Just updated... Errors everywhere, SRP batcher is going crazy ...

 

Thanks again axxessdenied. That's a good point, I'll give that a go.

 

Yeah Im having some issues too. What preview version of HDRP 9.0 are you using? The one in the package manager or from Github?

 

For entities created from scratch from code you should add and set RenderBounds manually since 0.3.4-preview.24 https://forum.unity.com/threads/iss...onent-mesh-not-displayed.835858/#post-5523820

 

Package Manager.
In the beginning it's fine, and after like 10 sec it goes buggy. My guess is that Burst finished compiling.

 

That did it. Thank you eizenhorn. Here's what I have (with some commented out code) to first get it running now.

Code (CSharp):

1. using System.Collections;
2. using System.Collections.Generic;
3. using UnityEngine;
4. using Unity.Entities;
5. using Unity.Mathematics;
6. using Unity.Transforms;
7. using Unity.Rendering;
8. using Unity.Jobs;
9.  
10. public class CreateCapsuleSystem : JobComponentSystem
11. {
12.     protected override void OnCreate()
13.     {
14.         base.OnCreate();
15.  
16.         for (int i = 0; i < 1000; i++)
17.         {
18.  
19.             var instance = EntityManager.CreateEntity(
20.                 ComponentType.ReadOnly<LocalToWorld>(),
21.                 ComponentType.ReadWrite<Translation>(),
22.                 ComponentType.ReadWrite<Rotation>(),
23.                 ComponentType.ReadWrite<NonUniformScale>(),
24.                 ComponentType.ReadOnly<RenderMesh>(),
25.                 ComponentType.ReadOnly<RenderBounds>()
26.                 );
27.  
28.  
29.             float3 position = new float3(UnityEngine.Random.Range(-10, 10), 0, UnityEngine.Random.Range(-10, 10));
30.             float scale = UnityEngine.Random.Range(1, 10);
31.             EntityManager.SetComponentData(instance,
32.                 new LocalToWorld
33.                 {
34.                     Value = new float4x4(rotation: quaternion.identity, translation: position)
35.                 });
36.             EntityManager.SetComponentData(instance, new Translation { Value = position });
37.             EntityManager.SetComponentData(instance, new Rotation { Value = new quaternion(0, 0, 0, 0) });
38.             EntityManager.SetComponentData(instance, new NonUniformScale { Value = new float3(scale, scale, scale) });
39.  
40.             //EntityManager.SetComponentData(instance, new RenderBounds { Value = instance.bounds.ToAABB() });
41.             //EntityManager.SetComponentData(instance, new RenderBounds { Value = instance.bounds.ToAABB() });
42.  
43.             var rHolder = Resources.Load<GameObject>("ResourceHolder").GetComponent<ResourceHolder>();
44.  
45.             EntityManager.SetSharedComponentData(instance,
46.                 new RenderMesh
47.                 {
48.                     mesh = rHolder.theMesh,
49.                     material = rHolder.theMaterial
50.                 });
51.  
52.             EntityManager.SetComponentData(instance, new RenderBounds()
53.             {
54.                 Value = new AABB()
55.                 {
56.                     //Center = new float3(mesh.bounds.center.x, mesh.bounds.center.y, mesh.bounds.center.z),
57.                     //Extents = new float3(mesh.bounds.extents.x, mesh.bounds.extents.y, mesh.bounds.extents.z)
58.                 }
59.             });
60.         }
61.     }
62.  
63.  
64.     protected override JobHandle OnUpdate(JobHandle inputDeps)
65.     {
66.         return inputDeps;
67.     }
68. }
69.  

 

I also got the ECSSamples (one of the examples there) running just before this RenderBounds() code-add and run. I was getting ready to consolidate my finding into a new project. This took care of that need. Thanks again to everyone helping.

 

I'm having trouble getting material property overrides to work.
Added ENABLE_HYBRID_RENDERER_V2 define.
Created 2D Renderer -> Sprite Lit graph.
Added properties to override, checked Hybrid Instanced.
Set up conversion to add needed components with MaterialPropertyAttribute.
Confirmed that the components are added with proper values.
Still Hybrid Renderer does not override the properties. I've tracked the problem to HybridV2ShaderReflection.GetDOTSInstancingProperties() returning empty list, but no idea what to try next.
Using 2020.1.0b5 and latest previews of SRP, Hybrid Renderer and other needed packages.
Double checked the manual, but I don't think I missed something.
Any clue why its not working?

One of the properties:

Code (CSharp):

1. [MaterialProperty("TexturePivot", MaterialPropertyFormat.Float4)]
2. public struct PixelizedTexturePivot : IComponentData
3. {
4.     public float4 Value;
5. }