Search Unity

  1. Megacity Metro Demo now available. Download now.
    Dismiss Notice
  2. Unity support for visionOS is now available. Learn more in our blog post.
    Dismiss Notice

Question How to make player not able to move in direction of wall if he will collide with him on next step?

Discussion in 'Scripting' started by unity_FB2E195CCB26D8732BD8, Mar 1, 2023.

  1. unity_FB2E195CCB26D8732BD8

    unity_FB2E195CCB26D8732BD8

    Joined:
    Nov 21, 2022
    Posts:
    1
    My goal is to make player not able to move in the direction of wall if he will collide with him on next step(for example if player presses "A", and with this press he will collide with the wall, nothing will happend, but he will be able to move forward with "W" if next step is not colliding with the wall and so on.



    Code (CSharp):
    1. using System.Collections;
    2. using System.Collections.Generic;
    3. using UnityEngine;
    4.  
    5. public class PlayerController : MonoBehaviour
    6. {
    7.  
    8.     public bool smoothTransition = false;
    9.     public float transitionSpeed = 10f;
    10.     public float transitionRotationSpeed = 500f;
    11.  
    12.     Vector3 targetGridPos;
    13.     Vector3 prevTargetGridPos;
    14.     Vector3 targetRotation;
    15.  
    16.     private void Start()
    17.     {
    18.         targetGridPos = Vector3Int.RoundToInt(transform.position);
    19.         Collider collider = gameObject.AddComponent<BoxCollider>();
    20.         collider.isTrigger = false;
    21.     }
    22.  
    23.     private void FixedUpdate()
    24.     {
    25.         MovePlayer();
    26.     }
    27.  
    28.     void MovePlayer()
    29.     {
    30.         if (true) // here is an error?
    31.         {
    32.             prevTargetGridPos = targetGridPos;
    33.  
    34.             Vector3 targetPosition = targetGridPos;
    35.  
    36.             if (targetRotation.y > 270f && targetRotation.y < 361f) targetRotation.y = 0f;
    37.             if (targetRotation.y < 0f) targetRotation.y = 270f;
    38.  
    39.             if (!smoothTransition)
    40.             {
    41.                 transform.position = targetPosition;
    42.                 transform.rotation = Quaternion.Euler(targetRotation);
    43.             }
    44.             else
    45.             {
    46.                 transform.position = Vector3.MoveTowards(transform.position, targetPosition, Time.deltaTime * transitionSpeed);
    47.                 transform.rotation = Quaternion.RotateTowards(transform.rotation, Quaternion.Euler(targetRotation), Time.deltaTime * transitionRotationSpeed);
    48.             }
    49.  
    50.             // Check for collisions with walls
    51.             Collider[] hitColliders = Physics.OverlapSphere(transform.position, 0.4f);
    52.             foreach (Collider hitCollider in hitColliders)
    53.             {
    54.                 Debug.Log("Collided with " + hitCollider.gameObject.name);
    55.  
    56.                 if (hitCollider.gameObject.CompareTag("Wall"))
    57.                 {
    58.                     targetGridPos = prevTargetGridPos; // move the player back to their previous position
    59.                     break;
    60.                 }
    61.             }
    62.         }
    63.         else
    64.         {
    65.             targetGridPos = prevTargetGridPos;
    66.         }
    67.     }
    68.  
    69.     void OnCollisionEnter(Collision collision)
    70.     {
    71.         // Check if the collision is with a wall
    72.         if (collision.gameObject.tag == "Wall")
    73.         {
    74.             // Move the player back to their previous position
    75.             targetGridPos = prevTargetGridPos;
    76.         }
    77.     }
    78.  
    79.  
    80.     public void RotateLeft() { if (AtRest) targetRotation -= Vector3.up * 90f; }
    81.     public void RotateRight() { if (AtRest) targetRotation += Vector3.up * 90f; }
    82.     public void MoveForward() { if (AtRest) targetGridPos += 2 * transform.forward; }
    83.     public void MoveBackward() { if (AtRest) targetGridPos -= 2 * transform.forward; }
    84.     public void MoveLeft() { if (AtRest) targetGridPos -= transform.right; }
    85.     public void MoveRight() { if (AtRest) targetGridPos += transform.right; }
    86.  
    87.  
    88.     bool AtRest
    89.     {
    90.         get
    91.         {
    92.  
    93.  
    94.             if ((Vector3.Distance(transform.position, targetGridPos) < 0.05f) &&
    95.                 (Vector3.Distance(transform.eulerAngles, targetRotation) < 0.05f))
    96.                 return true;
    97.             else
    98.                 return false;
    99.         }
    100.     }
    101. }
     
  2. Kurt-Dekker

    Kurt-Dekker

    Joined:
    Mar 16, 2013
    Posts:
    38,520
    You've already identified the parts / steps of what you want, now implement them:

    - read the user intention ("I want to go right!")
    - check the world or map or tiles or whatever you have that defines your player space
    -> if they can move, move them
    -> if they cannot move, ignore the intention

    If you're having difficulty, here is how to report your problem productively in the Unity3D forums:

    http://plbm.com/?p=220

    This is the bare minimum of information to report:

    - what you want
    - what you tried
    - what you expected to happen
    - what actually happened, especially any errors you see
    - links to documentation you used to cross-check your work (CRITICAL!!!)


    If you have no idea what your code is doing, fix that first. Here's how:

    You must find a way to get the information you need in order to reason about what the problem is.

    Once you understand what the problem is, you may begin to reason about a solution to the problem.

    What is often happening in these cases is one of the following:

    - the code you think is executing is not actually executing at all
    - the code is executing far EARLIER or LATER than you think
    - the code is executing far LESS OFTEN than you think
    - the code is executing far MORE OFTEN than you think
    - the code is executing on another GameObject than you think it is
    - you're getting an error or warning and you haven't noticed it in the console window

    To help gain more insight into your problem, I recommend liberally sprinkling
    Debug.Log()
    statements through your code to display information in realtime.

    Doing this should help you answer these types of questions:

    - is this code even running? which parts are running? how often does it run? what order does it run in?
    - what are the values of the variables involved? Are they initialized? Are the values reasonable?
    - are you meeting ALL the requirements to receive callbacks such as triggers / colliders (review the documentation)

    Knowing this information will help you reason about the behavior you are seeing.

    You can also supply a second argument to Debug.Log() and when you click the message, it will highlight the object in scene, such as
    Debug.Log("Problem!",this);


    If your problem would benefit from in-scene or in-game visualization, Debug.DrawRay() or Debug.DrawLine() can help you visualize things like rays (used in raycasting) or distances.

    You can also call Debug.Break() to pause the Editor when certain interesting pieces of code run, and then study the scene manually, looking for all the parts, where they are, what scripts are on them, etc.

    You can also call GameObject.CreatePrimitive() to emplace debug-marker-ish objects in the scene at runtime.

    You could also just display various important quantities in UI Text elements to watch them change as you play the game.

    If you are running a mobile device you can also view the console output. Google for how on your particular mobile target, such as this answer or iOS: https://forum.unity.com/threads/how-to-capturing-device-logs-on-ios.529920/ or this answer for Android: https://forum.unity.com/threads/how-to-capturing-device-logs-on-android.528680/

    If you are working in VR, it might be useful to make your on onscreen log output, or integrate one from the asset store, so you can see what is happening as you operate your software.

    Another useful approach is to temporarily strip out everything besides what is necessary to prove your issue. This can simplify and isolate compounding effects of other items in your scene or prefab.

    Here's an example of putting in a laser-focused Debug.Log() and how that can save you a TON of time wallowing around speculating what might be going wrong:

    https://forum.unity.com/threads/coroutine-missing-hint-and-error.1103197/#post-7100494

    When in doubt, print it out!(tm)

    Note: the
    print()
    function is an alias for Debug.Log() provided by the MonoBehaviour class.