Search Unity

  1. Welcome to the Unity Forums! Please take the time to read our Code of Conduct to familiarize yourself with the forum rules and how to post constructively.
  2. We have updated the language to the Editor Terms based on feedback from our employees and community. Learn more.
    Dismiss Notice

Question How To Get A Field,Type,Value of a variable on another script

Discussion in 'Scripting' started by dublajar, Apr 24, 2023.

  1. dublajar

    dublajar

    Joined:
    Apr 24, 2023
    Posts:
    12
    So basicly i know the basic method of
    GameObject obj = Instantiate((GameObject)this.GetType().GetField(carName + "Prefab").GetValue(this));

    but i need to acces a variable form another script the same way like :

    string y = (string)this.GetType().GetField("data.obj" + x + "_name").GetValue(this);

    how can i do this, i can techicnly create the same variable on the script than access it but it would be pretty boring to do and i think there is a better way for it
     
  2. Kurt-Dekker

    Kurt-Dekker

    Joined:
    Mar 16, 2013
    Posts:
    36,954
    Referencing variables, fields, methods (anything non-static) in other script instances:

    https://forum.unity.com/threads/hel...-vars-in-another-script.1076825/#post-6944639

    https://forum.unity.com/threads/accessing-a-gameobject-in-different-scene.1103239/

    REMEMBER: it isn't always the best idea for everything to access everything else all over the place. For instance, it is BAD for the player to reach into an enemy and reduce his health.

    Instead there should be a function you call on the enemy to reduce his health. All the same rules apply for the above steps: the function must be public AND you need a reference to the class instance.

    That way the enemy (and only the enemy) has code to reduce his health and simultaneously do anything else, such as kill him or make him reel from the impact, and all that code is centralized in one place.
     
  3. dublajar

    dublajar

    Joined:
    Apr 24, 2023
    Posts:
    12
    that didnt really help still thanks alot tho. So since i am getting back some saved data i must access it from there as far as i know, so i cant really referance it like that because there are 22 of the same variables just with the number increasing,
     
  4. dublajar

    dublajar

    Joined:
    Apr 24, 2023
    Posts:
    12
    upload_2023-4-24_22-35-45.png

    i am pretty sure this is not the most effective way but this is how i tried to load up data from savemanagar
     
  5. Kurt-Dekker

    Kurt-Dekker

    Joined:
    Mar 16, 2013
    Posts:
    36,954
    Judging effectiveness is not a thing. If the code works, the code works. Otherwise fix it.

    Photographs of code are also not a thing.

    If you post a code snippet, ALWAYS USE CODE TAGS:

    How to use code tags: https://forum.unity.com/threads/using-code-tags-properly.143875/

    Otherwise, here is how to report your problem productively in the Unity3D forums:

    http://plbm.com/?p=220

    This is the bare minimum of information to report:

    - what you want
    - what you tried
    - what you expected to happen
    - what actually happened, log output, variable values, and especially any errors you see
    - links to documentation you used to cross-check your work (CRITICAL!!!)

    If you need guidance on loading / saving, here's some great starting points:

    Load/Save steps:

    https://forum.unity.com/threads/save-system-questions.930366/#post-6087384

    An excellent discussion of loading/saving in Unity3D by Xarbrough:

    https://forum.unity.com/threads/save-system.1232301/#post-7872586

    Loading/Saving ScriptableObjects by a proxy identifier such as name:

    https://forum.unity.com/threads/use...lds-in-editor-and-build.1327059/#post-8394573

    When loading, you can never re-create a MonoBehaviour or ScriptableObject instance directly from JSON. The reason is they are hybrid C# and native engine objects, and when the JSON package calls
    new
    to make one, it cannot make the native engine portion of the object.

    Instead you must first create the MonoBehaviour using AddComponent<T>() on a GameObject instance, or use ScriptableObject.CreateInstance<T>() to make your SO, then use the appropriate JSON "populate object" call to fill in its public fields.

    If you want to use PlayerPrefs to save your game, it's always better to use a JSON-based wrapper such as this one I forked from a fellow named Brett M Johnson on github:

    https://gist.github.com/kurtdekker/7db0500da01c3eb2a7ac8040198ce7f6

    Do not use the binary formatter/serializer: it is insecure, it cannot be made secure, and it makes debugging very difficult, plus it actually will NOT prevent people from modifying your save data on their computers.

    https://docs.microsoft.com/en-us/dotnet/standard/serialization/binaryformatter-security-guide
     
  6. spiney199

    spiney199

    Joined:
    Feb 11, 2021
    Posts:
    6,015
    It looks like you should just encapsulate your data in a plain C# class and serialise/deserialise it for your save data, rather than using player prefs (which should not be used for save data).