Search Unity

  1. Welcome to the Unity Forums! Please take the time to read our Code of Conduct to familiarize yourself with the forum rules and how to post constructively.
  2. Dismiss Notice

Question How do flap animation get played on keypress?

Discussion in 'Scripting' started by CotaWa, Jul 6, 2023.

  1. CotaWa

    CotaWa

    Joined:
    Jul 5, 2023
    Posts:
    1
    I am super new to Unity and I am trying to make a flappy bird gameand I want is so that when the space bar is pressed it should play the flap animation and when it is falling it should play the fall animation. I have looked in the forums on this site, youtube tutorials and sites on the web but all of them are a couple of years old or uses another version that I dont think uses the same code as in the one I am using. I am using Unity 2021.3.28f1 and here is the code for the bird that should play the animations:
    Code (CSharp):
    1.  
    2. using System.Collections;
    3. using System.Collections.Generic;
    4. using UnityEngine;
    5.  
    6. public class BirdScript : MonoBehaviour
    7. {
    8.     public Rigidbody2D myRigidbody;
    9.     public float flapStrength;
    10.     public LogicScript logic;
    11.     public bool birdIsAlive = true;
    12.     public float deadZoneUp = 15;
    13.     public float deadZoneDown = -15;
    14.  
    15.     // Start is called before the first frame update
    16.     void Start()
    17.     {
    18.         logic = GameObject.FindGameObjectWithTag("Logic").GetComponent<LogicScript>();
    19.     }
    20.  
    21.     // Update is called once per frame
    22.     void Update()
    23.     {
    24.         if (Input.GetKeyDown(KeyCode.Space) == true && birdIsAlive == true)
    25.         {
    26.             myRigidbody.velocity = Vector2.up * flapStrength;
    27.         }
    28.         if (transform.position.y > deadZoneUp || transform.position.y < deadZoneDown)
    29.         {
    30.             birdIsAlive = false;
    31.             logic.gameOver();
    32.         }
    33.     }
    34.  
    35.     private void OnCollisionEnter2D(Collision2D collision)
    36.     {
    37.         logic.gameOver();
    38.         birdIsAlive = false;
    39.     }
    40. }
    41.  
     
  2. Kurt-Dekker

    Kurt-Dekker

    Joined:
    Mar 16, 2013
    Posts:
    36,563
    This will require a full-on tutorial, nothing that someone could fit in this little box. There's no animation or any indication that you have done anything related to the animation integration above.

    Sounds like maybe you're just not doing tutorials correctly.

    Tutorials and example code are great, but keep this in mind to maximize your success and minimize your frustration:

    How to do tutorials properly, two (2) simple steps to success:

    Step 1. Follow the tutorial and do every single step of the tutorial 100% precisely the way it is shown. Even the slightest deviation (even a single character!) generally ends in disaster. That's how software engineering works. Every step must be taken, every single letter must be spelled, capitalized, punctuated and spaced (or not spaced) properly, literally NOTHING can be omitted or skipped.

    Fortunately this is the easiest part to get right: Be a robot. Don't make any mistakes.
    BE PERFECT IN EVERYTHING YOU DO HERE!!


    If you get any errors, learn how to read the error code and fix your error. Google is your friend here. Do NOT continue until you fix your error. Your error will probably be somewhere near the parenthesis numbers (line and character position) in the file. It is almost CERTAINLY your typo causing the error, so look again and fix it.

    Step 2. Go back and work through every part of the tutorial again, and this time explain it to your doggie. See how I am doing that in my avatar picture? If you have no dog, explain it to your house plant. If you are unable to explain any part of it, STOP. DO NOT PROCEED. Now go learn how that part works. Read the documentation on the functions involved. Go back to the tutorial and try to figure out WHY they did that. This is the part that takes a LOT of time when you are new. It might take days or weeks to work through a single 5-minute tutorial. Stick with it. You will learn.

    Step 2 is the part everybody seems to miss. Without Step 2 you are simply a code-typing monkey and outside of the specific tutorial you did, you will be completely lost. If you want to learn, you MUST do Step 2.

    Of course, all this presupposes no errors in the tutorial. For certain tutorial makers (like Unity, Brackeys, Imphenzia, Sebastian Lague) this is usually the case. For some other less-well-known content creators, this is less true. Read the comments on the video: did anyone have issues like you did? If there's an error, you will NEVER be the first guy to find it.

    Beyond that, Step 3, 4, 5 and 6 become easy because you already understand!

    Finally, when you have errors, don't post here... just go fix your errors! Here's how:

    Remember: NOBODY here memorizes error codes. That's not a thing. The error code is absolutely the least useful part of the error. It serves no purpose at all. Forget the error code. Put it out of your mind.

    The complete error message contains everything you need to know to fix the error yourself.

    The important parts of the error message are:

    - the description of the error itself (google this; you are NEVER the first one!)
    - the file it occurred in (critical!)
    - the line number and character position (the two numbers in parentheses)
    - also possibly useful is the stack trace (all the lines of text in the lower console window)

    Always start with the FIRST error in the console window, as sometimes that error causes or compounds some or all of the subsequent errors. Often the error will be immediately prior to the indicated line, so make sure to check there as well.

    Look in the documentation. Every API you attempt to use is probably documented somewhere. Are you using it correctly? Are you spelling it correctly?

    All of that information is in the actual error message and you must pay attention to it. Learn how to identify it instantly so you don't have to stop your progress and fiddle around with the forum.
     
  3. KillDashNine

    KillDashNine

    Joined:
    Apr 19, 2020
    Posts:
    449
    For animations use the Animator component. You'll find many tutorials and for the most part there's nothing wrong with them, you just obviously haven't even tried cos there's no code to trigger any animations.