Search Unity

  1. Welcome to the Unity Forums! Please take the time to read our Code of Conduct to familiarize yourself with the forum rules and how to post constructively.
  2. Dismiss Notice

Question help with Time.deltaTime

Discussion in 'Animation' started by kingdom216, Oct 13, 2022.

  1. kingdom216


    Apr 13, 2021
    When I don't use Time.deltaTime, my character moves freely, but when I put it on it walks and runs in place and doesn't jump. The following is from a tutorial on YouTube by IheartGameDev so please do not ask me why things are used the way they are. My main problem is trying to get the jump animation to work like the walking and running do. To try and fix this I take off TdT and the character moves around the screen and lifts in the air but "jump" doesn't animate, so I put TdT back in the code to see if this might fix this, but like I said the character just runs and walks in place and barely makes a gesture like it's jumping. Please do not respond if your only answer is to google it, because I have exhausted that option. Thank you.

    Code (CShARP):
    2. using System.Collections;
    3. using System.Collections.Generic;
    4. using UnityEngine;
    5. using UnityEngine.InputSystem;
    7. public class AnimationAndMovementController : MonoBehaviour
    8. {
    10.     PlayerInput playerInput;
    11.     CharacterController characterController;
    12.     Animator animator;
    15.     int isWalkingHash;
    16.     int isRunningHash;
    18.     Vector2 currentMovementInput;
    19.     Vector3 currentMovement;
    20.     Vector3 currentRunMovement;
    21.     bool isMovementPressed;
    22.     bool isRunPressed;
    24.     float rotationFactorPerFrame = 15.0f;
    25.     float runMultiplier = 3.0f;
    26.     int zero = 0;
    27.     float gravity = -9.8f;
    28.     float groundedGravity = -.05f;
    30.     bool isJumpPressed = false;
    31.     float initialJumpVelocity;
    32.     float maxJumpHeight = 4.0f;
    33.     float maxJumpTime = .75f;
    34.     bool isJumping = false;
    35.     int isJumpingHash;
    36.     bool isJumpAnimating = false;
    38.     void Awake()
    39.     {
    40.         playerInput = new PlayerInput();
    41.         characterController = GetComponent<CharacterController>();
    42.         animator = GetComponent<Animator>();
    44.         isWalkingHash = Animator.StringToHash("isWalking");
    45.         isRunningHash = Animator.StringToHash("isRunning");
    46.         isJumpingHash = Animator.StringToHash("isJumping");
    48.         playerInput.CharacterControls.Move.started += onMovementInput;
    49.         playerInput.CharacterControls.Move.canceled += onMovementInput;
    50.         playerInput.CharacterControls.Move.performed += onMovementInput;
    51.         playerInput.CharacterControls.Run.started += onRun;
    52.         playerInput.CharacterControls.Run.canceled += onRun;
    53.         playerInput.CharacterControls.Jump.started += onJump;
    54.         playerInput.CharacterControls.Jump.canceled += onJump;
    56.         setupJumpVariables();
    57.     }
    59.     void setupJumpVariables()
    60.     {
    61.         float timeToApex = maxJumpTime / 2;
    62.         gravity = (-2 * maxJumpHeight) / Mathf.Pow(timeToApex, 2);
    63.         initialJumpVelocity = (2 * maxJumpHeight) / timeToApex;
    64.     }
    66.     void handleJump()
    67.     {
    68.         if (!isJumping && characterController.isGrounded && isJumpPressed)
    69.         {
    70.             animator.SetBool("isJumpingHash", true);
    71.             isJumpAnimating = true;
    72.             isJumping = true;
    73.             currentMovement.y = initialJumpVelocity * 1.5f;
    74.             currentRunMovement.y = initialJumpVelocity * 1.5f;
    75.         }
    76.         else if (!isJumpPressed && isJumping && characterController.isGrounded)
    77.         {
    78.             isJumping = false;
    79.         }
    80.     }
    82.     void onJump(InputAction.CallbackContext context)
    83.     {
    84.         isJumpPressed = context.ReadValueAsButton();
    85.         Debug.Log(isJumpPressed);
    86.     }
    88.     void onRun(InputAction.CallbackContext context)
    89.     {
    90.         isRunPressed = context.ReadValueAsButton();
    91.     }
    93.     void handleRotation()
    94.     {
    95.         Vector3 positionToLookAt;
    97.         positionToLookAt.x = currentMovement.x;
    98.         positionToLookAt.y = 0.0f;
    99.         positionToLookAt.z = currentMovement.z;
    100.         Quaternion currentRotation = transform.rotation;
    104.         if (isMovementPressed)
    105.         {
    106.             Quaternion targetRotation = Quaternion.LookRotation(positionToLookAt);
    107.             transform.rotation = Quaternion.Slerp(currentRotation, targetRotation, rotationFactorPerFrame);
    108.         }
    109.     }
    111.     void onMovementInput(InputAction.CallbackContext context)
    112.     {
    113.         currentMovementInput = context.ReadValue<Vector2>();
    114.         currentMovement.x = currentMovementInput.x;
    115.         currentMovement.z = currentMovementInput.y;
    116.         currentRunMovement.x = currentMovementInput.x * runMultiplier;
    117.         currentRunMovement.z = currentMovementInput.y * runMultiplier;
    118.         isMovementPressed = currentMovementInput.x != 0 || currentMovementInput.y != 0;
    119.     }
    121.     void handleAnimation()
    122.     {
    123.         bool isWalking = animator.GetBool(isWalkingHash);
    124.         bool isRunning = animator.GetBool(isRunningHash);
    126.         if (isMovementPressed && !isWalking)
    127.         {
    128.             animator.SetBool(isWalkingHash, true);
    129.         }
    131.         else if (!isMovementPressed && isWalking)
    132.         {
    133.             animator.SetBool(isWalkingHash, false);
    134.         }
    136.         if ((isMovementPressed && isRunPressed) && !isRunning)
    137.         {
    138.             animator.SetBool(isRunningHash, true);
    139.         }
    141.         else if ((!isMovementPressed || !isRunPressed) && isRunning)
    142.         {
    143.             animator.SetBool(isRunningHash, false);
    144.         }
    145.     }
    147.     void handleGravity()
    148.     {
    149.         bool isFalling = currentMovement.y <= 0.0f || !isJumpPressed;
    150.         float fallMultiplier = 2.0f;
    152.         if (characterController.isGrounded) {
    153.             if (isJumpAnimating) {
    154.                animator.SetBool("isJumpingHash", false);  
    155.                isJumpAnimating = false;
    156.             }
    157.             currentMovement.y = groundedGravity * Time.deltaTime;
    158.             currentRunMovement.y = groundedGravity * Time.deltaTime;
    159.         }else if (isFalling) {
    160.            float previousYVelocity = currentMovement.y;
    161.            float newYVelocity = currentMovement.y + (gravity * fallMultiplier * Time.deltaTime);
    162.            float nextYVelocity = (previousYVelocity + newYVelocity) * .5f;
    163.            currentMovement.y = nextYVelocity;
    164.            currentRunMovement.y = nextYVelocity;
    167.         } else {
    168.             float previousYVelocity = currentMovement.y;
    169.             float newYVelocity = currentMovement.y + (gravity);
    170.             float nextYVelocity = (previousYVelocity + newYVelocity) * .5f;
    171.             currentMovement.y = nextYVelocity;
    172.             currentRunMovement.y = nextYVelocity;
    173.         }
    174.     }
    176.     // Update is called once per frame
    177.     void Update()
    178.     {
    179.         handleRotation();
    180.         handleAnimation();
    182.         if (isRunPressed)
    183.         {
    184.             characterController.Move(currentRunMovement * Time.deltaTime);
    185.         }
    186.         else
    187.         {
    188.             characterController.Move(currentMovement * Time.deltaTime);
    189.         }
    190.         handleGravity();
    191.         handleJump();
    192.     }
    194.     void OnEnable()
    195.     {
    196.         playerInput.CharacterControls.Enable();
    197.     }
    199.     void OnDisable()
    200.     {
    201.         playerInput.CharacterControls.Disable();
    202.     }
    203. }
  2. kingdom216


    Apr 13, 2021
    Sure, they come on to tell me that I'm cross posting and "necro" whatever that means. I want help, and all they do is critique. I'm just trying to get help.
  3. kingdom216


    Apr 13, 2021
    I posted on a different thread because it's what came up on google search, then after I posted it I realized the last response was in 2016, so I came here to post a new thread. I tried to delete it on the other thread, but it seems locked. If you're not offering help then don't bother responding.
  4. Kurt-Dekker


    Mar 16, 2013
    You keep doing this and then wondering why people don't respond to you, such as here:

    error CS1061

    and here:

    So set your emotional outbursts aside and realize that we're all trying to help you and we expect you to act like an adult, not a spoiled child.

    If you did Step #2 (understand EVERYTHING about the tutorial) then this wouldn't be an issue.

    if you are attempting to modify a 200+ line character controller while simultaneously defiantly refusing to learn how it works internally, I'm not really sure what anyone can help you with.

    Again, just like the last times I replied to you:

    You must find a way to get the information you need in order to reason about what the problem is.

    Once you understand what the problem is, you may begin to reason about a solution to the problem.

    What is often happening in these cases is one of the following:

    - the code you think is executing is not actually executing at all
    - the code is executing far EARLIER or LATER than you think
    - the code is executing far LESS OFTEN than you think
    - the code is executing far MORE OFTEN than you think
    - the code is executing on another GameObject than you think it is
    - you're getting an error or warning and you haven't noticed it in the console window

    To help gain more insight into your problem, I recommend liberally sprinkling
    statements through your code to display information in realtime.

    Doing this should help you answer these types of questions:

    - is this code even running? which parts are running? how often does it run? what order does it run in?
    - what are the values of the variables involved? Are they initialized? Are the values reasonable?
    - are you meeting ALL the requirements to receive callbacks such as triggers / colliders (review the documentation)

    Knowing this information will help you reason about the behavior you are seeing.

    You can also supply a second argument to Debug.Log() and when you click the message, it will highlight the object in scene, such as

    If your problem would benefit from in-scene or in-game visualization, Debug.DrawRay() or Debug.DrawLine() can help you visualize things like rays (used in raycasting) or distances.

    You can also call Debug.Break() to pause the Editor when certain interesting pieces of code run, and then study the scene manually, looking for all the parts, where they are, what scripts are on them, etc.

    You can also call GameObject.CreatePrimitive() to emplace debug-marker-ish objects in the scene at runtime.

    You could also just display various important quantities in UI Text elements to watch them change as you play the game.

    If you are running a mobile device you can also view the console output. Google for how on your particular mobile target, such as this answer or iOS: or this answer for Android:

    Another useful approach is to temporarily strip out everything besides what is necessary to prove your issue. This can simplify and isolate compounding effects of other items in your scene or prefab.

    Here's an example of putting in a laser-focused Debug.Log() and how that can save you a TON of time wallowing around speculating what might be going wrong:

    When in doubt, print it out!(tm)

    Note: the
    function is an alias for Debug.Log() provided by the MonoBehaviour class.

    NOTE: It may be you did the tutorial incorrectly, so go back and check.

    Tutorials and example code are great, but keep this in mind to maximize your success and minimize your frustration:

    How to do tutorials properly, two (2) simple steps to success:

    Step 1. Follow the tutorial and do every single step of the tutorial 100% precisely the way it is shown. Even the slightest deviation (even a single character!) generally ends in disaster. That's how software engineering works. Every step must be taken, every single letter must be spelled, capitalized, punctuated and spaced (or not spaced) properly, literally NOTHING can be omitted or skipped.

    Fortunately this is the easiest part to get right: Be a robot. Don't make any mistakes.

    If you get any errors, learn how to read the error code and fix your error. Google is your friend here. Do NOT continue until you fix your error. Your error will probably be somewhere near the parenthesis numbers (line and character position) in the file. It is almost CERTAINLY your typo causing the error, so look again and fix it.

    Step 2. Go back and work through every part of the tutorial again, and this time explain it to your doggie. See how I am doing that in my avatar picture? If you have no dog, explain it to your house plant. If you are unable to explain any part of it, STOP. DO NOT PROCEED. Now go learn how that part works. Read the documentation on the functions involved. Go back to the tutorial and try to figure out WHY they did that. This is the part that takes a LOT of time when you are new. It might take days or weeks to work through a single 5-minute tutorial. Stick with it. You will learn.

    Step 2 is the part everybody seems to miss. Without Step 2 you are simply a code-typing monkey and outside of the specific tutorial you did, you will be completely lost. If you want to learn, you MUST do Step 2.

    Of course, all this presupposes no errors in the tutorial. For certain tutorial makers (like Unity, Brackeys, Imphenzia, Sebastian Lague) this is usually the case. For some other less-well-known content creators, this is less true. Read the comments on the video: did anyone have issues like you did? If there's an error, you will NEVER be the first guy to find it.

    Beyond that, Step 3, 4, 5 and 6 become easy because you already understand!

    Finally, when you have errors...

    Remember: NOBODY here memorizes error codes. That's not a thing. The error code is absolutely the least useful part of the error. It serves no purpose at all. Forget the error code. Put it out of your mind.

    The complete error message contains everything you need to know to fix the error yourself.

    The important parts of the error message are:

    - the description of the error itself (google this; you are NEVER the first one!)
    - the file it occurred in (critical!)
    - the line number and character position (the two numbers in parentheses)
    - also possibly useful is the stack trace (all the lines of text in the lower console window)

    Always start with the FIRST error in the console window, as sometimes that error causes or compounds some or all of the subsequent errors. Often the error will be immediately prior to the indicated line, so make sure to check there as well.

    All of that information is in the actual error message and you must pay attention to it. Learn how to identify it instantly so you don't have to stop your progress and fiddle around with the forum.
    Kybernetik likes this.
  5. remcoh


    Sep 10, 2022
    Increase your players speed or speed multiplier or whatever variable you use. * Time.Deltatime creates small numbers