Resolved Help with spawning

Hello, I'm making a endless runner and right now I am trying to make the powerups to spawn but they spawn constantly.

Code (CSharp):

1.     public Transform[] spawnlocations;
2.     public GameObject[] whatToSpawnPrefab;
3.     public GameObject[] whatToSpawnClone;
4.  
5.     public GameObject Player;
6.  
7.     void FixedUpdate()
8.     {
9.         if (Player.transform.position.x > 0)
10.         {
11.             StartCoroutine(spawnSomething());
12.  
13.         }
14.     }
15.  
16.     IEnumerator spawnSomething()
17.     {
18.             whatToSpawnClone[0] = Instantiate(whatToSpawnPrefab[0], spawnlocations[0].transform.position, Quaternion.Euler(0, 0, 0)) as GameObject;
19.  
20.             yield return new WaitForSeconds(10f);
21.     }
22.  
23.  
24.     }

 

Also i have for now 2 prefabs i would also like to know how to make them both spawn 1 or the other but not at the same time.

 

Currently you're starting a new spawn coroutine every frame if the player's x position is > 0.

You could change your coroutine to be an infinite loop, like

Code (CSharp):

1.  
2. IEnumerator spawnSomething()
3.     {
4.            while (true)
5.            {
6.  
7.             whatToSpawnClone[0] = Instantiate(whatToSpawnPrefab[0], spawnlocations[0].transform.position, Quaternion.Euler(0, 0, 0)) as GameObject;
8.  
9.            //Do any condition checks here before spawning
10.             yield return new WaitForSeconds(10f);
11.            }          
12.     }

Then call it with StartCoroutine in Start() instead of FixedUpdate().

 

Code (CSharp):

1. int prefabIndex = Random.Range(0, whatToSpawnPrefab.Length);
2. var prefab = whatToSpawnPrefab[prefabIndex];

 

It's exactly because of the reason @PanicEnsues lists above.

Here is some timing diagram help:

https://docs.unity3d.com/Manual/ExecutionOrder.html

ALSO, anytime you have code that misbehaves, remember this:

You must find a way to get the information you need in order to reason about what the problem is.

What is often happening in these cases is one of the following:

- the code you think is executing is not actually executing at all
- the code is executing far EARLIER or LATER than you think
- the code is executing far LESS OFTEN than you think
- the code is executing far MORE OFTEN than you think
- the code is executing on another GameObject than you think it is

To help gain more insight into your problem, I recommend liberally sprinkling Debug.Log() statements through your code to display information in realtime.

Doing this should help you answer these types of questions:

- is this code even running? which parts are running? how often does it run? what order does it run in?
- what are the values of the variables involved? Are they initialized? Are the values reasonable?
- are you meeting ALL the requirements to receive callbacks such as triggers / colliders (review the documentation)

Knowing this information will help you reason about the behavior you are seeing.

You can also put in Debug.Break() to pause the Editor when certain interesting pieces of code run, and then study the scene

You could also just display various important quantities in UI Text elements to watch them change as you play the game.

If you are running a mobile device you can also view the console output. Google for how on your particular mobile target.

Here's an example of putting in a laser-focused Debug.Log() and how that can save you a TON of time wallowing around speculating what might be going wrong:

https://forum.unity.com/threads/coroutine-missing-hint-and-error.1103197/#post-7100494