Search Unity

Help Me Fix My Code

Discussion in 'Scripting' started by OttoTheDeveloper, Sep 17, 2021.

  1. OttoTheDeveloper

    OttoTheDeveloper

    Joined:
    Sep 17, 2021
    Posts:
    4
    So, I was making a 2D unity game and adding movement and i got 1 error, it says "Assets\PlayerMove.cs(38,1): error CS1022: Type or namespace definition, or end-of-file expected"
    Here is the code.
    Code (CSharp):
    1. using System.Collections;
    2. using System.Collections.Generic;
    3. using UnityEngine;
    4.  
    5. public class PlayerMove : MonoBehaviour
    6. {
    7.     public float moveSeed;
    8.     public Rigidbody2D rigidbody;
    9.  
    10.     private Vector2 moveDirection;
    11.     // Update is called once per frame
    12.     void Update()
    13.     {
    14.         ProcessInputs();
    15.     }
    16. }
    17. void FixedUpdate()
    18.    {
    19.      Move();
    20.    }
    21.  
    22.  
    23.  
    24.    void ProcessInputs()
    25. {
    26.     float moveX = Input.GetAxisRaw("Horizontal");
    27.     float moveY = Input.GetAxisRaw("Vertical");
    28.  
    29.     moveDirection = new Vector2(moveX, moveY);
    30. }
    31.  
    32. void Move()
    33.    {
    34.     rigidbody.velocity = new Vector2(moveDirection.x * moveSpeed, moveDirection.y * moveSpeed);
    35.    }
    36.  
    37.  
    38. }
    39.  
     
  2. flashframe

    flashframe

    Joined:
    Feb 10, 2015
    Posts:
    798
    All variables and methods have to go inside the class definition. On line 16 you've ended the class too early.

    Code (CSharp):
    1. using System.Collections;
    2. using System.Collections.Generic;
    3. using UnityEngine;
    4. public class PlayerMove : MonoBehaviour
    5. {
    6.     public float moveSeed;
    7.     public Rigidbody2D rigidbody;
    8.     private Vector2 moveDirection;
    9.     // Update is called once per frame
    10.     void Update()
    11.     {
    12.         ProcessInputs();
    13.     }
    14.  
    15.    void FixedUpdate()
    16.    {
    17.      Move();
    18.    }
    19.    void ProcessInputs()
    20.    {
    21.     float moveX = Input.GetAxisRaw("Horizontal");
    22.     float moveY = Input.GetAxisRaw("Vertical");
    23.     moveDirection = new Vector2(moveX, moveY);
    24.    }
    25.    void Move()
    26.    {
    27.     rigidbody.velocity = new Vector2(moveDirection.x * moveSpeed, moveDirection.y * moveSpeed);
    28.    }
    29.  
    30. }
     
  3. Kurt-Dekker

    Kurt-Dekker

    Joined:
    Mar 16, 2013
    Posts:
    38,752
    These are just fatfinger typo errors. You can fix them yourself. Here's how:

    Remember: NOBODY memorizes error codes. The error code is absolutely the least useful part of the error. It serves no purpose at all. Forget the error code. Put it out of your mind.

    The complete error message contains everything you need to know to fix the error yourself.

    Always start with the FIRST error in the console window, as sometimes that error causes or compounds some or all of the subsequent errors.

    The important parts of the error message are:

    - the description of the error itself (google this; you are NEVER the first one!)
    - the file it occurred in (critical!)
    - the line number and character position (the two numbers in parentheses)
    - also possibly useful is the stack trace (all the lines of text in the lower console window)

    All of that information is in the actual error message and you must pay attention to it. Learn how to identify it instantly so you don't have to stop your progress and fiddle around with the forum.

    If you plan to monkey-hammer-bang code into your computer, it has to be 100% PERFECT, so keep these steps in mind to save yourself a LOT of time:

    How to do tutorials properly:

    Tutorials are a GREAT idea. Tutorials should be used this way:

    Step 1. Follow the tutorial and do every single step of the tutorial 100% precisely the way it is shown. Even the slightest deviation (even a single character!) generally ends in disaster. That's how software engineering works. Every single letter must be spelled, capitalized, punctuated and spaced (or not spaced) properly. Fortunately this is the easiest part to get right. Be a robot. Don't make any mistakes. BE PERFECT IN EVERYTHING YOU DO HERE.

    If you get any errors, learn how to read the error code and fix it. Google is your friend here. Do NOT continue until you fix the error. The error will probably be somewhere near the parenthesis numbers (line and character position) in the file. It is almost CERTAINLY your typo causing the error, so look again and fix it.

    Step 2. Go back and work through every part of the tutorial again, and this time explain it to your doggie. See how I am doing that in my avatar picture? If you have no dog, explain it to your house plant. If you are unable to explain any part of it, STOP. DO NOT PROCEED. Now go learn how that part works. Read the documentation on the functions involved. Go back to the tutorial and try to figure out WHY they did that. This is the part that takes a LOT of time when you are new. It might take days or weeks to work through a single 5-minute tutorial. Stick with it. You will learn.

    Step 2 is the part everybody seems to miss. Without Step 2 you are simply a code-typing monkey and outside of the specific tutorial you did, you will be completely lost.

    Of course, all this presupposes no errors in the tutorial. For certain tutorial makers (like Unity, Brackeys, Imphenzia, Sebastian Lague) this is usually the case. For some other less-well-known content creators, this is less true. Read the comments on the video: did anyone have issues like you did? If there's an error, you will NEVER be the first guy to find it.

    Beyond that, Step 3, 4, 5 and 6 become easy because you already understand!
     
    flashframe and MoonJellyGames like this.
  4. OttoTheDeveloper

    OttoTheDeveloper

    Joined:
    Sep 17, 2021
    Posts:
    4
    Thank You! I needed this help.
     
  5. OttoTheDeveloper

    OttoTheDeveloper

    Joined:
    Sep 17, 2021
    Posts:
    4
    When i use this code i get even more errors then my code.
     
  6. Kurt-Dekker

    Kurt-Dekker

    Joined:
    Mar 16, 2013
    Posts:
    38,752
    If you get "even more errors", you're going to have to go "even more" up to what I posted the first time.

    Why? Because you're still not spelling the words properly and the compiler is telling you EXACTLY which one is wrong.

    It's not like they're different errors, they're just ... errors. Go fix them.
     
  7. BABIA_GameStudio

    BABIA_GameStudio

    Joined:
    Mar 31, 2020
    Posts:
    497
    Because your original error was blocking all others from being found. Now that you have more, if you want help you will need to tell us what the errors say (or you can work through them and fix them one at a time yourself).
    But at a first glance you have defined a variable called
    moveSeed
    but then try referring to it as
    moveSpeed
    later on in the script.
     
    flashframe and Kurt-Dekker like this.
  8. OttoTheDeveloper

    OttoTheDeveloper

    Joined:
    Sep 17, 2021
    Posts:
    4
    Oh, That was the error, i never realised that.