Search Unity

[HDRP 7.0] Edge leak fixup is missing

Discussion in 'High Definition Render Pipeline' started by iamarugin, Sep 15, 2019.

  1. iamarugin

    iamarugin

    Joined:
    Dec 17, 2014
    Posts:
    173
    Edge leak fixup is disappeared from the Directional light. Where did it go? How to fight with the edge leaks now?
     
  2. iamarugin

    iamarugin

    Joined:
    Dec 17, 2014
    Posts:
    173
  3. Mbot

    Mbot

    Joined:
    Jun 10, 2013
    Posts:
    13
    Yea just noticed this as well, on all lights i think.
     
  4. iamarugin

    iamarugin

    Joined:
    Dec 17, 2014
    Posts:
    173
  5. francescoc_unity

    francescoc_unity

    Unity Technologies

    Joined:
    Sep 19, 2018
    Posts:
    9
    The edge leak fixup was used for fixing up issues coming from the view bias, that code is now gone since it was fairly expensive and we have now only constant bias (was not present before, be certain to tweak it up to liking) and normal bias. Edge leaks similar to what was there before should not be present, you are sure you are not issues with lack of resolution or peter panning?
     
  6. iamarugin

    iamarugin

    Joined:
    Dec 17, 2014
    Posts:
    173
    I've increased resolution to from 1536 to 4096 but it has no effect.
    Here how it looks like

    Here is Directional light settings:

    Here is shadow settings from HDRP config

    The only way I found so far to eliminate this edge leak, is to decrease Constant Depth Bias to zero. But than I got artifacts in other scenes.
     
  7. francescoc_unity

    francescoc_unity

    Unity Technologies

    Joined:
    Sep 19, 2018
    Posts:
    9
    I don't seem to be able to repro a similar case with the geometry I have at hand, could you please create a repro scene and send it over?
     
    Last edited: Sep 24, 2019
  8. iamarugin

    iamarugin

    Joined:
    Dec 17, 2014
    Posts:
    173
    I will try to
     
  9. iamarugin

    iamarugin

    Joined:
    Dec 17, 2014
    Posts:
    173
    I opened the Case 1186630 with the minimum repro project.
     
  10. francescoc_unity

    francescoc_unity

    Unity Technologies

    Joined:
    Sep 19, 2018
    Posts:
    9
    Ok had a quick look,

    For your specific case, I think the issue is coming from the fact that your walls are planes with no thickness, this might lead to issues like this when rendering the shadow map. The edge leak fixup fixed this, even though was there mainly to combat the issues caused by what was called View Bias before (that was removed due to its high cost).

    I suggest one of the following for your case:
    - Having a thickness to your walls.
    - Use contact shadows.
    - (Bit of a cheeky answer, but it is a surprisingly common thing in production) Hide some shadow casters in the walls :p

    If none of the above work for you, let me know.
     
    Last edited: Sep 25, 2019
  11. iamarugin

    iamarugin

    Joined:
    Dec 17, 2014
    Posts:
    173
    Thanks for suggestions, I will try it out!