Bug Havok infinite loop when Use Job Threads disabled (with fix)

Turning off Job Threads for some testing

When I have Havok Physics selected

causes my editor to lock up and go into an infinite loop.

Switching back to Unity Physics and turning off Job Threads works fine.



I'm pretty sure your issue is HavokSimulation.cs:163

Code (CSharp):

1. private int NumberOfThreads => JobsUtility.JobWorkerCount - 1;

this needs to be

Code (CSharp):

1. private int NumberOfThreads => math.max(1, JobsUtility.JobWorkerCount - 1);

Alternatively this also appears like it would fail on a 2 core machine, are you sure it's not meant to be +1 like Unity.Physics uses.
Broadphase.cs:162

Code (CSharp):

1. // +1 for main thread
2. int threadCount = JobsUtility.JobWorkerCount + 1;

Seems odd to intentionally leave an empty worker thread?