Gun and Target not working, please help [ANSWERED BELOW]

I have been following this code by Brackeys and for the past 8 hours I have not been able to solve it. It won't work but it used to work until version 2018. Please help

Code (CSharp):

1. using System.Collections;
2. using System.Collections.Generic;
3. using UnityEngine;
4.  
5. public class Gun : MonoBehaviour {
6.  
7.     public float damage = 10f;
8.     public float range = 100f;
9.  
10.     public GameObject fpsCam;
11.    
12.     // Update is called once per frame
13.     void Update () {
14.        
15.  
16.         if (Input.GetButtonDown("Fire1"))
17.         {
18.             Shoot();
19.         }
20.  
21.     }
22.  
23.     public void Shoot ()
24.     {
25.         RaycastHit hit;
26.         if (Physics.Raycast(fpsCam.transform.position, fpsCam.transform.forward, out hit, range));
27.         {
28.             Target target = hit.transform.GetComponent<Target>();
29.             if (target != null)
30.             {
31.                 target.TakeDamage(damage);
32.             }
33.         }
34.     }
35. }

That is the code for the Gun and the following is the target.

Code (CSharp):

1. using System.Collections;
2. using System.Collections.Generic;
3. using UnityEngine;
4.  
5. public class Target : MonoBehaviour {
6.  
7.     public float health = 50f;
8.  
9.     public void TakeDamage(float amount)
10.     {
11.         health -= amount;
12.         if (health <= 0f)
13.         {
14.             Die();
15.         }
16.     }
17.  
18.     void Die ()
19.     {
20.         Destroy(gameObject);
21.     }
22. }
23.  

 

Do you get any errors?
If not, put a debug in the update and see if it is picking up the GetButtonDown.

 

Yeah I get "Null Reference Exception: Object Reference not set to instance of an object"

 

I did that, but it didn't work

 

It will also give you the line number where the null reference occurred, which is needed to figure out which one it is.

 

line 28

 

That's probably because you are hitting something that doesn't have a Target script attached. Put a debug here:

Code (csharp):

1.  
2. [LIST=1]
3. [*]            if (target != null)
4. [*]            {
5. [*]                target.TakeDamage(damage);
6. [*]                Debug.Log("target message sent");
7. [*]            }
8. [/LIST]
9.  

Then make sure you are firing on the target at a close enough range, and see if you get the Debug print.

 

Okay, I will test it

 

I tested it, and it still doesn't work. I get the same error. I am thinking it could be a bug in unity as this code has always worked before flawless

 

And it does a have the "Target" script attached

 

Try this:
Be sure to comment out the other code and then add the debug

1. {
2. // Target target = hit.transform.GetComponent<Target>();
3. // if (target != null)
4. // {
5. // target.TakeDamage(damage);
6. // }
7. Debug.Log(hit.transform.gameObject.name);
8. }

 

Okay, that did work

 

Did it print the name of the target object?

 

Yes

 

and now it does not work, It printed the name of the gameobject, but now it is not working and gives me the same error

 

Is it pointing to the hit line with the debug on it?

 

its pointing to the line with Debug.Log(hit.transform.gameObject.name);

 

then just try:
Debug.Log(hit.transform);

 

That worked, even if I restart it. It prints out "Null"

 

Paste the shoot function again, with the changes.

 

Code (CSharp):

1. public void Shoot ()
2.     {
3.         RaycastHit hit;
4.         if (Physics.Raycast(fpsCam.transform.position, fpsCam.transform.forward, out hit, range));
5.         {
6.            // Target Target = hit.transform.GetComponent<Target>();
7.            // if (Target != null)
8.             //{
9.                // Target.TakeDamage(damage);
10.                 Debug.Log("target message sent");
11.             Debug.Log(hit.transform);
12.  
13.  
14.             // }
15.         }
16.     }
17. }

 

Take the semicolon off of this line at the end:
if (Physics.Raycast(fpsCam.transform.position, fpsCam.transform.forward, out hit, range));

Then try it again.

 

should I put back the Target function?

 

I did, and everything inside RaycastHit hit; did not function. Other than that it it worked

 

Paste what it looks like now.

 

Code (CSharp):

1. using System.Collections;
2. using System.Collections.Generic;
3. using UnityEngine;
4.  
5. public class Gun : MonoBehaviour {
6.  
7.     public float damage = 10f;
8.     public float range = 100f;
9.  
10.     public GameObject fpsCam;
11.    
12.     // Update is called once per frame
13.     void FixedUpdate () {
14.        
15.  
16.         if (Input.GetButtonDown("Fire1"))
17.         {
18.             Shoot();
19.             Debug.Log("i shot the gun");
20.         }
21.  
22.     }
23.  
24.     public void Shoot ()
25.     {
26.         RaycastHit hit;
27.         if (Physics.Raycast(fpsCam.transform.position, fpsCam.transform.forward, out hit, range))
28.         {
29.            // Target Target = hit.transform.GetComponent<Target>();
30.            // if (Target != null)
31.             //{
32.                // Target.TakeDamage(damage);
33.                 Debug.Log("target message sent");
34.             Debug.Log(hit.transform);
35.  
36.  
37.             // }
38.         }
39.     }
40. }

 

Put the
Debug.Log(hit.transform.gameObject.name);
Then run it and see if it prints the object name.

 

It didn't work, it only prints Debug.Log("i shot the gun");

 

You did a save before trying?
Check if the object has a collider on it.
Otherwise, drop a cube with a collider in the scene and try firing at it, making sure it has a collider.

 

Yes, I saved it. I think its a bug in Unity. Sorry If I am wasting your time sir or ma'am

 

and they do have colliders

 

They would have checked something like that before putting it out there because it's so common. How big is your project? Can you strip it down to just a small project with a cube and post it somewhere? My guess is that it's just not hitting the object for some reason.

 

It is very small, just 2 cubes and a terrain and the first person controller and the gun. I will post it.

 

what is your email? I can probably email the project to you

 

OK.

 

I'll PM my email.

 

ANSWER: Use a camera instead of a gameobject for FpsCam