Search Unity

  1. Welcome to the Unity Forums! Please take the time to read our Code of Conduct to familiarize yourself with the forum rules and how to post constructively.
  2. Dismiss Notice

Question Got two error while trying to make player movement in a 2D template

Discussion in 'Scripting' started by Nycticc, Oct 6, 2023 at 1:29 PM.

  1. Nycticc

    Nycticc

    Joined:
    Friday
    Posts:
    3
    I got two error called "Assets\PlayerMovement.cs(26,13): error CS0019: Operator '&&' cannot be applied to operands of type 'bool' and 'float'" and "Assets\PlayerMovement.cs(26,63): warning CS0642: Possible mistaken empty statement"

    can anyone help please?
    here is my code:

    Code (CSharp):
    1. using System.Collections;
    2. using System.Collections.Generic;
    3. using UnityEngine;
    4.  
    5. public class PlayerMovement : MonoBehaviour
    6. {
    7.     private float horizontal;
    8.     private float speed = 8f;
    9.     private float jumpingPower = 16f;
    10.     private bool isFacingRight = true;
    11.  
    12.     [SerializeField] private Rigidbody2D rb;
    13.     [SerializeField] private Transform groundCheck;
    14.     [SerializeField] private LayerMask groundLayer;
    15.  
    16.     // Update is called once per frame
    17.     void Update()
    18.     {
    19.         horizontal = Input.GetAxisRaw("Horizontal");
    20.  
    21.         if (Input.GetButtonDown("Jump") && IsGrounded())
    22.         {
    23.             rb.velocity = new Vector2(rb.velocity.x, jumpingPower);
    24.         }
    25.  
    26.         if (Input.GetButtonUp("Jump") && rb.velocity.y * 0.5f);
    27.         {
    28.             rb.velocity = new Vector2(rb.velocity.x, rb.velocity.y * 0.5f);
    29.         }
    30.  
    31.         Flip();
    32.     }
    33.  
    34.  
    35.     private void FixedUpdate()
    36.     {
    37.         rb.velocity = new Vector2(horizontal * speed, rb.velocity.y);
    38.     }
    39.  
    40.     private bool IsGrounded()
    41.     {
    42.         return Physics2D.OverlapCircle(groundCheck.position, 0.2f, groundLayer);
    43.     }
    44.  
    45.     private void Flip()
    46.     {
    47.         if (isFacingRight && horizontal < 0f || !isFacingRight && horizontal > 0f)
    48.         {
    49.             isFacingRight = !isFacingRight;
    50.             Vector3 localScale = transform.localScale;
    51.             localScale.x *= -1f;
    52.             transform.localScale = localScale;
    53.         }
    54.     }
    55. }
    56.  



    I tried looking in line 26 but I didnt see anything wrong
     
  2. MelvMay

    MelvMay

    Unity Technologies

    Joined:
    May 24, 2013
    Posts:
    10,329
    What do you expect line 26 to do then? It doesn't make sense.
    Code (CSharp):
    1. Input.GetButtonUp("Jump") && rb.velocity.y * 0.5f)
    It's like me saying, "If I want to jump and 3." The "and 3" bit isn't a true/false condition! "&&" is saying if both conditions are true. The second part isn't a condition.

    Input.GetButtonUp("Jump") is true/false
    rb.velocity.y * 0.5 is a float value NOT true/false.

    It's up to you but I would recommend that for these kinds of issues including your previous issue, that you post on the Getting Started forum.



     
  3. Kurt-Dekker

    Kurt-Dekker

    Joined:
    Mar 16, 2013
    Posts:
    36,283
    You don't have to post repeatedly to a forum to fix your own typing mistakes... just go fix them. Here's how:

    Remember: NOBODY here memorizes error codes. That's not a thing. The error code is absolutely the least useful part of the error. It serves no purpose at all. Forget the error code. Put it out of your mind.

    The complete error message contains everything you need to know to fix the error yourself.

    The important parts of the error message are:

    - the description of the error itself (google this; you are NEVER the first one!)
    - the file it occurred in (critical!)
    - the line number and character position (the two numbers in parentheses)
    - also possibly useful is the stack trace (all the lines of text in the lower console window)

    Always start with the FIRST error in the console window, as sometimes that error causes or compounds some or all of the subsequent errors. Often the error will be immediately prior to the indicated line, so make sure to check there as well.

    Look in the documentation. Every API you attempt to use is probably documented somewhere. Are you using it correctly? Are you spelling it correctly? Are you structuring the syntax correctly? Look for examples!

    All of that information is in the actual error message and you must pay attention to it. Learn how to identify it instantly so you don't have to stop your progress and fiddle around with the forum.

    Tutorials and example code are great, but keep this in mind to maximize your success and minimize your frustration:

    How to do tutorials properly, two (2) simple steps to success:

    Step 1. Follow the tutorial and do every single step of the tutorial 100% precisely the way it is shown. Even the slightest deviation (even a single character!) generally ends in disaster. That's how software engineering works. Every step must be taken, every single letter must be spelled, capitalized, punctuated and spaced (or not spaced) properly, literally NOTHING can be omitted or skipped.

    Fortunately this is the easiest part to get right: Be a robot. Don't make any mistakes.
    BE PERFECT IN EVERYTHING YOU DO HERE!!


    If you get any errors, learn how to read the error code and fix your error. Google is your friend here. Do NOT continue until you fix your error. Your error will probably be somewhere near the parenthesis numbers (line and character position) in the file. It is almost CERTAINLY your typo causing the error, so look again and fix it.

    Step 2. Go back and work through every part of the tutorial again, and this time explain it to your doggie. See how I am doing that in my avatar picture? If you have no dog, explain it to your house plant. If you are unable to explain any part of it, STOP. DO NOT PROCEED. Now go learn how that part works. Read the documentation on the functions involved. Go back to the tutorial and try to figure out WHY they did that. This is the part that takes a LOT of time when you are new. It might take days or weeks to work through a single 5-minute tutorial. Stick with it. You will learn.

    Step 2 is the part everybody seems to miss. Without Step 2 you are simply a code-typing monkey and outside of the specific tutorial you did, you will be completely lost. If you want to learn, you MUST do Step 2.

    Of course, all this presupposes no errors in the tutorial. For certain tutorial makers (like Unity, Brackeys, Imphenzia, Sebastian Lague) this is usually the case. For some other less-well-known content creators, this is less true. Read the comments on the video: did anyone have issues like you did? If there's an error, you will NEVER be the first guy to find it.

    Beyond that, Step 3, 4, 5 and 6 become easy because you already understand!

    Finally, when you have errors, don't post here... just go fix your errors! See above.