Search Unity

Bug GetBuffer ReadOnly mode doesn't work after release packaging

Discussion in 'Entity Component System' started by MasterSais, Jun 4, 2023.

  1. MasterSais

    MasterSais

    Joined:
    Mar 10, 2023
    Posts:
    2
    Using Entities v1.0.10. Readonly mode for GetBuffer doesn't work after building, because of this: upload_2023-6-4_13-50-35.png
    in Release mode the second block 'ENABLE_UNITY_COLLECTIONS_CHECKS' removed with isReadOnly flag, but it must be passed as a parameter of access->GetBuffer
     
    MasterSais, Jun 4, 2023
    #1

  2. MasterSais

    MasterSais

    Joined:
    Mar 10, 2023
    Posts:
    2
    Screenshot from file EntityManager.cs
     
    MasterSais, Jun 4, 2023
    #2

  3. cort_of_unity

    cort_of_unity

    Unity Technologies

    Joined:
    Aug 15, 2018
    Posts:
    98
    Thank you for the report! This issue was found & fixed independently several weeks back, and will be fixed in a future Entities release.
     
    cort_of_unity, Jul 18, 2023
    #3
    sklimenko likes this.

  4. tertle

    tertle

    Joined:
    Jan 25, 2011
    Posts:
    3,761
    This appears like it still wasn't fixed in 1.0.14?
     
    tertle, Aug 11, 2023
    #4

  5. cort_of_unity

    cort_of_unity

    Unity Technologies

    Joined:
    Aug 15, 2018
    Posts:
    98
    Arrgh, you're right; it looks like this fix wasn't backported all the way into the 1.0.14 release branch. Sorry about that. I'll backport it now to make sure it's included in the next batch.
     
    cort_of_unity, Aug 11, 2023
    #5