for loop issue. It must be something obvious...

So this snippet of code is intended to add a basic turret object to my inventory.

Code (CSharp):

1. public void addBasicTurret()
2.     {
3.         invItem basicTurret = new invItem("Basic Turret", basicTurretGameobject, basicTurretSprite, true);
4.         if (GameControl.GetComponent<Inventory>().isUnique("Basic Turret") == true)
5.         {
6.             Debug.Log(GameControl.GetComponent<Inventory>().getEmptyIndex());
7.             GameControl.GetComponent<Inventory>().addInvItem(GameControl.GetComponent<Inventory>().getEmptyIndex(), basicTurret);
8.         }
9.         else
10.         {
11.             Debug.Log("we already have this item");
12.         }
13.    
14.     }

Basically I create an InvItem, then send it to my inventory script in the method called addInvItem() here:

Code (CSharp):

1. public void addInvItem(int index, invItem inItem)
2.     {
3.         for(int i = 0; i <= invItems.Length; i++)
4.         {
5.             if (i == index)
6.             {
7.                 invItems[index] = inItem;
8.                 invHudImages[index].GetComponentInChildren<Image>().sprite = inItem.hudSprite;
9.  
10.             }
11.         }
12.     }

. I also have getEmptyIndex() which finds the next open inventory slot and returns its index.

Code (CSharp):

1. public int getEmptyIndex()
2.     {
3.         for(int i = 0; i <= invItems.Length; i++)
4.         {
5.             if(invItems[i].itemName == "")
6.             {
7.                 return i;
8.             }
9.         }
10.         return -1;
11.     }

However, when I go to my store and buy an item (which calls addBasicTurret), it puts the item in the wrong slot of my inventory array. The inventory is empty, so the item should be added to slot 0, but instead it's being added to the 9th slot in my inventory.

What's going on here?

 

How is the invItem array initialized? Are you sure gerEmptyIndex returns 0? That string check in there is a bit dodgy. Usually you would test if the array contains null at that index. But if it is a serialized array theres usually the data assigned in the inspector there already.

 

getEmptyIndex is working fine, it returns zero when nothing is in the array. It's a serialized array so I can't look for null, otherwise I'd use that instead.

invItems is initialized like any normal array, containing invItem objects that have things like textures in their constructor.

 

Out of curiosity, in addInvItem, why are you looping through the array at all? Why not just directly set invItems[index] to what you need?

 

Because items might be bought in any order, and they need to go to wherever the first empty slot is.

I figured it out, I'm so dumb. In my array I accidentally had everything flipped. Everything was working fine, but my UI Image for my 1st inventory slot was actually where 10 should be, ect ect.

 

That explains why you loop in getEmptyIndex, yes. But in addInvItem, you don't put it in the first empty slot. You put it in whatever index is sent to that function. Once getEmptyIndex finds the index, you can just go straight there.

 

Wow I didn't even think of that. I fixed it and it cut out a few lines of code. Thanks for pointing that out.