[Fixed in 2021.2] ShadowCaster2D memory leak?

Hi everybody, I'm using Unity 2020.2.1 on Windows 10 and something strange has just happened. I played the game in the editor (the scene has several 2D lights and shadow casters) and then I went to have lunch, without stopping it. When I came back I found that the occupied memory was over 1,6 Gb (too much for a 2D game with just a few assets) and that the game was jittering every 2 seconds. I took a look to the CPU usage in the profiler and found that the spikes were caused by a memory collection in the ShadowCaster2D.Update() method (>700ms). I also saw that the same method allocates 115KB every frame.

I have attached a picture and the profiler data just in case it is useful.

 

When I stopped the game, the Editor kept jittering. May it be something related to how shadowcasters work in editor mode?

 

I don't know whether it is related, but I see in the Update() code a lot of calls to GetComponent which, in case of returning null, make unnecessary memory allocations AFAIK, which makes TryGetComponent a better option. Anyway I don't think this can generate 100KB of garbage.

 

No, but I will try

 

I've enabled GCAlloc callstacks and Deep profiling. The call stacks did not provide useful information but the Deep profiling did. It appears I was right, although I thought it was not possible, the problem is the GetComponent calls.



There you can see 2 allocations done in GetComponent: one of 78.4KB and other of 37.2KB.

 

Hi, yes I did. But this is what I get, am I doing something wrong?

 

Ok no problem, thank you for the time you are spending on this, I'm going to build the project and profile without the editor, just to discard stuff.

 

It seems to be an Editor issue, it does not happen in the build. The ShaderCaster2Ds are not allocating memory.

 

I'm attaching a sample project that reproduces the problem.

 

Hi Martin, I've already reported it. And included also a link to this thread in the report.
They could not reproduce it so I've sent them the same project.

 

They could reproduce it, the bug is here: https://issuetracker.unity3d.com/is...dot-8-kb-of-garbage-every-frame-in-the-editor

 

UPDATE: Unity programmers have fixed the issue, I received the following by email:

"A fix for this issue is now available on Universal RP package 12.0.0 and above. This package version is available in Unity 2021.2.0a9 and above."

Thank you!

 

I would be WONDERFUL if this was back-ported (is that the right term?) to 2020.2

Thanks for the fix

 

That would be amazing, thank you.

 

Hey, sorry to tag on here but what about 2019 LTS? Is this version left out for good in terms of URP fixes? We're still having 2D lights allocating garbage every frame

 

Was this ever backported, I am using 2020.3.29 and can still reproduce