Feedback Wanted: Shader Graph

Thank you! I downloaded the MasterMerge branch and it works with HDRP.

 

This should go without saying for anyone who tries this but - Don't rush back to this thread to post bugs and things like that. They didn't officially release anything or asked for feedback on this yet. They are still working on this and problems you might run into might already have a fix in the works, already known, etc. (just saying)

 

I am having lots of fun tinkering around with ShaderGraph, however when I build and run my project, my scene is invisible.

Renders fine when I run inside the editor, any tips on why Build and Run isn't working? Is it not meant to at this point?

 

Hello, I am trying to make a MMORPG and I wanna use Shader Graph for player customization material.

The Problem I am running to is that I can't change any value from code, it just doesnt work like it does before so I am asking if there where some changes to that, like new calls from code or it's just not supported right now.

Thanks

 

Properties are generated by ShaderGraph, in order to set it from the code, you have to put the Inspector in Debug Mode and retrieve the value for the property you want to modify.

Its located under Parsed Info -> Prop Info -> Props.

I had to do it for one of my effect here:
https://github.com/andydbc/unity-sh...ssets/Examples/Pixelate/PixelateController.cs

 

Correct me if I'm wrong but isn't this also a way to get the proper names for set properties? Just select the shader file and it shows the properties you added and the converted names it's using

 

That works too

 

Ah ok cool, I was wondering if the Debug Inspector version was different. Didn't even know that existed in Unity.

 

Hello, May I ask if there is a way the parameter on shader graph editor can be accessible by "Shader.setGlobalVector"
so that script can access to set the variable globally. any suggestion?

 

Thank you guys for help, both ways are working. I didnt know it changes the property name after saving shader and where to find converted one. If anybody have same issue just look where you can find the property name.

 

Please make a version that works with the built-in pipeline.

 

Hi,

I am trying to create a material that replaces Sprites-Default (to be used by a SpriteRenderer). The material is working fine applied anywhere else, but Sprite Renderer warns me that I dont have the _MainTex texture property. I created one and named it accordingly, but nothing...

Any clue? Thanks a lot!

 

I've been using Shader Graph a little for the past few weeks and something that really bothers me using it more than using anything else in Unity is the fact that, to put it quite bluntly, the "pseudo-maximize window" function is terrible. (Talking about Windows here, as I have no experience using Unity on MacOS)

I know this is something more about the Unity Editor than Shader Graph itself, but Shader Graph is perhaps the most annoying example of when this gets in the way, simply for the fact that it pretty much requires it to be functional (the Animator Window also suffers a little, but since the long awaited Zoom it's not that much of a hassle there), as the functionality depends on looking at the nodes, which use a lot of space in the window.

I think a lot of people would agree with this, and it seems like the Unity Team itself also realises it, evidence being the fact that now the maximize option actually makes the window touch the borders of the screen:

Unity 2017:


Unity 2018:


Again, I realize this is probably not the best place to talk about something as general and I plan on taking this to a broader topic, but in the specific case of ShaderGraph I think it's hurting more than anywhere else, regarding only the Unity-native tools.

In my opinion the ideal solution would be something along the lines of what UE4 does, that is, treating Custom Windows (Editors) as separate native OS windows overall, not just tabs; these editors, themselves, work something along the lines of Unity Editor's Layouts, having their own presets for Tabs (Unity's Windows). These Editors also work as different kinds of tabs, which work like browser tabs.

Essentially, this is what I wanted to be able to do in Unity, and think ShaderGraph (and Animator) are hurting by not being able to do as well:

 

Same here. Trying Shader Graph to work with sprites but no success.

 

Seems to be related to the automatic naming the properties as they say in previous comments. But I still don't know if there is a way to solve this issue. In my case _MainTex becomes Texture_CFFCB8AD

 

Thanks! That was it.

 

Hi, when you say "it is possible" could you please give us some guidelines about how to achieve it? On this thread I just posted a reply about the closest I was able to get https://forum.unity.com/threads/are-sprites-not-supported-by-the-srp-shader-graph.526280/

 

Hi. I had a subgraph made, and I don't know what exactly I did, but I'm unable to open it now. I get a gray shadergraph window, and a nullreference exception in the console:

UnityEditor.ShaderGraph.Drawing.Slots.MultiFloatSlotControlView..ctor (INode node, System.String[] labels, System.Func`1 get, System.Action`1 set) (at C:/ProgramData/Unity/cache/packages/packages.unity.com/com.unity.shadergraph@1.1.2-preview/Editor/Drawing/Views/Slots/MultiFloatSlotControlView.cs:23)

UnityEditor.ShaderGraph.Vector4MaterialSlot.InstantiateControl () (at C:/ProgramData/Unity/cache/packages/packages.unity.com/com.unity.shadergraph@1.1.2-preview/Editor/Data/Graphs/Vector4MaterialSlot.cs:52)

UnityEditor.ShaderGraph.Drawing.PortInputView..ctor (UnityEditor.ShaderGraph.MaterialSlot slot) (at C:/ProgramData/Unity/cache/packages/packages.unity.com/com.unity.shadergraph@1.1.2-preview/Editor/Drawing/Views/PortInputView.cs:51)

UnityEditor.ShaderGraph.Drawing.MaterialNodeView.UpdatePortInputs () (at C:/ProgramData/Unity/cache/packages/packages.unity.com/com.unity.shadergraph@1.1.2-preview/Editor/Drawing/Views/MaterialNodeView.cs:341)

Thankfully it was a small graph I have since re-made, and it still worked after, just wasn't accessible. (even got a message from windows prompting which program should open the file).

Loving the utility so far, it's a great learning tool. If I could make a suggestion, maybe colored regions you can put in the background just to add some organization. My thinking is you could create a colored square holding all the nodes that perform one task, and name the section accordingly. I know, for me, I can already foresee looking through old graphs and wishing I had done some kind of organization to this sort.

Also, it would be nice to just have control anchors for the node-to-node lines, or an option to have them path around other nodes to remain horizontal/vertical. Tiny, very minimal, but I find diagonal lines aesthetically displeasing, and am taking a good amount of time to avoid them.

Edit:
Another subgraph just had the same issue. NullReferenceException.

The subgraph still works to add as a node in the main graph, but I can no longer open the subgraph to edit it.

I'm worried this will keep happening, so I'd like to know what I'm doing wrong, or if there is a way to fix this.Subgraphs seem very useful, but only if they will be more stable.

 

Does ShaderGraph support shader_feature or multi_complie？

 

Hi.

Any idea what following error means?
I am on latest Unity beta 13, with imported shader graphs via manager.

Code (CSharp):

1. Assertion failed: Assertion failed on expression: 'success'
2. UnityEditor.EditorApplication:Internal_CallUpdateFunctions()

Double click do not navigate, to place, where error may occur. In fact double click on this error in console does nothing.

Edit 1:
Sometimes pressing mouse middle button stop moving the graph work space.
But closing and reopening graph resolves the problem.

 

Hi there,
I don't have access to the 2018 beta but I was wondering, could we please have the same keyboard shortcuts for panning and zooming as in the scene view? It's different in the new 'zoomable' Animator Controller and it's really frustrating.

 

In addition to these options, does Shader Graph support the following features?

- GrabPass (I know some solution was under development but how is it going?)
- Multi-Pass
- Loops
- Geometry Shaders
- VR

Thanks.

 

I would be interested in seeing this as either a per-window option, or a unity-wide setting, but I actually like the current behavior of Unity tab windows and would like to retain that.

 

Unity's tabs are pretty much exactly a subset of Unreal's. It's worth having a look at UE4, if you haven't done it already. In terms of UX I can't really imagine Unity taking any hit by implementing something like this.

Even if they would reimplement some stuff (that Avatar editing layout that opens up and closes your scene, for example), this behaviour is very intuitive. After all, it is what web browsers do. If you think web browser tabs containing current Unity tabs, there is little extra complication outside of custom scripting of said Container Tabs for very specific tools.

 

Actually I love the way UE4 multi-window management works.I have seen it with Visual Studio 2017 editor. It is a blast to work with 2 monitors. Unity editor uses the default multi-window management that you will find in visual frameworks (Qt, Gtk, xWidgets,WPF/.Net, etc). I have been trying to reproduce that behavior with Qt, Gtk and WPF/.Net but with no success. I have also seen that CryEngine V editor that uses qt has the same behavior.
The only thing I don't like about this on Unity editor is that on windows 10, a full-screen tab window on a secondary monitor has a 2-4 pixel border that is transparent through which I can see background at first making me think that is was not full-screen. I think that the separate window is wrongly initialized. You can see the blue background on the sides of the window.

 

Hi I wanted to try Shadergraph, but it doesn't work in 2018.2.0b1 and previous 2018.1.0b13

Preview shader for graph has 1 error:
Shader compilation error in graph at line 9 (on d3d11):
failed to open source file: 'CoreRP/ShaderLibrary/Common.hlsl'
Compiling Vertex program
Platform defines: UNITY_ENABLE_REFLECTION_BUFFERS UNITY_USE_DITHER_MASK_FOR_ALPHABLENDED_SHADOWS UNITY_PBS_USE_BRDF1 UNITY_SPECCUBE_BOX_PROJECTION UNITY_SPECCUBE_BLENDING UNITY_ENABLE_DETAIL_NORMALMAP SHADER_API_DESKTOP UNITY_COLORSPACE_GAMMA UNITY_LIGHT_PROBE_PROXY_VOLUME UNITY_LIGHTMAP_FULL_HDR

Where 'CoreRP/ShaderLibrary/Common.hlsl' must be? Shader reimport, unity restart, reimport all project haven't helped.

 

It's a case sensitive bug.

 

Are there plans to support Geometry shaders and compute shaders?

 

How to access a shader graph property from a c# script (for example using the

Code (CSharp):

1. Shader.SetGlobalFloat("Property", value)

.

 

This has been an issue for a while with any subgraph.

For example this trivial subgraph can't be reopened once it is saved and closed. It gives the error.

NullReferenceException: Object reference not set to an instance of an object

UnityEditor.ShaderGraph.Drawing.Slots.MultiFloatSlotControlView..ctor (UnityEditor.Graphing.INode node, System.String[] labels, System.Func`1[TResult] get, System.Action`1[T] set) (at C:/ProgramData/Unity/cache/packages/packages.unity.com/com.unity.shadergraph@1.1.3-preview/Editor/Drawing/Views/Slots/MultiFloatSlotControlView.cs:23)

UnityEditor.ShaderGraph.Vector4MaterialSlot.InstantiateControl () (at C:/ProgramData/Unity/cache/packages/packages.unity.com/com.unity.shadergraph@1.1.3-preview/Editor/Data/Graphs/Vector4MaterialSlot.cs:52)

UnityEditor.ShaderGraph.Drawing.PortInputView..ctor (UnityEditor.ShaderGraph.MaterialSlot slot) (at C:/ProgramData/Unity/cache/packages/packages.unity.com/com.unity.shadergraph@1.1.3-preview/Editor/Drawing/Views/PortInputView.cs:51)

UnityEditor.ShaderGraph.Drawing.MaterialNodeView.UpdatePortInputs () (at C:/ProgramData/Unity/cache/packages/packages.unity.com/com.unity.shadergraph@1.1.3-preview/Editor/Drawing/Views/MaterialNodeView.cs:341)

UnityEditor.ShaderGraph.Drawing.MaterialNodeView.Initialize (UnityEditor.ShaderGraph.AbstractMaterialNode inNode, UnityEditor.ShaderGraph.Drawing.PreviewManager previewManager, UnityEditor.Experimental.UIElements.GraphView.IEdgeConnectorListener connectorListener) (at C:/ProgramData/Unity/cache/packages/packages.unity.com/com.unity.shadergraph@1.1.3-preview/Editor/Drawing/Views/MaterialNodeView.cs:126)

UnityEditor.ShaderGraph.Drawing.GraphEditorView.AddNode (UnityEditor.Graphing.INode node) (at C:/ProgramData/Unity/cache/packages/packages.unity.com/com.unity.shadergraph@1.1.3-preview/Editor/Drawing/Views/GraphEditorView.cs:335)

UnityEditor.ShaderGraph.Drawing.GraphEditorView..ctor (UnityEditor.EditorWindow editorWindow, UnityEditor.ShaderGraph.AbstractMaterialGraph graph, System.String assetName) (at C:/ProgramData/Unity/cache/packages/packages.unity.com/com.unity.shadergraph@1.1.3-preview/Editor/Drawing/Views/GraphEditorView.cs:149)

UnityEditor.ShaderGraph.Drawing.MaterialGraphEditWindow.Initialize (System.String assetGuid) (at C:/ProgramData/Unity/cache/packages/packages.unity.com/com.unity.shadergraph@1.1.3-preview/Editor/Drawing/MaterialGraphEditWindow.cs:508)

ShaderGraphImporterEditor.ShowGraphEditWindow (System.String path) (at C:/ProgramData/Unity/cache/packages/packages.unity.com/com.unity.shadergraph@1.1.3-preview/Editor/Importers/ShaderGraphImporterEditor.cs:42)

ShaderGraphImporterEditor.OnOpenAsset (System.Int32 instanceID, System.Int32 line) (at C:/ProgramData/Unity/cache/packages/packages.unity.com/com.unity.shadergraph@1.1.3-preview/Editor/Importers/ShaderGraphImporterEditor.cs:51)

UnityEngine.GUIUtility:ProcessEvent(Int32, IntPtr)

Using 2018.1.0b13, shader graph 1.1.3-preview, render piplines core 1.1.4-preview, render piplines lightweight 1.1.4-preview

 

I found an issue using Ellipse with values of 0 on iOS. For now I'm clamping to a very low number but took me some time to find in a more complex shader. Here is a simple example on a quad.

Simple Shader Graph:


Editor and Windows build:


iOS (iPhone 6S):


Notice how not only is negates the alpha but also makes it entirely black. I know it's because of the division in the Ellipse function.

 

@IIporpammep - I've been playing with it on 2018.2.0b1 on a mac. Just make sure you're using a lightweight render pipeline.

 

Experimenting with Shader Graph, I have noticed couple things, while working on circular / radial grid.

Unclear meaning of the assertion error in the console (t 4:30)



Not shown of the video, but after running shader compilation, no matter what compilation option is set, line 33 to 36 show following

Code (CSharp):

1.  
2. //////////////////////////////////////////////////////
3. No keywords set in this variant.
4. -- Vertex shader for "d3d11":
5. // Stats: 44 math, 6 temp registers
6.  

All nodes show pink color of the shader. but in the work space radial grids show correctly. (t 3:05)

Unable to navigate / open sub shader from Grid Graph. (t 3:32)

Searching for a note by typing, is case sensitive. I suggest to disable case sensitivity. can be rather of annoying, to remember that something is big or small case letter. (t 4:10) (below is presented multiple times same video, but starting at different time)

And a little but related off topic, since we are here
I had worked on the radial grid using shaders, as per video. But experienced high GPU usage (30fps), as I got 60 same objects (radial grids) on the scene, which are of different scale and slightly different shader input property value (i.e radius). Any thoughts, what may cause such massive GPU usage? I know it is indicated by Gfx.WaitForPresent, but what in shaders is causing it exactly? Lack of optimization of the shaders? Or the fact thatShader Graph file is not compiled? (t 4:52)

I have created separated topic on that matter
https://forum.unity.com/threads/radial-grid-unity3d-2018b-shader-graph-gpu-issue.527612/

 

Are variable nodes ( like a property node with input and output ) not yet supported ?

 

is it possible to access lighting information etc such as to do a NdotL if we edit the shader code (copy from master node and paste in .shader file)?

 

First of all, I'm really enjoying the Shader Graph

I have a question about optional texture properties. I have a texture property which will sometimes be set on a material, and when it is I want to composite it on top of the main texture – using lerp not multiply.

Unfortunately there seems to be no way of checking if the texture is null or not and the 'Sample Texture 2D' node returns RGBA(1,1,1,1) for a null texture. This makes it really difficult to deal with this situation where a composite not multiply is needed… any advice? It would be great if you could set a default colour if the texture isn't set, which I believe you can do in ShaderLab

 

You should be able to do this with the logic nodes

 

I couldn't see a way of determining if the texture was set using the logic nodes. Unless I'm missing something.

 

Question:
theres currently no blackboard in the ShaderGraph editor ?
using 2018.2.0b1
everything is working but there is no blackboard...
how do i make a shader that exposes ALL of the PBR inputs. (normal, AO, smoothness etc)
i have no blackboard and i cant rename any inputs



Suggestion:
JUST started using this (so if they have it, i dont know about it)

itd be cool to have labels and like drag-out boxes .. for organizational purposes
like Substance Designer has Comments, Frames & Pins

i guess its low priority but itd be really nice

 

not + NaN ???

 

This is by far the optimal way to digest change logs. Whenever big unity releases come out I read the bold headers and look at the gifs, and very rarely do I need more than that to understand at a high level what was added. Also makes for easier reading whilst commuting or on mobile devices!

 

Editable property names, great !
Any ETA regarding Vertex Offset and Post effects graphs ?