Feedback Wanted: High Definition Render Pipeline

Hi, this is something unrelated to HDRP, please report to General Graphic forum

 

Hi, I am not sure to understand, there is a "on demand" option since the first release. we expose: On change, On demand and every frame option for reflection probe. But true that even it if work, we only expose realtime for reflection probe as it make not a lot of sense in most scenario to not be realtime as it is view dependent.

 

The master branch always contain all the fixes, we always backport to older branch. What is happening is just that we haven't done any update of package for 5.X.X since a while as we were focusing on 4.X.X package. But github branch are up to date. Note that we have release 5.3.1 last weak (that is the very last code with all fixes and all the new work for 2019.1), but sadly due to an issue in Package manager itself, it doesn't appear yet...

 

> I cant quite understand why it use 3 as the index
Hi, not sure what you don't understand , when you have 4 RT (i.e you enable the control of metalic and ambient occlusion for decal) it mean we need to bind the UAV at the 5th position (index 4 - UAV always need to be bind at the last available slot after RT in Unity (here there is 4 RT)). When only 3RT are enable for decal, it is at the 4thposition (index 3)

 

Hi, by more controls you just mean Mask system, or other stuff as well ?
Agree that mask system is nice, also good if it could be control on the objects. We don't offer this currently. Could be a development in the future but currently not plan.

Note: Our decal algorithm is different from Unigine (which from what I understand is based on deferred decals), it is based on DBuffer for opaque and Cluster for Transparent - so it work in both deferred and forward and work with our lightmaps (see slide about decal here: http://advances.realtimerendering.com/s2018/Siggraph 2018 HDRP talk_with notes.pdf).
We carefully weights the options we add for them to not kill performance.

 

Disclaimer for everyone: Procedural sky in HDRP is a straight port of buit-in Unity. Nobody at Unity understand it (people working on this are not their anymore). We don't aim at adding feature or doing any work on it, we have added it for convenience as it is better than offering nothing. We are now starting to work on a proper physically based sky.

Baking sky and environment lighting are describe here:
https://github.com/Unity-Technologies/ScriptableRenderPipeline/wiki/Environment-Lighting

We support HDRI sky, procedural sky and 3 color sky.
The baking sky volume is not intuitive and we are aware of that, however this is a feature requested by many team/users, it allow to have a different sky use for the display and for the lighting (yes, our book of the dead demo use it - and yes, this isn't PBR). Please see documentation here:

Note: volume system is describe here:
https://github.com/Unity-Technologies/ScriptableRenderPipeline/wiki/Volumes

Note that you can write a custom sky: https://github.com/Unity-Technologies/ScriptableRenderPipeline/wiki/Writing-A-Custom-Sky-Renderer

The reasons the system is different from builtin unity is that now it allow to override settings per volume in scene + the sky lighting and fog are integrated correctly with opaque and transparent, there is no discrepancy here thus the extra complexity setup. We can't allow arbitrary fog for performance reasons as this fog need to apply to forward opaque and transparent correctly without killing performance.

hope that help.

 

Thanks for reporting this, we will evaluate your solution (Maybe PR request is best than posting here in this case). Cheers

 

Hi,
>Is there any material upgrade support for custom shaders?
No.

>Is there any proper terrain shader currently available
TerrainLit is the official shader. Don't know about others not made by Unity but can bet it wouldn't work given all change happening.

 

>TAA glitched in 4.9
Thanks for the report but it lack a lot of information to be able to help you. Any project scene or context ?

 

Hi, thanks for the report.

I benchmarked the QuickSort function and compared against yours implementation, but it did not seems to be faster. (see attached screenshot)

I guess that the performance hit comes from other parts around the call to QuickSort and not the QuickSort itself. Do you have more information from your profiling?

NB: For the benchmark, I used the Unity.PerformanceTesting package and the code provided below.

Code (CSharp):

1. [PerformanceTest]
2.         public void QuickSortUnsafe()
3.         {
4.             const int size = 1 << 12;
5.             var valuesPtr = stackalloc uint[size];
6.             for (var i = 0; i < size; ++i)
7.                 valuesPtr[i] = (uint)(Random.value * uint.MaxValue);
8.  
9.             Measure.Method(() =>
10.                 {
11.                     var valuesCopyPtr = stackalloc uint[size];
12.                     UnsafeUtility.MemCmp(valuesCopyPtr, valuesPtr, sizeof(uint) * size);
13.  
14.                     CoreUnsafeUtils.QuickSort<uint, uint, CoreUnsafeUtils.DefaultKeyGetter<uint>>(valuesCopyPtr, 0, size - 1);
15.                 })
16.                 .WarmupCount(10)
17.                 .MeasurementCount(10)
18.                 .Run();
19.         }
20.  
21.         [PerformanceTest]
22.         public void QuickSortUnsafeUIntArray()
23.         {
24.             const int size = 1 << 12;
25.             var valuesPtr = stackalloc uint[size];
26.             for (var i = 0; i < size; ++i)
27.                 valuesPtr[i] = (uint)(Random.value * uint.MaxValue);
28.  
29.             var values = new uint[size];
30.  
31.             Measure.Method(() =>
32.                 {
33.                     fixed (uint* p = &values[0])
34.                         UnsafeUtility.MemCmp(p, valuesPtr, sizeof(uint) * size);
35.  
36.                     CoreUnsafeUtils.QuickSort(values, 0, values.Length - 1);
37.                 })
38.                 .WarmupCount(10)
39.                 .MeasurementCount(10)
40.                 .Run();
41.         }
42.  
43.         public static void QuickSort1(uint[] s, int l, int r)
44.         {
45.             if (l < r)
46.             {
47.                 uint x = x = s[l];
48.                 int i = l, j = r;
49.                 while (i < j)
50.                 {
51.                     while (i < j && s[j] >= x)
52.                         j--;
53.                     if (i < j)
54.                         s[i++] = s[j];
55.  
56.                     while (i < j && s[i] < x)
57.                         i++;
58.                     if (i < j)
59.                         s[j--] = s[i];
60.                 }
61.                 s[i] = x;
62.                 QuickSort1(s, l, i - 1);
63.                 QuickSort1(s, i + 1, r);
64.             }
65.         }
66.  
67.         [PerformanceTest]
68.         public void QuickSort_Compare()
69.         {
70.             const int size = 1 << 12;
71.             var valuesPtr = stackalloc uint[size];
72.             for (var i = 0; i < size; ++i)
73.                 valuesPtr[i] = (uint)(Random.value * uint.MaxValue);
74.  
75.             var values = new uint[size];
76.  
77.             Measure.Method(() =>
78.                 {
79.                     fixed (uint* p = &values[0])
80.                         UnsafeUtility.MemCmp(p, valuesPtr, sizeof(uint) * size);
81.  
82.                     QuickSort1(values, 0, values.Length - 1);
83.                 })
84.                 .WarmupCount(10)
85.                 .MeasurementCount(10)
86.                 .Run();
87.         }

 

On demand is still there. I will double check (it may be a bug) but we have never removed it.

 

Hi, Glad you find the issue. As it is due to z-fight we don't need a repro. Thanks

 

Hi, thanks for pointing this. My bad. There is indeed a mistake here. We will fix this.

 

Yes, it will not be supported in HDRP.

 

Hi, not sure what you refer to. Suppose it is Sky? You can look at the ProceduralSky.shader to know more.

float4 _SkyParam; // x exposure, y multiplier
float4x4 _PixelCoordToViewDirWS; // Actually just 3x3, but Unity can only set 4x4

float _SunSize;
float _SunSizeConvergence;
float _AtmosphereThickness;
float4 _SkyTint;
float4 _GroundColor;

float4 _SunColor;
float3 _SunDirection;

 

Not plan currently.

 

Note: 5.3.1 of HDRP is public but isn't visible currently due to a bug in package manager.

Here is the change log and various thing to pay attention:

- Expect this version to be unstable, there is a lot of change and it is highly possible that various stuff don't work anymore (due to bug).
- VR is broken in this version
- We have change the reflection system. It is now unified and doesn't go through CPU anymore. So when you bake lighting, it now bake reflection probe on GPU. You can select what to render inside the cubemap with FrameSettings.
- Note: There is a know issue with cubemap that render dynamic object in bake cubemap instead of only static like before. This can be workaround with tag

- The postprocess package V2 have been replace by V3 and now everything use the RT handle system (a system which allow to reuse memory when scaling screen)
- Software dynamic resolution have been introduce. Render world at lower resolution, upscale and draw UI on top
- We have added a Render Pipeline wizard (in Windows -> Analysis) to detect wrong settings and also to allow to create a new scene with correct settings for HDRP from a provided scene prefab
- A new hair shader is available
- A new HD Unlit master node is available
- Various physical unit have been added for light and for emissive (Lux At, EV100 etc...)
- Whole lighting pipeline now use pre-exposure (we apply exposition of previous frame on current frame lighting to improve precision of lighting storage) and exposure is EV100 everywhere (https://en.wikipedia.org/wiki/Exposure_value).
- Emissive can be pre-expose or not, or a weight of both. There is a slider for this and a new node in shader graph to control it. This allow to have an always glowing emissive even if lighting change.
- There is physical camera control + new physical parameter to control DOF, MB etc...
- There is support of multiviewport
- Shader graph now expose GI input, so you can modify the GI (like do a multiply on it, provide another normal than vertex normal etc...)
- UI of framesettings have been redone
- Ambient probe for sky have been redone, it is now done on GPU and store for various cases (preview windows etc...) that should fix various flickering issue when multiple windows where open. This can be source of new bugs!

- The pre-exposure and PPV3 finally allow to use correct Unit for the Sun (i.E 100 000 lux) with EV16. But the procedural sky from Unity doesn't support this at all. You must disable sun disc in it to get better behavior. We are starting to work on a new physically sky as a replacement. Procedural sky was just a straight port of builtin Unity (because we have no time to develop a new one) that nobody understand anymore.

- Realtime Enlighten is in a bad state since a long time. Several features aren't supported (like color temperature), the intensity isn't correct and there is no inverse square falloff. Improvement should come but could be 2019.2

Changelog:

## [5.3.1-preview] - 2019-01-28

### Added
- Added software dynamic resolution support

### Fixed
- Fixed a case of ambient lighting flickering because of previews

## [5.3.0-preview] - 2019-01-28

### Added
- Added new API to perform a camera rendering
- Added support for hair master node (Double kajiya kay - Lambert)
- Added Reset behaviour in DebugMenu (ingame mapping is right joystick + B)
- Added Default HD scene at new scene creation while in HDRP
- Added Wizard helping to configure HDRP project
- Added new UI for decal material to allow remapping and scaling of some properties
- Added cascade shadow visualisation toggle in HD shadow settings
- Added icons for assets
- Added replace blending mode for distortion
- Added basic distance fade for density volumes
- Added decal master node for shader graph
- Added HD unlit master node (Cross Pipeline version is name Unlit)
- Added new Rendering Queue in materials
- Added post-processing V3 framework embed in HDRP, remove postprocess V2 framework
- Post-processing now uses the generic volume framework
- New depth-of-field, bloom, panini projection effects, motion blur
- Exposure is now done as a pre-exposition pass, the whole system has been revamped
- Exposure now use EV100 everywhere in the UI (Sky, Emissive Light)
- Added emissive intensity (Luminance and EV100 control) control for Emissive
- Added pre-exposure weigth for Emissive
- Added an emissive color node and a slider to control the pre-exposure percentage of emission color
- Added physical camera support where applicable
- Added more color grading tools
- Added changelog level for Shader Variant stripping
- Added Debug mode for validation of material albedo and metalness/specularColor values
- Added a new dynamic mode for ambient probe and renamed BakingSky to StaticLightingSky
- Added command buffer parameter to all Bind() method of material
- Added Material validator in Render Pipeline Debug
- Added code to future support of DXR (not enabled)
- Added support of multiviewport
- Added stereo instancing macros to a few shaders
- Added HDRenderPipeline.RequestSkyEnvironmentUpdate function to force an update from script when sky is set to OnDemand
- Added a Lighting and BackLighting slots in Lit, StackLit, Fabric and Hair master nodes
- Added xrInstancing flag support to RTHandle
- Added support for cullmask for decal projectors

### Fixed
- Fixed logic to disable FPTL with stereo rendering
- Fixed stacklit transmission and sun highlight
- Fixed decals with stereo rendering
- Fixed sky with stereo rendering
- Fixed flip logic for postprocessing + VR
- Fixed copyStencilBuffer pass for Switch
- Fixed point light shadow map culling that wasn't taking into account far plane
- Fixed usage of SSR with transparent on all master node
- Fixed SSR and microshadowing on fabric material
- Fixed blit pass for stereo rendering
- Fixed lightlist bounds for stereo rendering
- Fixed windows and in-game DebugMenu sync.
- Fixed FrameSettings' LitShaderMode sync when opening DebugMenu.
- Fixed Metal specific issues with decals, hitting a sampler limit and compiling AxF shader
- Fixed an issue with flipped depth buffer during postprocessing
- Fixed normal map use for shadow bias with forward lit - now use geometric normal
- Fixed transparent depth prepass and postpass access so they can be use without alpha clipping for lit shader
- Fixed support of alpha clip shadow for lit master node
- Fixed unlit master node not compiling
- Fixed issue with debug display of reflection probe
- Fixed issue with phong tessellations not working with lit shader
- Fixed issue with vertex displacement being affected by heightmap setting even if not heightmap where assign
- Fixed issue with density mode on Lit terrain producing NaN
- Fixed issue when going back and forth from Lit to LitTesselation for displacement mode
- Fixed issue with ambient occlusion incorrectly applied to emissiveColor with light layers in deferred
- Fixed issue with fabric convolution not using the correct convolved texture when fabric convolution is enabled
- Fixed issue with Thick mode for Transmission that was disabling transmission with directional light
- Fixed shutdown edge cases with HDRP tests
- Fixed slowdow when enabling Fabric convolution in HDRP asset
- Fixed specularAA not compiling in StackLit Master node
- Fixed material debug view with stereo rendering
- Fixed material's RenderQueue edition in default view.
- Fixed banding issues within volumetric density buffer
- Fixed missing multicompile for MSAA for AxF
- Fixed camera-relative support for stereo rendering
- Fixed remove sync with render thread when updating decal texture atlas.
- Fixed max number of keyword reach [256] issue. Several shader feature are now local
- Fixed Scene Color and Depth nodes
- Fixed SSR in forward
- Fixed custom editor of Unlit, HD Unlit and PBR shader graph master node
- Fixed issue with NewFrame not correctly calculated in Editor when switching scene
- Fixed issue with TerrainLit not compiling with depth only pass and normal buffer
- Fixed geometric normal use for shadow bias with PBR master node in forward
- Fixed instancing macro usage for decals
- Fixed error message when having more than one directional light casting shadow
- Fixed error when trying to display preview of Camera or PlanarReflectionProbe
- Fixed LOAD_TEXTURE2D_ARRAY_MSAA macro
- Fixed min-max and amplitude clamping value in inspector of vertex displacement materials
- Fixed issue with alpha shadow clip (was incorrectly clipping object shadow)
- Fixed an issue where sky cubemap would not be cleared correctly when setting the current sky to None
- Fixed a typo in Static Lighting Sky component UI
- Fixed issue with incorrect reset of RenderQueue when switching shader in inspector GUI
- Fixed issue with variant stripper stripping incorrectly some variants

### Changed
- ColorPyramid compute shader passes is swapped to pixel shader passes on platforms where the later is faster (Nintendo Switch).
- Removing the simple lightloop used by the simple lit shader
- Whole refactor of reflection system: Planar and reflection probe
- Separated Passthrough from other RenderingPath
- Update several properties naming and caption based on feedback from documentation team
- Remove tile shader variant for transparent backface pass of lit shader
- Rename all HDRenderPipeline to HDRP folder for shaders
- Rename decal property label (based on doc team feedback)
- Lit shader mode now default to Deferred to reduce build time
- Update UI of Emission parameters in shaders
- Improve shader variant stripping including shader graph variant
- Refactored render loop to render realtime probes visible per camera
- Enable SRP batcher by default
- Shader code refactor: Rename LIGHTLOOP_SINGLE_PASS => LIGHTLOOP_DISABLE_TILE_AND_CLUSTER and clean all usage of LIGHTLOOP_TILE_PASS
- Shader code refactor: Move pragma definition of vertex and pixel shader inside pass + Move SURFACE_GRADIENT definition in XXXData.hlsl
- Micro-shadowing in Lit forward now use ambientOcclusion instead of SpecularOcclusion
- Upgraded FrameSettings workflow, DebugMenu and Inspector part relative to it
- Update build light list shader code to support 32 threads in wavefronts on Switch
- LayeredLit layers' foldout are now grouped in one main foldout per layer
- Shadow alpha clip can now be enabled on lit shader and haor shader enven for opaque

 

Terrain team work on other way of doing this. No ETA yet.

 

Hi, sorry but the question is way too large, you need to be specific.

Which platform, which API, which effects (Postprocess, lighting, shadow...) ?
What is your current bottleneck and what kind of scene are you aiming for ? CPU or GPU ?
What number of lights and type with which material ?
Deferred or forward ? VR ? MSAA ? etc...

This information are relevant because if we focus optimization on VR in MSAA for standard material, it will not help a project in deferred with lot of clear coat material.

Generally speaking we will focus our effort on optimizing PS4/XBoxOne GPU and reduce memory usage/allocation. The CPU is mostly not part of HDRP. Also target FPS and resolution are very important. There is optimization like dynamic resolution that is up to you to use or not.

Can I ask the purpose of the question ? If it is to evaluate the size of your content then I will suggest to always consider current performance as the one you need to fit with. Don't make plan about what optimization could come, always plan for the worst case. As much as possible we will avoid performance regression, so keeping metric based on current performance should be safe and if any optimization is coming, then it will be a win.

 

Hi, can't speak for the lightmapper team, but we have added in ShaderGraph GI inputs (this is in the 5.3.1 changelog I posted). Mean you can provide your own lightmaps / Custom baked GI through shader graph, or tweak the result of existing one (or provide orther UV set / Normal)

There is also callback in the Lightmapping system so you can do some post-step, but I don't know much about it.

[Edit: Just see the screenshots in the answer after your question, this is it]

 

SSR still not supported yet with MSAA. It is own our TODO but not ETA.