Error: The name 'velocity' does not exist in the current context

I am pretty new to Unity and Scripting and I got an error while trying to add the jumping mechanic and I can't figure out how to fix it.

Code (CSharp):

1. using System.Collections;
2. using System.Collections.Generic;
3. using UnityEngine;
4.  
5. public class PlayerController : MonoBehaviour
6. {
7.     [SerializeField] Transform playerCamera = null;
8.     [SerializeField] float mouseSensitivity = 3.5f;
9.     [SerializeField] float walkSpeed = 6.0f;
10.     [SerializeField] float gravity = -13.0f;
11.     [SerializeField][Range(0.0f, 0.5f)] float moveSmoothTime = 0.3f;
12.     [SerializeField][Range(0.0f, 0.5f)] float mouseSmoothTime = 0.03f;
13.  
14.     [SerializeField] private float jumpHight = 1.5f;
15.  
16.     [SerializeField] bool lockCursor = true;
17.  
18.     float cameraPitch = 0.0f;
19.     float velocityY = 0.0f;
20.     CharacterController controller = null;
21.  
22.     Vector2 currentDir = Vector2.zero;
23.     Vector2 currentDirVelocity = Vector2.zero;
24.  
25.     Vector2 currentMouseDelta = Vector2.zero;
26.     Vector2 currentMouseDeltaVelocity = Vector2.zero;
27.  
28.     // Start is called before the first frame update
29.     void Start()
30.     {
31.         controller = GetComponent<CharacterController>();
32.         if (lockCursor)
33.         {
34.             Cursor.lockState = CursorLockMode.Locked;
35.             Cursor.visible = false;
36.         }
37.        
38.     }
39.  
40.     // Update is called once per frame
41.     void Update()
42.     {
43.         UpdateMouseLook();
44.         UpdateMovement();
45.  
46.         if (Input.GetKeyDown("space"))
47.         {
48.             print("Player Has Jumped!" +
49.                 "I think..." +
50.                 "Listen! i'm a text box and text boxes don't have eyes!");
51.         }
52.     }
53.    
54.     void UpdateMouseLook()
55.     {
56.         Vector2 targetMouseDelta = new Vector2(Input.GetAxis("Mouse X"), Input.GetAxis("Mouse Y"));
57.  
58.         currentMouseDelta = Vector2.SmoothDamp(currentMouseDelta, targetMouseDelta, ref currentMouseDeltaVelocity, mouseSmoothTime);
59.  
60.         cameraPitch -= currentMouseDelta.y * mouseSensitivity;
61.         cameraPitch = Mathf.Clamp(cameraPitch, -90.0f, 90.0f);
62.  
63.         playerCamera.localEulerAngles = Vector3.right * cameraPitch;
64.         transform.Rotate(Vector3.up * currentMouseDelta.x  * mouseSensitivity);
65.     }
66.  
67.     void UpdateMovement()
68.     {
69.         Vector2 targetDir = new Vector2(Input.GetAxisRaw("Horizontal"), Input.GetAxisRaw("Vertical"));
70.         targetDir.Normalize();
71.  
72.         currentDir = Vector2.SmoothDamp(currentDir, targetDir, ref currentDirVelocity, moveSmoothTime);
73.  
74.         if (controller.isGrounded)
75.             velocityY = 0.0f;
76.  
77.         velocityY += gravity * Time.deltaTime;
78.  
79.         Vector3 velocity = (transform.forward * currentDir.y + transform.right * currentDir.x) * walkSpeed + Vector3.up * velocityY;
80.  
81.         controller.Move(velocity * Time.deltaTime);
82.  
83. //ERROR IS HERE
84. //ERROR IS HERE
85.             if (Input.GetKeyDown(KeyCode.Space))
86.         {
87.             Jump();
88.         }
89.  
90.     }
91.  
92.     private void Jump()
93.     {
94.         velocity.y = Mathf.Sqrt(jumpHight * -2 * gravity);
95.     }
96. }
97.  

 

The error should be in line 94 of the code you posted, not the lines you marked. You declared the velocity variable inside your UpdateMovement method in line 79 (of your posted code). So that variable only exists inside this method. So inside your Jump method there is no variable available that is called velocity. Since you seperated out the Y component, you may wanted to use "velocityY" inside Jump?

 

to fix this just declare your Velocity varible outside of the updateMovement method then you will be able to reference it in any of the methods

Code (CSharp):

1.  
2.  
3. private Vector3 velocity;
4.     void UpdateMovement()
5.     {
6.         Vector2 targetDir = new Vector2(Input.GetAxisRaw("Horizontal"), Input.GetAxisRaw("Vertical"));
7.         targetDir.Normalize();
8.         currentDir = Vector2.SmoothDamp(currentDir, targetDir, ref currentDirVelocity, moveSmoothTime);
9.         if (controller.isGrounded)
10.             velocityY = 0.0f;
11.         velocityY += gravity * Time.deltaTime;
12.          velocity = (transform.forward * currentDir.y + transform.right * currentDir.x) * walkSpeed + Vector3.up * velocityY;
13.         controller.Move(velocity * Time.deltaTime);
14. //ERROR IS HERE
15. //ERROR IS HERE
16.             if (Input.GetKeyDown(KeyCode.Space))
17.         {
18.             Jump();
19.         }
20.     }
21.     private void Jump()
22.     {
23.         velocity.y = Mathf.Sqrt(jumpHight * -2 * gravity);
24.     }

 

this got rid of the error but the jumping mechanic still does not work, Thanks anyways!

 

this got rid of the error but the jumping mechanic still does not work like the other post, Thanks anyways!

 

I only addressed your syntax error. Any logical errors belong to yourself ^^. You should think about what is executed in which order. You have your "jump" detection at the very any of your method. So it's the last thing that is happening in a frame. So when you press jump you set the Y velocity to the jump force in order to jump up. However look what's happening the next frame. You have this before all of your movement code:

Code (CSharp):

1.         if (controller.isGrounded)
2.             velocityY = 0.0f;
3.  

So of course since you're still on the ground you just eliminate the velocity you just set at the end of the last frame. So this doesn't make much sense logically.

 

Are you looking to learn programming by making a character controller, or do you just want a functioning character controller so you can do other stuff? There's plenty of those you can start from, such as this one:

https://forum.unity.com/threads/a-basic-first-person-character-controller-for-prototyping.1169491/

That prototype one has run, walk, jump, slide, crouch... it's crazy-nutty!!

If you want to fix your code:

The complete error message contains everything you need to know to fix the error yourself.

The important parts of the error message are:

- the description of the error itself (google this; you are NEVER the first one!)
- the file it occurred in (critical!)
- the line number and character position (the two numbers in parentheses)
- also possibly useful is the stack trace (all the lines of text in the lower console window)

Always start with the FIRST error in the console window, as sometimes that error causes or compounds some or all of the subsequent errors. Often the error will be immediately prior to the indicated line, so make sure to check there as well.

All of that information is in the actual error message and you must pay attention to it. Learn how to identify it instantly so you don't have to stop your progress and fiddle around with the forum.

 

Yeah actually that makes sense