Search Unity

  1. Unity 6 Preview is now available. To find out what's new, have a look at our Unity 6 Preview blog post.
    Dismiss Notice
  2. Unity is excited to announce that we will be collaborating with TheXPlace for a summer game jam from June 13 - June 19. Learn more.
    Dismiss Notice

error CS0501

Discussion in 'Scripting' started by premawolf, Oct 23, 2021.

  1. premawolf

    premawolf

    Joined:
    Oct 2, 2021
    Posts:
    1
    can you fix this for me please ?.

    Assets\FBX\character\playercontroller.cs(14,17): error CS0501: 'playercontroller.input()' must declare a body because it is not marked abstract, extern, or partial

    and this is my code :

    Code (CSharp):
    1. using System.Collections;
    2. using System.Collections.Generic;
    3. using UnityEngine;
    4. using UnityEngine.InputSystem;
    5.  
    6. public class playercontroller : MonoBehaviour
    7. {
    8.     Animator animator;
    9.  
    10.  
    11.     int isWalkingHash;
    12.     int isRunningHash;
    13.  
    14.     PlayerInput input();
    15.  
    16.     Vector2 currentMovement;
    17.     bool movementPressed;
    18.     bool runPressed;
    19.  
    20.     void Awake()
    21.     {
    22.         input = new PlayerInput();
    23.  
    24.         input.CharacterControls.Movement.performed += ctx =>{
    25.             currentMovement = ctx.ReadValue<Vector2>();
    26.             movementPressed = currentMovement.x != 0 || currentMovement.y != 0;
    27.         };
    28.         input.CharacterControlls.Run.performed += ctx => runPressed = ctx.ReadValueAsButton();
    29.     }
    30.  
    31.  
    32.     // Start is called before the first frame update
    33.     void Start()
    34.     {
    35.         animator = GetComponent<Animator>();
    36.  
    37.         isWalkingHash = Animator.StringToHash("isWalking");
    38.         isRunningHash = Animator.StringToHash("isRunning");
    39.     }
    40.  
    41.     // Update is called once per frame
    42.     void Update()
    43.     {
    44.         handleMovement();
    45.     }
    46.  
    47.     void handleMovement() {
    48.         bool isRunning = animator.GetBool(isRunningHash);
    49.         bool isWalking = animator.GetBool(isWalkingHash);
    50.  
    51.         if (movementPressed && !isWalking) {
    52.             animator.SetBool(isWalkingHash, true);
    53.         }
    54.  
    55.         if(!movementPressed && isWalking) {
    56.             animator.SetBool(isWalkingHash, false);
    57.         }
    58.         if ((movementPressed && runPressed) && !isRunning){
    59.             animator.SetBool(isRunningHash, true);
    60.         }
    61.         if ((!movementPressed || !runPressed) && isRunning) {
    62.             animator.SetBool(isRunningHash, false);
    63.         }
    64.     }
    65.  
    66.     void OnEnable()
    67.     {
    68.         input.CharacterControls.Enable();
    69.     }
    70.  
    71.     void OnDisable()
    72.     {
    73.         input.CharacterControls.Disable();  
    74.     }
    75. }
     
    Last edited: Oct 25, 2021
  2. MelvMay

    MelvMay

    Unity Technologies

    Joined:
    May 24, 2013
    Posts:
    11,579
    I moved your post from the Documentation sub-forum (no idea why you'd post this there) to here.

    So now please edit your post to use code-tags (never post code as plain-text).

    Code (CSharp):
    1. PlayerInput input();
    I guess you're new to C# and this isn't your code or you're following a tutorial but haven't followed it correctly. It seems that you think this code above is correct because you posted the error which tells you which line but cannot see the extra "()" you added on that line. Those are used on methods (things you call) and not fields (which you are defining here).
     
    premawolf likes this.
  3. Kurt-Dekker

    Kurt-Dekker

    Joined:
    Mar 16, 2013
    Posts:
    39,008
    The complete error message contains everything you need to know to fix the error yourself.

    Always start with the FIRST error in the console window, as sometimes that error causes or compounds some or all of the subsequent errors.

    The important parts of the error message are:

    - the description of the error itself (google this; you are NEVER the first one!)
    - the file it occurred in (critical!)
    - the line number and character position (the two numbers in parentheses)
    - also possibly useful is the stack trace (all the lines of text in the lower console window)

    All of that information is in the actual error message and you must pay attention to it. Learn how to identify it instantly so you don't have to stop your progress and fiddle around with the forum.

    Remember: NOBODY here memorizes error codes. That's not a thing. The error code is absolutely the least useful part of the error. It serves no purpose at all. Forget the error code. Put it out of your mind.

    Tutorials and example code are great, but keep this in mind to maximize your success and minimize your frustration:

    How to do tutorials properly:

    Tutorials are a GREAT idea. Tutorials should be used this way:

    Step 1. Follow the tutorial and do every single step of the tutorial 100% precisely the way it is shown. Even the slightest deviation (even a single character!) generally ends in disaster. That's how software engineering works. Every single letter must be spelled, capitalized, punctuated and spaced (or not spaced) properly. Fortunately this is the easiest part to get right.

    Be a robot. Don't make any mistakes. BE PERFECT IN EVERYTHING YOU DO HERE.

    If you get any errors, learn how to read the error code and fix it. Google is your friend here. Do NOT continue until you fix the error. The error will probably be somewhere near the parenthesis numbers (line and character position) in the file. It is almost CERTAINLY your typo causing the error, so look again and fix it.

    Step 2. Go back and work through every part of the tutorial again, and this time explain it to your doggie. See how I am doing that in my avatar picture? If you have no dog, explain it to your house plant. If you are unable to explain any part of it, STOP. DO NOT PROCEED. Now go learn how that part works. Read the documentation on the functions involved. Go back to the tutorial and try to figure out WHY they did that. This is the part that takes a LOT of time when you are new. It might take days or weeks to work through a single 5-minute tutorial. Stick with it. You will learn.

    Step 2 is the part everybody seems to miss. Without Step 2 you are simply a code-typing monkey and outside of the specific tutorial you did, you will be completely lost. If you want to learn, you MUST do Step 2.

    Of course, all this presupposes no errors in the tutorial. For certain tutorial makers (like Unity, Brackeys, Imphenzia, Sebastian Lague) this is usually the case. For some other less-well-known content creators, this is less true. Read the comments on the video: did anyone have issues like you did? If there's an error, you will NEVER be the first guy to find it.

    Beyond that, Step 3, 4, 5 and 6 become easy because you already understand!

    Finally, when you have errors... see above!

    In the future, if you post a code snippet, ALWAYS USE CODE TAGS:

    How to use code tags: https://forum.unity.com/threads/using-code-tags-properly.143875/
     
    premawolf likes this.