Search Unity

  1. Welcome to the Unity Forums! Please take the time to read our Code of Conduct to familiarize yourself with the forum rules and how to post constructively.
  2. The 2023.1 beta is now available for testing. To find out what's new, have a look at our 2023.1 feature highlights.
    Dismiss Notice
New Forum User Notice Unity 2023.1 Beta Announcement

Feedback EditorLoop::SceneHierarchyWindow.Paint performance

Discussion in '2020.1 Beta' started by Peter77, May 9, 2020.

  1. Peter77

    Peter77

    QA Jesus

    Joined:
    Jun 12, 2013
    Posts:
    6,325
    Unity 2020.1.0b8:
    SceneHierarchyWindow.Paint
    continues to be the #1 performance issue for me while being in play mode. I've attached Profiler screenshots.

    I'm not sure how valuable these screenshots are to you. Please let me know whether they are helpful, because if they are not, what would be helpful to provide so you can improve performance in that area?

    SceneHierarchyWindow.Paint
    deep profile:
    upload_2020-5-9_10-4-33.png

    upload_2020-5-9_10-4-45.png 

    SceneHierarchyWindow.Paint
    without deep profile:
    upload_2020-5-9_10-13-4.png
     
    Last edited: May 9, 2020
    Peter77, May 9, 2020
    #1
    richardkettlewell and SugoiDev like this.

  2. print_helloworld

    print_helloworld

    Joined:
    Nov 14, 2016
    Posts:
    229
    I tend to hide the hierarchy contents by collapsing the scene because of this, its a noticeable improvement. Hopefully theres some ms they can shave off the hierarchy creation/rendering logic in the future.
     
    print_helloworld, May 10, 2020
    #2
    Peter77 likes this.

  3. Mads-Nyholm

    Mads-Nyholm

    Unity Technologies

    Joined:
    Aug 19, 2013
    Posts:
    180
    Hi Peter,
    Please grab a screenshot where we can see what allocates the 1.9 KB under DoItemGUI.
     
    Mads-Nyholm, May 12, 2020
    #3

  4. Peter77

    Peter77

    QA Jesus

    Joined:
    Jun 12, 2013
    Posts:
    6,325
    Hi Mads,

    thanks for your interest!

    TreeViewGUI.DoItemGUI
    :
    upload_2020-5-12_13-13-41.png 


    SceneHierarchy.SyncIfNeeded
    (also called every few updates):
    upload_2020-5-12_13-13-33.png
     
    Peter77, May 12, 2020
    #4

  5. Mads-Nyholm

    Mads-Nyholm

    Unity Technologies

    Joined:
    Aug 19, 2013
    Posts:
    180
    Ok so those two situations is expected when there has been a structural change to the transform hierarchy. The hierarchy is rebuilding it's view in SyncIfNeeded and lazy initializes and caches the name of each item on the first repaint.
    So it seems like is that something in your game logic is constantly making transform structural changes (re-parenting , sibling order changes or renaming gameobjects).
    I know that we have had an issue with transform.SetAsLastSibling() that would dirty the hierarchy state when called even if the transform is already the last sibling, a fix is coming for that. But you can search for that on your side.
    And we will look into where we can shave time off on our side.
     
    Mads-Nyholm, May 12, 2020
    #5

  6. Peter77

    Peter77

    QA Jesus

    Joined:
    Jun 12, 2013
    Posts:
    6,325
    Hi Mads,

    thanks again for your reply.

    Yep, that's spot on and I guess all of the three examples happen :)

    The game utilizes gameobject pooling for a lot of stuff, objects get acquired from a pool, change their parent and get renamed for debugging purposes, just to name one path where this occurs. While I could get rid of the renaming, I can't get rid of the other points.

    You seem to have an unique approach to investigate performance issues, that I would like to understand. Please excuse me if I ask the obvious.

    My approach would have been to investigate the path where most performance is being spent, that would be 
    GameObjectTreeViewGUI.OnContentGUI
    with 4.5ms, but you went straight to 
    GameObjectTreeViewItem.get_DisplayName
    which costs 0.25ms.

    Why did you go for the 0.25ms cost rather than the 4.5ms?
     
    Peter77, May 14, 2020
    #6

  7. Mads-Nyholm

    Mads-Nyholm

    Unity Technologies

    Joined:
    Aug 19, 2013
    Posts:
    180
    I was commenting on your two screenshots
     
    Mads-Nyholm, May 15, 2020
    #7

  8. Mads-Nyholm

    Mads-Nyholm

    Unity Technologies

    Joined:
    Aug 19, 2013
    Posts:
    180
    To dig more I need your repro project. If you have submitted a case where you have attached it recently you can just refer to that here.
     
    Mads-Nyholm, May 15, 2020
    #8

  9. LeonhardP

    LeonhardP

    Unity Technologies

    Joined:
    Jul 4, 2016
    Posts:
    3,050
    @Peter77 was your question here resolved?
     
    LeonhardP, Aug 7, 2020
    #9
    Peter77 likes this.

  10. Peter77

    Peter77

    QA Jesus

    Joined:
    Jun 12, 2013
    Posts:
    6,325
    I haven't looked into the issue any further. Feel free to consider the case closed.
     
    Peter77, Aug 7, 2020
    #10
    LeonhardP likes this.

  11. DylanF

    DylanF

    Joined:
    Jun 25, 2013
    Posts:
    50
    SceneHierarchyWindow.Paint is a big pain point for me too. You can work around it by de-selecting the Hierarchy tab when in play mode. Here's an editor script that does it for you automatically.

    Put your Animation tab next to Hierarchy and Lighting next to Inspector to make it work
    Code (CSharp):
    1.  using UnityEditor;
    2. namespace UnityHacks {
    3.      [InitializeOnLoad]
    4.      public class HideExpensiveTabsDuringPlayMode {
    5.         static HideExpensiveTabsDuringPlayMode() {
    6.              EditorApplication.playModeStateChanged += HandleOnPlayModeChanged;
    7.          }
    8.          static void HandleOnPlayModeChanged(PlayModeStateChange state) {
    9.              if(state == PlayModeStateChange.ExitingEditMode) {
    10.                 EditorApplication.ExecuteMenuItem("Window/Rendering/Lighting");
    11.                 EditorApplication.ExecuteMenuItem("Window/Animation/Animation");
    12.              } else if(state == PlayModeStateChange.ExitingPlayMode) {
    13.                  EditorApplication.ExecuteMenuItem("Window/General/Inspector");
    14.                  EditorApplication.ExecuteMenuItem("Window/General/Hierarchy");
    15.              }
    16.          }
    17.      }
    18. }
     
    DylanF, Jan 31, 2023
    #11