Search Unity

  1. Unity Asset Manager is now available in public beta. Try it out now and join the conversation here in the forums.
    Dismiss Notice

Feedback EditorLoop::Application.ProcessWindowsMessage profile marker

Discussion in '2020.1 Beta' started by Peter77, May 9, 2020.

  1. Peter77

    Peter77

    QA Jesus

    Joined:
    Jun 12, 2013
    Posts:
    6,609
    Looking at the 
    Application.ProcessWindowsMessage
    profile entry:

    upload_2020-5-9_9-42-29.png

    The sum of its children does not match its total "Time ms" cost. It shows 15.78ms, but the children sum up to 5.53ms (3.62+1.69+0.19+0.03).

    There are 10.25ms "missing" in the profiler, which is significant. Perhaps you want to improve that marker, which might allow us to more accurately report editor performance issues.
     
    Peter77, May 9, 2020
    #1

  2. aleksandrk

    aleksandrk

    Unity Technologies

    Joined:
    Jul 3, 2017
    Posts:
    3,014
    Hi!
    Note the "Self ms" column next to "Time ms" - this is the time spent inside this particular marker.
    For "Application.ProcessWindowsMessage" it's 10.23, which is very close to what you're missing there :)
     
    aleksandrk, May 10, 2020
    #2

  3. Peter77

    Peter77

    QA Jesus

    Joined:
    Jun 12, 2013
    Posts:
    6,609
    Thanks for your answer.

    Do you think it would be insightful to show what parts inside Application.ProcessWindowsMessage spend about 20% of the EditorLoop performance? :)
     
    Peter77, May 12, 2020
    #3

  4. aleksandrk

    aleksandrk

    Unity Technologies

    Joined:
    Jul 3, 2017
    Posts:
    3,014
    Idk, it depends on what's inside :)
     
    aleksandrk, May 12, 2020
    #4

  5. MartinTilo

    MartinTilo

    Unity Technologies

    Joined:
    Aug 16, 2017
    Posts:
    2,451
    Hi Peter,
    I've been looking into this a little bit. It appears to me as though most of that self time is spend in Windows APIs to actually get those messages. Still pondering if and how to clarify that via markers...
     
    MartinTilo, May 20, 2020
    #5
    Peter77 likes this.

  6. Peter77

    Peter77

    QA Jesus

    Joined:
    Jun 12, 2013
    Posts:
    6,609
    Really cool, thanks Martin! Looking forward to find out where all those ms are being spent and if we (and with we I really mean you (plural) ;)) can chop off some of it.
     
    Peter77, May 20, 2020
    #6

  7. MartinTilo

    MartinTilo

    Unity Technologies

    Joined:
    Aug 16, 2017
    Posts:
    2,451
    Not sure we can do anything there, this is Windows (as in the OS) spending time in it's APIs when we are looking through the message queue. Caveat: I'm not knowledgeable about the Windows platform code so I can't really make any definitiv conclusions here.
     
    MartinTilo, May 20, 2020
    #7

  8. MartinTilo

    MartinTilo

    Unity Technologies

    Joined:
    Aug 16, 2017
    Posts:
    2,451
    You can hook up PIX to the editor to get more details though.
     
    MartinTilo, May 20, 2020
    #8

  9. Peter77

    Peter77

    QA Jesus

    Joined:
    Jun 12, 2013
    Posts:
    6,609
    My hope was the 10ms aren't spread evenly across the entire method, but hopefully just a few code paths in that function that cause the most cost.

    And once those have been identified, new ideas usually arise how and if it's possible to optimize that code.

    But first we need to understand where and why, then we can act and find the how.

    I can be totally wrong of course, it's just my approach to these type of problems, so I'm thinking out loud. ;)

    EDIT: I'm know, you're the experts and I'm not. I'm just trying to spread some ideas here, which hopefully lead to a better Unity experience for me in terms of performance. I'm not trying to hurt your pride in any way.
     
    Last edited: May 20, 2020
    Peter77, May 20, 2020
    #9

  10. Baste

    Baste

    Joined:
    Jan 24, 2013
    Posts:
    6,332
    Are you saying that Windows is using 10ms to process a single message?

    That miiiight be you doing something no quite right when calling those API's. That sounds like way too much.
     
    Baste, May 25, 2020
    #10

  11. aleksandrk

    aleksandrk

    Unity Technologies

    Joined:
    Jul 3, 2017
    Posts:
    3,014
    No, it's not a single message in there. The profiler shows data for a single frame, and it processes multiple messages.
    From the code it looks like it's just doing the regular "Translate + Dispatch" WinAPI calls.
     
    aleksandrk, May 25, 2020
    #11

  12. MartinTilo

    MartinTilo

    Unity Technologies

    Joined:
    Aug 16, 2017
    Posts:
    2,451
    Well, in the provided screenshot there are at least 6 events being processed and each event (some may not show up here) has some self time that is not currently captured by a dedicated Profiler marker. That said, in a test where this thing took way longer (I was button mashing to get it to spike, not sure what exactly I did) I did indeed get a single message taking somewhere south of 8 ms (one instance in like >600 frames). I wouldn't presume to be able to make an educated guess if this is something on our side or on rhe Windows API or whatever might interfere with that? I have no clue about that code.
     
    MartinTilo, May 25, 2020
    #12