Question Edge problems when using scene depth in shader graph

Hello there,

i have created a water shader that is making use of the SCENE DEPTH to create a foam at the shore of the water. See A in my first image.


This is working fine now. The problem is that there are areas in the image were this leeds to problem. See B in my second image.



How can i get rid of this areas i marked in yellow?

thanks a lot!!
kai

 

This is unfortunately unavoidable when using MSAA. Because MSAA only applies to the screen color, not the underlying depth texture (which your water relies on). You can see how the depth values (right) are still aliased here, compared to the color (left):


So the only (easy/viable) way around this is to use the Anti-Aliasing options on the camera, instead of MSAA.

 

This is not true. When MSAA is used all target render buffers are muli-sampled (including depth buffer). If problem is really with MSAA, then correct depth buffer MSAA resolve step is required. This can be done in separate pass, or directly in shader where depth samples are used. To do so depth texture should be declared as Texture2DMS instead of ordinary Texture2D. For depth texture UNITY_DECLARE_DEPTH_TEXTURE_MS macro can be used. Than read all samples from pixel and decide how to handle edge cases properly (pick most distant one?).

 

Hello there,

thnak you both for the explanaition and the hint!
Anti aliasing did the trick for me!

thnaks
kai

 

Thanks, I think this is something I have been looking for. Do you have any examples of this being used in shader? I need subsample depth and normal values in order to implement this anti-aliasing method: https://history.siggraph.org/wp-con..._-Manifold-Garden-rendering-retrospective.pdf