Bug Dynamic buffers become corrupted

I've been having a problem with garbage data appearing in dynamic buffers on the client, and after finally getting something more reproducible I think I found the problem.

This is around line 576 in GhostReceiveSystem.c:

Code (CSharp):

1. buf.ResizeUninitialized((int)newCapacity);
2. //Move buffer content around (because the slot size is changed)
3. var sourcePtr = (byte*)buf.GetUnsafePtr() + GhostSystemConstants.SnapshotHistorySize*slotCapacity;
4. var destPtr = (byte*)buf.GetUnsafePtr() + GhostSystemConstants.SnapshotHistorySize*newSlotCapacity;
5. for (int i=0;i<GhostSystemConstants.SnapshotHistorySize;++i)
6. {
7.     destPtr -= newSlotCapacity;
8.     sourcePtr -= slotCapacity;
9.     UnsafeUtility.MemMove(destPtr, sourcePtr, slotCapacity);
10. }
11. slotCapacity = newSlotCapacity;

Both sourcePtr and destPtr doesn't take into account the buffer header so the buffer is corrupted after the copy.

After adding the header size to those two pointers I stopped getting corrupted values:

Code (csharp):

1.  
2. var sourcePtr = (byte*)buf.GetUnsafePtr() + SnapshotDynamicBuffersHelper.GetHeaderSize()+ GhostSystemConstants.SnapshotHistorySize*slotCapacity;
3. var destPtr = (byte*)buf.GetUnsafePtr() + SnapshotDynamicBuffersHelper.GetHeaderSize()+ GhostSystemConstants.SnapshotHistorySize*newSlotCapacity;
4.  

Also, there is a variable baselineDynamicDataPtr in the same file that seems to refer to that buffer. It looks like it might be used after the buffer reallocation, but not sure.

 

Thanks, that is very helpful. With this fixed I'm pretty happy with 0.6, but if we can get access to something newer soonish that would still be nice