Search Unity

Bug Did IL2CPP process change between 2019 and 2020?

Discussion in 'Windows' started by ARGs_code, Nov 4, 2022.

  1. ARGs_code

    ARGs_code

    Joined:
    May 7, 2019
    Posts:
    12
    We have not seen any notes about changes to the IL2CPP process in Unity 2020 and are trying to figure out an issue with our project after updating to Unity 2020.

    We are in the process of migrating a project for Microsoft HoloLens 2 from Unity 2019.4.23f1 to Unity 2020.3.41f1. We are seeing an issue compiling our visual studio solution that breaks our builds and is not reproducible in older versions of unity. We have a custom assembly .dll that has shown no issues until this update. The project still functions in the editor. When we attempt to build, we are successful in creating our visual studio solution. When we try to build our visual studio solution for Release targetting ARM64 (as required for most HoloLens 2 builds) we encounter an error related to our custom assembly that states that there is an invalid integer constant expression. The code referred to is here:

    #if FORCE_PINVOKE_INTERNAL || FORCE_PINVOKE_**Internal_INTERNAL
    IL2CPP_EXTERN_C int32_t DEFAULT_CALL DnsQuery_W(char**, int32_t, int32_t, int32_t, intptr_t*, int32_t);
    #endif

    When checking our previous .cpp from the same DLL that was generated from the Unity 2019 project this line of code is not present, instead we see


    #if FORCE_PINVOKE_INTERNAL
    IL2CPP_EXTERN_C int32_t DEFAULT_CALL DnsQuery_W(char**, int32_t, int32_t, int32_t, intptr_t*, int32_t);
    #endif

    Looking for any ideas on where to look to investigate this issue. As noted, the DLL functions perfectly in Unity 2019, and also in the Editor for 2020, so mostly curious if something has changed in the IL2CPP generation process for Unity 2020 that we have missed.
     
    ARGs_code, Nov 4, 2022
    #1

  2. Baste

    Baste

    Joined:
    Jan 24, 2013
    Posts:
    6,334
    This is not the forum for IL2CPP questions! Doubt that Visual Studio is the source of your problem :p

    I have no answer to your question, but if somebody does have, it would be @JoshPeterson
     
    Baste, Nov 4, 2022
    #2
    MelvMay likes this.

  3. ARGs_code

    ARGs_code

    Joined:
    May 7, 2019
    Posts:
    12
    Where should I direct this question?
     
    ARGs_code, Nov 4, 2022
    #3

  4. MelvMay

    MelvMay

    Unity Technologies

    Joined:
    May 24, 2013
    Posts:
    11,455
    Maybe the Windows Platform sub-forum? I can move your post if you wish.

    Josh tagged above though would likely be the person who'd have your answers. :)
     
    MelvMay, Nov 4, 2022
    #4
    ARGs_code likes this.

  5. Baste

    Baste

    Joined:
    Jan 24, 2013
    Posts:
    6,334
    So this is a bit silly, but since there's no subforum for "hey, we have technical questions regarding the compilation/build pipeline that shouldn't get drowned in 'duh how for loops work'", the best bet for these kinds of things is generally to ask in Experimental Scripting Previews.
     
    Baste, Nov 4, 2022
    #5

  6. ARGs_code

    ARGs_code

    Joined:
    May 7, 2019
    Posts:
    12
    Please, thank you
     
    ARGs_code, Nov 4, 2022
    #6
    MelvMay likes this.

  7. MelvMay

    MelvMay

    Unity Technologies

    Joined:
    May 24, 2013
    Posts:
    11,455
    Done.
     
    MelvMay, Nov 4, 2022
    #7

  8. Tautvydas-Zilys

    Tautvydas-Zilys

    Unity Technologies

    Joined:
    Jul 25, 2013
    Posts:
    10,674
    Can you show the full compiler error message and the source code it's complaining about in [ CODE ] tags?
     
    Tautvydas-Zilys, Nov 4, 2022
    #8

  9. ARGs_code

    ARGs_code

    Joined:
    May 7, 2019
    Posts:
    12

    Code (CSharp):
    1. #if FORCE_PINVOKE_INTERNAL || FORCE_PINVOKE_**Internal_INTERNAL
    2. IL2CPP_EXTERN_C int32_t DEFAULT_CALL DnsQuery_W(char**, int32_t, int32_t, int32_t, intptr_t*, int32_t);
    3. #endif
    The GameAssembly.lib failure is something we are ignoring because the file doesn't finish being made due to this exception and doesn't exist, so it can't be opened.
     
    ARGs_code, Nov 4, 2022
    #9

  10. Tautvydas-Zilys

    Tautvydas-Zilys

    Unity Technologies

    Joined:
    Jul 25, 2013
    Posts:
    10,674
    Do you have source code for this DLL? Can you show how the "DnsQuery_W" method is declared in C#?
     
    Tautvydas-Zilys, Nov 4, 2022
    #10

  11. ARGs_code

    ARGs_code

    Joined:
    May 7, 2019
    Posts:
    12
    Yes, have already requested it from the team that compiled it. It may take a little while before I can provide it.
     
    ARGs_code, Nov 4, 2022
    #11

  12. ARGs_code

    ARGs_code

    Joined:
    May 7, 2019
    Posts:
    12
    Here is the declaration of method:

    [DllImport("**Internal", EntryPoint = "DnsQuery_W", CharSet = CharSet.Unicode, SetLastError = true, ExactSpelling = true)]
    private static extern int DnsQuery([MarshalAs(UnmanagedType.VBByRefStr)]ref string pszName, QueryTypes wType, QueryOptions options, int aipServers, ref IntPtr ppQueryResults, int pReserved);
     
    ARGs_code, Nov 4, 2022
    #12

  13. Tautvydas-Zilys

    Tautvydas-Zilys

    Unity Technologies

    Joined:
    Jul 25, 2013
    Posts:
    10,674
    Okay, so this is definitely a bug in IL2CPP. If you could report a bug, we would be able to address it.

    That said, you should be able to work around it on your own. There is a typo in that signature you pasted. It should be this:

    Code (csharp):
    1. [DllImport("__Internal", EntryPoint = "DnsQuery_W", CharSet = CharSet.Unicode, SetLastError = true, ExactSpelling = true)]
    2. private static extern int DnsQuery([MarshalAs(UnmanagedType.VBByRefStr)]ref string pszName, QueryTypes wType, QueryOptions options, int aipServers, ref IntPtr ppQueryResults, int pReserved);
    (Notice "__Internal" instead of "**Internal"). However, I'm not sure if this function is supported on UWP and if it's not, this change will make it so you get a linker error about it being an unresolved external symbol. Alternatively, you could remove that function since it would have thrown a DllNotFoundException previously anyway due to that typo.
     
    Tautvydas-Zilys, Nov 4, 2022
    #13
    ARGs_code likes this.

  14. ARGs_code

    ARGs_code

    Joined:
    May 7, 2019
    Posts:
    12
    Thank you, we will make this change and recompile the assembly and test.

    Given this DLL has compiled just fine to UWP with Unity 2019.4.x, can you please explain why you consider **Internal a typo? It would be helpful to explain to the team that compiled this DLL for my team, since it compiled just fine in all previous versions of Unity we have worked with. We are currently using this DLL in an app published on the Microsoft Store and have not encountered any issues until the upgrade to Unity 2020, as noted in the original post.

    I will open a bug report as well.
     
    ARGs_code, Nov 4, 2022
    #14

  15. Tautvydas-Zilys

    Tautvydas-Zilys

    Unity Technologies

    Joined:
    Jul 25, 2013
    Posts:
    10,674
    So the reason it doesn't compile because it's a bug in IL2CPP. It accidentally does not expect the DLL name to contain characters that are not valid C++ identifiers other that '.' and '-', and "*" is not a valid identifier in C++. If this worked correctly, it would just replace the invalid characters with something else instead of triggering a compilation error.

    The reason I am saying it is a typo because it looks very similar to the "__Internal" keyword that IL2CPP supports in the [DllImport] attribute. It has a special meaning: functions that are annotated that way will be resolved by the linker at build time, rather than loaded at runtime. "**Internal", on the other hand, has no special meaning, so unless you have a native plugin that is named "**Internal.dll", it makes no sense. "**Internal.dll" sounds an unlikely file name so that's why I thought it was a typo.

    As for the DLL working fine before: perhaps this function is just never called? If it's never called, it will never try to load the non-existing DLL and will never throw an exception.
     
    Tautvydas-Zilys, Nov 4, 2022
    #15

  16. ARGs_code

    ARGs_code

    Joined:
    May 7, 2019
    Posts:
    12
    This function is used in the application. In my initial post, you can see that this function is compiled when building from a solution created in Unity 2019 and shows up as

    #if FORCE_PINVOKE_INTERNAL
    IL2CPP_EXTERN_C int32_t DEFAULT_CALL DnsQuery_W(char**, int32_t, int32_t, int32_t, intptr_t*, int32_t);
    #endif

    That's what made this confusing and why it seemed so strange that compiling a Visual Studio Solution from 2019 works fine and results in the above code, but compiling a visual studio solution from 2020 results in the "typo" you are referring to. Thank you for the additional information.
     
    ARGs_code, Nov 4, 2022
    #16

  17. Tautvydas-Zilys

    Tautvydas-Zilys

    Unity Technologies

    Joined:
    Jul 25, 2013
    Posts:
    10,674
    Just because it is compiled doesn't mean it's actually called at runtime.
     
    Tautvydas-Zilys, Nov 4, 2022
    #17

  18. Anthiese

    Anthiese

    Joined:
    Oct 13, 2013
    Posts:
    73
    It turns out the docs for P/Invoke on UWP actually do say to use "**Internal"
    https://docs.unity3d.com/2020.3/Documentation/Manual/windowsstore-plugins-il2cpp.html
    https://docs.unity3d.com/2022.2/Documentation/Manual/windowsstore-plugins-il2cpp.html
     
    Anthiese, Nov 16, 2022
    #18

  19. Tautvydas-Zilys

    Tautvydas-Zilys

    Unity Technologies

    Joined:
    Jul 25, 2013
    Posts:
    10,674
    Oh geez, thank you for pointing that out. The code samples look correct but the text section is mangled. I'll make sure we fix this. EDIT: issue tracker link: https://issuetracker.unity3d.com/issues/typo-in-uwp-documentation
     
    Tautvydas-Zilys, Nov 17, 2022
    #19
    Anthiese likes this.