Creating a music on/off button

So I am trying to create a button to turn on/off music. I have created an empty object called "Music" with an audio source attached with the music. I also have a script for the button:

Code (CSharp):

1. using System.Collections;
2. using System.Collections.Generic;
3. using UnityEngine;
4.  
5. public class MusicVolume : MonoBehaviour
6. {
7.     AudioSource audioSource = null;
8.    
9.     void start()
10.     {
11.         audioSource = gameObject.GetComponent<AudioSource>();
12.     }
13.  
14.     public void MenuMusicVolume()
15.     {
16.         if (audioSource.mute == false)
17.         {
18.             audioSource.mute = true;
19.         }
20.  
21.         if (audioSource.mute == true)
22.         {
23.             audioSource.mute = false;
24.         }
25.     }
26. }

Heres the button:

Any help is greatly appreciated

 

One issue is with your .mute property toggling logic. Assume that audioSource.mute == false and then consider what will happen, step-by-step, when you call your MenuMusicVolume method. This script will mute your audio source but never unmute it.

 

Some of the setup is off-screen but the way I imagine it seams legit. Are you experiencing any specific issues other then the one above?

 

I thought that if audioSource.mute == false was detected, it would make audioSource.mute = true. Then if it detected that audioSource.mute == true, it would make audioSource.mute = false.

 

Whenever I press the button, the script doesn't make audioSource.mute = true.

 

That's exactly right and that's exactly the problem here
Thing is the way you structured your conditions will make all this happen in a single frame / single call to MenuMusicVolume method.

Let's say you sound is muted. You click your button. Then MenuMusicVolume method gets called. (audioSource.mute == false) conditions is evaluated to true. Line 18 is executed and sound get unmuted. Then the condition (audioSource.mute == true) gets evaluated to true since we just set the audioSource.mute value to true. Line 23 gets executed and we mute the sound. All that happened in 1/10 of a millisecond and so no sound ever played.

Try this:

Code (CSharp):

1.     using System.Collections;
2.     using System.Collections.Generic;
3.     using UnityEngine;
4.    
5.     public class MusicVolume : MonoBehaviour
6.     {
7.         AudioSource audioSource = null;
8.      
9.         void start()
10.         {
11.             audioSource = gameObject.GetComponent<AudioSource>();
12.         }
13.    
14.         public void MenuMusicVolume()
15.         {
16.             audioSource.mute = !audioSource.mute;
17.         }
18.     }

Further reading:
http://faculty.cs.niu.edu/~hutchins/csci473/control.htm
https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/keywords/if-else
https://docs.microsoft.com/en-us/do...-logical-operators#logical-negation-operator-

 

Sounds like the issue is with the button setup - the off-screen part. Make sure that when you click your button then MenuMusicVolume method actually gets called. Use either debugger or Debug.Log for that test.

 

Ok, now I see what you were saying.

 

I can confirm that the button calls the MenuMusicVolume method and the music still doesn't get muted.

 

I also keep getting this error, even though I have the correct script as a component of my object.
NullReferenceException: Object reference not set to an instance of an object

 

The error will have the specific script and line number, which is the important information. You go to that line number, see what reference types are on that line. If more than 1 are on that line, add debugging ahead of it to determine which is null. Once you know exactly what is null, then you can start to investigate why it is null, once you know why it is null, then you can start to work on making it not null before trying to use it.

This is a type of error you have to get good at fixing, because it is extremely common, and always resolved using the same process.

 

Best guess is that you're getting NullReferenceException on line: audioSource.mute = !audioSource.mute;

Reason would be that we fail earlier at line: audioSource = gameObject.GetComponent<AudioSource>();

This line tries to find a component of type AudioSource on this GameObject and assigns it's reference to audioSource variable.
https://docs.unity3d.com/ScriptReference/GameObject.GetComponent.html

If the component is not there then audioSource remains null value and causes the exception down the line.
All this will happen unless both the AudioSource component we're trying to mute and our MusicVolume component are both attached to the same GameObject.

 

I have the script attached to the same object that has the audio source.

 

Heres the attached script in case I attached it wrong:

 

OK I think the screenshots confirm my diagnosis. Your Music GameObject has following components: Transform, AudioSource, ButtonTeleportation. However it does not have the MusicVolume component. It should!

EDIT: One sec. I can see at least one more issue here. will edit here further.

EDIT2: OK so do this. 1. Move your MusicVolume component (wherever it is now) to your Music GameObject. 2. In the Button inspector in OnClick section set it up such that button click calls the MusicVolume.MenuMusicVolume method of our Music GameObject.

 

I put the code from the Music Volume script into my Button Teleportation script (the script I use for all the other menu buttons) to make it more convenient for myself.

 

OK this is getting ridiculous. I don't have enough information to go on and the information I do have keeps changing. Post the whole thing as it is now.

 

I set it up it still does not mute:

 

That's not nearly enough for me to go on. I need the Hierarchy, Inspector for the GOs in Hierarchy, the scripts in full and who knows what else. Best if you publish a git repo for entire project or a package with a self-contained part of the project or something for me to have a look at and test.

 

Exception is thrown in MusicVolume component. As discussed before it will do that because it is not attached to the same GameObject that has AudioSource component - Music GameObject.

The Music GameObject does have a ButtonTeleportation component but this component is not the one throwing the exception.

The MusicVolume.MenuMusicVolume() method gets called somehow but that setup is not included in the screenshots. Perhaps you are clicking the wrong button.

 

That error is from hours ago when I had the other script connected - I probably shouldn't have included it. The most recent errors are:

 

ButtonTeleportation.start() should be ButtonTeleportation.Start()
https://docs.unity.cn/Manual/EventFunctions.html
https://docs.unity.cn/ScriptReference/MonoBehaviour.html
https://docs.unity.cn/ScriptReference/MonoBehaviour.Start.html

 

That worked! Not sure how that wasn't in any of the errors though.

 

It wouldn't. Compiler catches syntax errors. This is not a syntax error. This is a human error of not understanding the underlying technology. The code works. It just doesn't do what you wanted it to do.

 

Understandable. Thanks for helping me