Search Unity

Contributing to packages

Discussion in 'Package Manager' started by JakHussain, Jan 23, 2020.

  1. JakHussain

    JakHussain

    Joined:
    Oct 20, 2016
    Posts:
    318
    The discussion on this has died down a bit but are there any plans by Unity to eventually allow pull requests on the github repos of their packages?

    I imagine development could be a lot faster since there's so many super clever people willing to help improve Unity for nothing in return.

    Could the licenses for packages be updated to allow this?
     
    brunocoimbra, AskCarol and Favo-Yang like this.
  2. bdovaz

    bdovaz

    Joined:
    Dec 10, 2011
    Posts:
    1,052
  3. Mathijs_Bakker

    Mathijs_Bakker

    Joined:
    Apr 28, 2014
    Posts:
    25
  4. AskCarol

    AskCarol

    Joined:
    Nov 12, 2019
    Posts:
    234
    Thanks for the question @JakHussain! I'll ask the team and circle back once I have a definitive answer :)
     
  5. okcompute_unity

    okcompute_unity

    Unity Technologies

    Joined:
    Jan 16, 2017
    Posts:
    756
    Hi @JakHussain,

    Yes, this is something we would like to enable at some point in the future. *But*, it requires a lot of re-shuffling and reworks of our internal infrastructure. This will take some time. I don't have an ETA for you. Sorry!

    Regards,

    Pascal
     
  6. JakHussain

    JakHussain

    Joined:
    Oct 20, 2016
    Posts:
    318
    Thanks, @okcompute_unity! So just to elaborate, is this something that's just trailing at the end of the backlog that the relevant teams hope to eventually get to "at some point" or is this a prioritised task that has not ETA but is actively being pushed internally?
     
    bdovaz likes this.
  7. okcompute_unity

    okcompute_unity

    Unity Technologies

    Joined:
    Jan 16, 2017
    Posts:
    756
    Update. Your question triggered me to go deeper and look at the current state of this requirement that was on the table when we started the Package Manager initiative. My product manager just told me this is not a priority anymore and won't be pushed internally. Sorry!

    Pascal
     
  8. Murgilod

    Murgilod

    Joined:
    Nov 12, 2013
    Posts:
    10,157
    What is a priority then?
     
  9. angrypenguin

    angrypenguin

    Joined:
    Dec 29, 2011
    Posts:
    15,620
    This kind of thing is why Unity is building a reputation of half-doing something and then giving up and moving on.

    Edit: My mistake, this is actually in reference to stuff said in a different thread.
     
    Last edited: Apr 7, 2020
    soleron and id0 like this.
  10. MadeFromPolygons

    MadeFromPolygons

    Joined:
    Oct 5, 2013
    Posts:
    3,982
    So what exactly is the point of allowing public access to the github repos at all given that most / all of issues are being closed and this is "not a priority anymore" as you said?

    Is there actually a plan to the whole package manager thing because its starting to look like there really isnt?
     
  11. JakHussain

    JakHussain

    Joined:
    Oct 20, 2016
    Posts:
    318
    @GameDevCouple in unity's defence, the package manager as a concept was always more for them than it was for us since it enables their teams to be much more agile and work independently of each other and as a result, we get updates way faster to the point they only need two tech releases a year.

    That being said, I agree that teasing us with visibility on github is just annoying. User issues are still tracked with the original issue tracker even for packages (and a lot of the time, unofficially on the forums) and documentation is further fragmented with the never updating readme files. I'm not saying they should keep their readmes up to date too but the point is that if we can't do anything with the public visibility of the packages on github apart from cloning early unstable versions of code, then it's no more valuable to us than dumpster diving through the locally downloaded package anyway.

    XML commenting is what drives the docfx documentation sites. Even tiny stuff like that could be supported.

    I also don't buy that it's JUST an infrastructure problem. If the SRP team are using github and from there, pushing to other internal services in Unity, then any external contributions on GitHub have nothing to do with that because it's at the repository level. I won't even own the IP to any changes I make in my pull requests. I'd be a collaborator sure but the license clearly states that the repo and everything in it belongs to Unity.
     
    elJoel and MadeFromPolygons like this.
  12. JakHussain

    JakHussain

    Joined:
    Oct 20, 2016
    Posts:
    318
    Apologies for the rant but the situation honestly does bother me a fair bit.
     
    n3xxt, soleron and Flurgle like this.
  13. Murgilod

    Murgilod

    Joined:
    Nov 12, 2013
    Posts:
    10,157
    This isn't a defense at all when the package manager COULD provide that same benefit (in fact, more) to the end user as well.
     
    Flurgle likes this.
  14. Mindstyler

    Mindstyler

    Joined:
    Aug 29, 2017
    Posts:
    248
    Is there any update on this? Especially now that entities 0.50 has released and uses source generators, it would be amazing to be able to contribute to the source, improving source generation / compile time / performance of dots. All other packages would of course also be nice to be able to contribute to. Unity, let us help you become the best engine out there.