Compilation of Issues with 0.50

joepl · Apr 29, 2022

@optimise The main addition for 0.51 is support for Unity 2021 LTS. There is much in active development, but I believe the main purpose of that release is to enable 2021 development (new stuff coming later!).

ScottPeal · May 15, 2022

Waiting on 0.51 release as 2021 LTS is out and would like like to start with it. Any guess on how much longer?

Antypodish · May 16, 2022

ScottPeal said: ↑

Waiting on 0.51 release as 2021 LTS is out and would like like to start with it. Any guess on how much longer?
Click to expand...

These question was answered multiple times in recent other threads. Please read them and do no hijack other threads like this one.

Sylmerria · May 25, 2022

Abbrew said: ↑

Making the IJobEntity partial is required - I get a compilation error otherwise. Here's the IJobEntity

Code (CSharp):

[BurstCompile]

private partial struct DecisionMakerJob : IJobEntity

{

public EntityCommandBuffer.ParallelWriter ecbParallel;

public BehaviorWriters behaviorWriters;

[ReadOnly]

public ComponentDataFromEntity<BehaviorProgressComponent> behaviorProgressFromEntity;

[ReadOnly]

public ComponentDataFromEntity<BehaviorResultComponent> behaviorResultFromEntity;

public void Execute(

Entity decisionMakerEntity,

[EntityInQueryIndex] int entityInQueryIndex,

in BehaviorProgressComponent progress,

in DynamicBuffer<DecisionMakerConditionElement> conditions,

ref DynamicBuffer<DecisionMakerConditionAllRemainingElement> conditionsRemaining,

in DynamicBuffer<DecisionMakerConditionAllElement> conditionsUnique,

in DynamicBuffer<DecisionMakerTaskElement> tasks,

in DynamicBuffer<DecisionMakerKickoffTaskElement> kickoffTasks,

in DynamicBuffer<DecisionMakerDurationTaskElement> durationTasks,

ref DynamicBuffer<DecisionMakerDurationTaskCurrentElement> currentDurationTasks,

in DynamicBuffer<DecisionMakerPlanElement> plans,

ref DynamicBuffer<DecisionMakerCurrentPlanElement> currentTasks,

in DynamicBuffer<DecisionMakerFallbackTaskElement> fallbackTasks,

in DynamicBuffer<DecisionMakerFallbackKickoffTaskElement> fallBackKickoffTasks,

in DynamicBuffer<DecisionMakerFallbackDurationTaskElement> fallbackDurationTasks,

in DecisionMakerFallbackAnimationComponent fallbackAnimation,

in DynamicBuffer<DecisionMakerAnimationElement> animations,

ref DecisionMakerAnimationCurrentComponent currentAnimation

)

{

var conditionAllsFast = conditionsUnique.AsNativeArray();

var conditionsFast = conditions.AsNativeArray();

var tasksFast = tasks.AsNativeArray();

var behaviorProgressChange = false;

var newState = INVALID_STATE;

switch (progress.state)

{

case (int)State.START_PLANNING:

conditionsRemaining.Clear();

foreach (var conditionAll in conditionAllsFast)

{

var conditionAllEntity = conditionAll.entity;

BehaviorSystemActions.Start(ecbParallel, entityInQueryIndex, conditionAllEntity);

conditionsRemaining.Add(new DecisionMakerConditionAllRemainingElement

{

entity = conditionAllEntity

});

}

behaviorProgressChange = true;

newState = (int)State.WAIT_FOR_PLANNING;

break;

case (int)State.WAIT_FOR_PLANNING:

var numConditionAllRemainings = conditionsRemaining.Length;

for (var j = numConditionAllRemainings - 1; j >= 0; j--)

{

var numConditionAllRemainingEntity = conditionsRemaining[j].entity;

if (Hint.Likely(BehaviorSystemActions.IsComplete(behaviorProgressFromEntity, numConditionAllRemainingEntity)))

{

conditionsRemaining.RemoveAtSwapBack(j);

}

}

// All conditions have completed

if (Hint.Unlikely(conditionsRemaining.IsEmpty))

{

var numPlansAmount = plans.Length;

// Create a lookup of conditions to their plans

var numConditions = conditionsFast.Length;

var conditionsToPlans = new NativeMultiHashMap<Entity, int>(numConditions, Allocator.Temp);

foreach (var condition in conditionsFast)

{

conditionsToPlans.Add(condition.entity, condition.planIndex);

}

// Count how many conditions each plan has completed

var plansToNumConditionsCompleted = new NativeArray<int>(numPlansAmount, Allocator.Temp);

foreach (var conditionAll in conditionAllsFast)

{

var conditionAllEntity = conditionAll.entity;

if (Hint.Unlikely(behaviorResultFromEntity[conditionAllEntity].success))

{

if (Hint.Likely(conditionsToPlans.TryGetFirstValue(conditionAllEntity, out var planIndex, out var it)))

{

plansToNumConditionsCompleted[planIndex] = plansToNumConditionsCompleted[planIndex] + 1;

while (Hint.Unlikely(conditionsToPlans.TryGetNextValue(out planIndex, ref it)))

{

plansToNumConditionsCompleted[planIndex] = plansToNumConditionsCompleted[planIndex] + 1;

}

}

}

}

// Iterate through all plans

var plansFast = plans.AsNativeArray();

var planTasks = new NativeList<Entity>(Allocator.Temp);

var planDurationTasks = new NativeList<Entity>(Allocator.Temp);

var planSucceeded = false;

for (var planIndex = 0; planIndex < numPlansAmount; planIndex++)

{

if (Hint.Unlikely(plansToNumConditionsCompleted[planIndex] == plansFast[planIndex].numConditionsRequired))

{

planSucceeded = true;

// Choose only the tasks with all conditions completed

foreach (var task in tasksFast)

{

if (Hint.Unlikely(task.planIndex == planIndex))

{

planTasks.Add(task.entity);

}

}

// Kickoff the kickoff tasks

foreach(var kickoffTask in kickoffTasks.AsNativeArray())

{

if (Hint.Unlikely(kickoffTask.planIndex == planIndex))

{

BehaviorSystemActions.Start(ecbParallel, entityInQueryIndex, kickoffTask.entity);

}

}

// Choose the duration tasks

foreach(var durationTask in durationTasks.AsNativeArray())

{

if(Hint.Unlikely(durationTask.planIndex == planIndex))

{

planDurationTasks.Add(durationTask.entity);

}

}

// Choose only the animation with all conditions completed

var chosenAnimation = animations[planIndex];

currentAnimation.entity = chosenAnimation.entity;

currentAnimation.loop = chosenAnimation.loop;

break;

}

}

// Empty means no plan succeeded

if (!planSucceeded)

{

// Fallback tasks

foreach (var fallbackTask in fallbackTasks.AsNativeArray())

{

planTasks.Add(fallbackTask.entity);

}

// Fallback duration tasks

foreach(var durationTask in fallbackDurationTasks.AsNativeArray())

{

planDurationTasks.Add(durationTask.entity);

}

// Kickoff the kickoff tasks

foreach (var kickoffTask in fallBackKickoffTasks.AsNativeArray())

{

BehaviorSystemActions.Start(ecbParallel, entityInQueryIndex, kickoffTask.entity);

}

currentAnimation.entity = fallbackAnimation.entity;

currentAnimation.loop = fallbackAnimation.loop;

}

// Start the chosen tasks

currentTasks.Clear();

foreach (var planTask in planTasks.AsArray())

{

currentTasks.Add(new DecisionMakerCurrentPlanElement

{

entity = planTask

});

BehaviorSystemActions.Start(ecbParallel, entityInQueryIndex, planTask);

}

// Start the chosen duration tasks

currentDurationTasks.Clear();

foreach (var currentDurationTask in planDurationTasks.AsArray())

{

currentDurationTasks.Add(new DecisionMakerDurationTaskCurrentElement

{

entity = currentDurationTask

});

BehaviorSystemActions.Start(ecbParallel, entityInQueryIndex, currentDurationTask);

}

// Start the chosen animation

BehaviorSystemActions.Start(ecbParallel, entityInQueryIndex, currentAnimation.entity);

behaviorProgressChange = true;

newState = (int)State.WAIT_FOR_DECISION;

}

break;

case (int)State.WAIT_FOR_DECISION:

// Count the number of tasks still running

var numTasksRemaining = currentTasks.Length;

for (var j = numTasksRemaining - 1; j >= 0; j--)

{

var taskRemainingEntity = currentTasks[j].entity;

if (Hint.Unlikely(BehaviorSystemActions.IsComplete(behaviorProgressFromEntity, taskRemainingEntity)))

{

currentTasks.RemoveAtSwapBack(j);

}

}

// Check if animation is completed only if it doesn't loop

var animationCompleted = BehaviorSystemActions.IsComplete(behaviorProgressFromEntity, currentAnimation.entity);

var animationLoops = currentAnimation.loop;

var animationTaskCompleted = animationLoops | animationCompleted;

// Loop the animation when appropriate

if (Hint.Unlikely(animationLoops & animationCompleted))

{

BehaviorSystemActions.Start(ecbParallel, entityInQueryIndex, currentAnimation.entity);

}

if (Hint.Unlikely(currentTasks.IsEmpty & animationTaskCompleted))

{

// Stop the duration tasks

foreach (var durationTaskInProgress in currentDurationTasks.AsNativeArray())

{

BehaviorSystemActions.Succeed(behaviorWriters, durationTaskInProgress.entity);

}

goto case (int)State.START_PLANNING;

}

break;

case (int)State.RESTART:

// Cancel all possibly running behaviors

BehaviorSystemActions.Succeed(behaviorWriters, currentAnimation.entity);

foreach (var conditionInProgress in conditionsRemaining.AsNativeArray())

{

BehaviorSystemActions.Succeed(behaviorWriters, conditionInProgress.entity);

}

foreach (var taskInProgress in currentTasks.AsNativeArray())

{

BehaviorSystemActions.Succeed(behaviorWriters, taskInProgress.entity);

}

foreach(var durationTaskInProgress in currentDurationTasks.AsNativeArray())

{

BehaviorSystemActions.Succeed(behaviorWriters, durationTaskInProgress.entity);

}

behaviorProgressChange = true;

newState = (int)State.START_PLANNING;

break;

default:

break;

}

if (Hint.Unlikely(behaviorProgressChange))

{

BehaviorSystemActions.Progress(behaviorWriters, decisionMakerEntity, newState);

}

}

Click to expand...

Hey Abbrew, did you manage to solve this ?
I have almost the same problem after upgrading my code to 0.50
All my IJobEntity create this warning which appears to crash the compiler without log some how and I don't know how to solve that :/

Console error said:

Microsoft (R) Visual C# Compiler version 3.8.0-dev.20527.1 (53dc6556)
Copyright (C) Microsoft Corporation. All rights reserved.

error SGJE0003: The parameter 'index' of type int will be ignored.
Assets\Scripts\ECS\Storage\System\RemoveResourceFromStorageSystem.cs(54,31): info SP0001: Diagnostic 'CS0282: There is no defined ordering between fields in multiple declarations of partial struct 'RemoveResourceFromStorageSystem.ApplyActionRemoveResourceJob'. To specify an ordering, all instance fields must be in the same declaration.' was programmatically suppressed by a DiagnosticSuppressor with suppression ID 'SPDC0282' and justification 'Some DOTS types utilize codegen requiring the type to be partial.'
Assets\Scripts\ECS\Storage\System\AddResourceToStorageSystem.cs(55,31): info SP0001: Diagnostic 'CS0282: There is no defined ordering between fields in multiple declarations of partial struct 'AddResourceToStorageSystem.ApplyActionAddResourceJob'. To specify an ordering, all instance fields must be in the same declaration.' was programmatically suppressed by a DiagnosticSuppressor with suppression ID 'SPDC0282' and justification 'Some DOTS types utilize codegen requiring the type to be partial.'
Assets\Scripts\ECS\Storage\System\StorageStateSystem.cs(47,31): info SP0001: Diagnostic 'CS0282: There is no defined ordering between fields in multiple declarations of partial struct 'StorageStateSystem.ApplyStorageStateActionJob'. To specify an ordering, all instance fields must be in the same declaration.' was programmatically suppressed by a DiagnosticSuppressor with suppression ID 'SPDC0282' and justification 'Some DOTS types utilize codegen requiring the type to be partial.'
Assets\Scripts\ECS\FollowEvent\FollowEventSystem.cs(163,31): info SP0001: Diagnostic 'CS0282: There is no defined ordering between fields in multiple declarations of partial struct 'FollowEventSystem.GetEntityToFollowJob'. To specify an ordering, all instance fields must be in the same declaration.' was programmatically suppressed by a DiagnosticSuppressor with suppression ID 'SPDC0282' and justification 'Some DOTS types utilize codegen requiring the type to be partial.'
Assets\Scripts\ECS\VariableSystem\VariableSystem.cs(105,31): info SP0001: Diagnostic 'CS0282: There is no defined ordering between fields in multiple declarations of partial struct 'VariableSystem.UpdateVariableBoolJob'. To specify an ordering, all instance fields must be in the same declaration.' was programmatically suppressed by a DiagnosticSuppressor with suppression ID 'SPDC0282' and justification 'Some DOTS types utilize codegen requiring the type to be partial.'
Assets\Scripts\ECS\VariableSystem\VariableSystem.cs(134,31): info SP0001: Diagnostic 'CS0282: There is no defined ordering between fields in multiple declarations of partial struct 'VariableSystem.UpdateVariableIntJob'. To specify an ordering, all instance fields must be in the same declaration.' was programmatically suppressed by a DiagnosticSuppressor with suppression ID 'SPDC0282' and justification 'Some DOTS types utilize codegen requiring the type to be partial.'
Assets\Scripts\ECS\VariableSystem\VariableSystem.cs(164,31): info SP0001: Diagnostic 'CS0282: There is no defined ordering between fields in multiple declarations of partial struct 'VariableSystem.UpdateVariableFloatJob'. To specify an ordering, all instance fields must be in the same declaration.' was programmatically suppressed by a DiagnosticSuppressor with suppression ID 'SPDC0282' and justification 'Some DOTS types utilize codegen requiring the type to be partial.'
Assets\Scripts\ECS\ProductionLine\ProductionLineSystem.cs(220,31): info SP0001: Diagnostic 'CS0282: There is no defined ordering between fields in multiple declarations of partial struct 'ProductionLineSystem.DataPreparationForProductionLineActivationJob'. To specify an ordering, all instance fields must be in the same declaration.' was programmatically suppressed by a DiagnosticSuppressor with suppression ID 'SPDC0282' and justification 'Some DOTS types utilize codegen requiring the type to be partial.'
etc ....
Click to expand...

Sylmerria · May 26, 2022

Ok found.
It seems that forget to add EntityInQueryIndex attribute to your index parameter crashes code gen without telling you what's going on especially when error SGJE0003 look like a warning.

thelebaron · May 27, 2022

ok, physics has an invalid dependency of entities 0.50.1-preview.1(but 0.50.1-preview.2 exists). minor but come on guys

lclemens · Oct 14, 2022

Sylmerria said: ↑

Hey Abbrew, did you manage to solve this ?
I have almost the same problem after upgrading my code to 0.50
All my IJobEntity create this warning which appears to crash the compiler without log some how and I don't know how to solve that :/
Click to expand...

@Abbrew

So I was trying to figure this out too. I think we can either just ignore that warning, or suppress it.

The release notes for 1.0 say this:

Valid compilation errors can cause additional
CS0282 warnings from source-generated partial types: There is no defined ordering between fields in multiple declarations of partial struct. These are typically suppressed with a diagnostic suppressor for generated types, but an issue with the Roslyn compiler can prevent these from being suppressed if other compilation errors occur. This can result in many of these warnings in the Unity console. These can also be suppressed by adding - nowarn:0282 to a Unity rsp file (see this link for details).

The instructions for suppression are here: https://docs.unity3d.com/530/Documentation/Manual/PlatformDependentCompilation.html

Search Unity

Compilation of Issues with 0.50

joepl

Unity Technologies

ScottPeal

Antypodish

Sylmerria

Sylmerria

thelebaron

lclemens

Search Unity

Unity ID

Useful Searches

Compilation of Issues with 0.50

joepl

Unity Technologies

ScottPeal

Antypodish

Sylmerria

Sylmerria

thelebaron

lclemens