Bug Compilation error in LegacyJointBakingSystem.cs when Physics engine module is disabled

Unity 2022.2.1f1 and com.unity.physics 1.0.0-pre.15

Library/PackageCache/com.unity.physics@1.0.0-pre.15/Unity.Physics.Hybrid/EntitiesBaking/BakingSystems/LegacyJointBakingSystem.cs(277,7): error CS1025: Single-line comment or end-of-line expected

Library/PackageCache/com.unity.physics@1.0.0-pre.15/Unity.Physics.Hybrid/EntitiesBaking/BakingSystems/LegacyJointBakingSystem.cs(289,7): error CS1025: Single-line comment or end-of-line expected

These are the two compiler errors that come up when the Physics module is disabled. This looks like it happens because one of the preprocessor directives in the file is matched to the #endif in block comments. For example:

Code (CSharp):

1. #if LEGACY_PHYSICS
2.  
3. ...
4.  
5. /*
6. #if UNITY_EDITOR
7.                 DstEntityManager.SetName(jointEntity, $"{baseName} ({joints[i].JointType})");
8. #endif*/

That is the #endif on line 289.

 

This repros with an empty project as attached (2022.2.3f1).
The Physics module can be removed, triggering recompilation of Unity Physics and causing a compile error.
Edit: still occurs on 2022.2.4f1.

 

That is good to hear, thanks! I noticed 1.0.0-pre.44 is a bit more cavalier in assuming the engine module is installed (similar empty project makes ~40 errors this time), it will be a relief when we can safely cut away the modules and packages that we don’t want to depend on!

 

Oh. Right. That package also depends on UGUI for whatever reason. I suppose those packages and modules will have to stick around for Entities Graphics using URP or HDRP, then.